From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E941E47A0AE for ; Fri, 15 May 2026 11:36:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778844982; cv=none; b=cquPFVd8UznZm56EIIT0PPX05Qds3x1qkIV43YQZhaEkCNU6hU2P6AsmFYtyfMLArhOUfp4vEfvrHdoNd/gdojb+3f+YyZ8xSvFNha02XxjJhXFinANNWD504pj1azLWRfOXAKkAk7R0XKkb7+sMEWhjiuG9m3BZtkxSZSWU5oE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778844982; c=relaxed/simple; bh=uAY04i7si7CzF2ofplxmgA6xM+wgTQXcak9iKdl1kzI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gufE67wE+uHvl+pUpWbi1gIS/H+05h6CH2t9yDm5t2nzwZN1eY4+7aWc9DDb0pSNlbCJUSsaHcEBpEqdWn5VtlyO3wOGxq51qthTMkq6Zm8dSGC5dzFeZmwbSb6AnaACQNgCjekuncHI8I4wjMFwOZFsm+6VBS/tANygwkZeRZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JHktvP3y; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JHktvP3y" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso61180005e9.0 for ; Fri, 15 May 2026 04:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778844979; x=1779449779; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yzXXcPatHUTECkq22Qox7RnVgD274dLeIoFpGjG0hKI=; b=JHktvP3ycT/JVEkRu4FEkZWenO+UzRHpny2YAC3Gea7beJncqBTm2zJsAvMyIMOb0t D77iF/vsrejAuHdtBgyuCx/Q+bH2cF09JnGomjTz1x1Rjp1xE5wmhMwyBa6w+vZldljI tRZs9rV7nqKLJQLj/O4BldRpkHmdJegXTjUQdlJwCpWko4tjJeCpE9LksFAn2pWtnKW5 gEZqlLNCZOGsWDo7mEh4T3/IhfCi2cP3MyBicb/MYDeGl6UTJEB2g/GpMmQ+HMz1mz+P 03Hdk0tAwEMU9MLM0LjiIbvaegP0LAlOdi3BiWe7UH9/Oz6EtKmTo6j9vrwi7mDxaQrC mw3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778844979; x=1779449779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yzXXcPatHUTECkq22Qox7RnVgD274dLeIoFpGjG0hKI=; b=bQ79l36X/Ri6gOLiWKnXakvZe/n2K41+jn/9g3k0AGmOmsBHVrOt6UXTPiVI+41Qu4 qzjqcgVs8uDsUWkrInbiDYI2HhD+Di45ZAZv9Uub1zaLHrVLf/ib5vbu6n72OQ1d56mj UBuQbFISJyhK7uzb5wQMofDZr3S/ahZxYUjBS12w3GBb6jTxKWwU4OEqSF7i4kWCPyIr QFEqShYFABiapNyXTN7rYkAfXiKVCD0OCRSNrCrRSXl3AzlLo1g4Gx9GTduhq3pwhtYi yv3EuBQOj0TS0p2lyA+AirzhN0Y2qXXuRHjJgXwPJSrocdr8dSlWkmgob8/o/gSXfWvB MZIw== X-Forwarded-Encrypted: i=1; AFNElJ+0i5XidiQaygrpVktbO6WCrfiYsYeGQOG8TzUTBedcQoinqZadprQGaey0/SrAsbmiBPhR6SDVFHx4BJo=@vger.kernel.org X-Gm-Message-State: AOJu0YyihjjYGfDyO9htjgzwickzx9uawGjKLACKVMVtpXFj2igmTqBk p7vGzBzSRdlrKQtW6KZezLNRm0OrAo3We5tSClI6vdQxEAx0tT4g9JO2 X-Gm-Gg: Acq92OFZsbHOLLsb41CbBXqBXjNeuxKJiScOg42re+NaTAgP44bONbpUPzJNnN2F30Z 51kJCePw07Hn+JlLtwDkarC/HicK0EnUuD2qQOw9VuGhdDnlN/yaQ2Ps/cnLnuquV9YeM97tZ9h iwz8g66cSJX98ucspJRzxnJVNbw/hUKEpCV/AXHZI6lZ1WQXYzl2vadkH5vln3PeGkvxdaeS0tB JkOlicXq1KR8ZMTFFf7Zu8FJ6AJI/dSl5IW/t0ncGm9yqulInaPksHFZ/JzWS3Q9wCzatteCoub 212NGQGOC9/HseNucCyoMOUQ/ilI9m4o2yLG/Fsl+gS7TMC7di4y5DKU1PCtUdX/csagr87of7A mnvUOWJH3/xYKI+YFp6NrQIZK7IdgHwtDYnLrEMMtHPMTNtebY+DIGubIoGSYH8TGktr7BPT9lo Xz6DDDKIxKI3EdM1Arm5s= X-Received: by 2002:a05:600d:8:b0:48a:5565:ec3d with SMTP id 5b1f17b1804b1-48fe61f7a92mr51272135e9.22.1778844979216; Fri, 15 May 2026 04:36:19 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe53804aesm52347505e9.15.2026.05.15.04.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 04:36:18 -0700 (PDT) Date: Fri, 15 May 2026 14:36:15 +0300 From: Dan Carpenter To: Geert Uytterhoeven Cc: Sudeep Holla , Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: Fix OOB in scmi_power_name_get() Message-ID: References: <75caae28bdffb55199a0bc6cac5df112a966c608.1778838987.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 15, 2026 at 01:29:27PM +0200, Geert Uytterhoeven wrote: > Hi Dan, > > On Fri, 15 May 2026 at 12:28, Dan Carpenter wrote: > > On Fri, May 15, 2026 at 11:59:15AM +0200, Geert Uytterhoeven wrote: > > > scmi_power_name_get() does not validate the domain number passed by the > > > external caller, which may lead to an out-of-bounds access. > > > > Is an external caller an out of tree caller? So far as I can see this > > I meant a caller outside drivers/firmware/arm_scmi/. > > > is only called by scmi_pm_domain_probe(). > > > > scmi_pd->name = power_ops->name_get(ph, i); > > > > where i < num_domains. > > You are right. But this seems to be only API implementation in > drivers/firmware/arm_scmi/ that does not validate the passed domain > number. I don't have a problem with the patch but I don't think it should have a Fixes tag. regards, dan carpenter