From: Naveen N Rao <naveen@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] KVM: SVM: Disable x2AVIC RDMSR interception for MSRs KVM actually supports
Date: Fri, 15 May 2026 19:49:30 +0530 [thread overview]
Message-ID: <agcrLnljmHrXm7T5@blrnaveerao1> (raw)
In-Reply-To: <20260514213115.1637082-3-seanjc@google.com>
On Thu, May 14, 2026 at 02:31:14PM -0700, Sean Christopherson wrote:
> When toggling x2AVIC on/off, use KVM's curated mask of x2APIC MSRs that
> can/should be passed through to the guest (or not) when 2AVIC is enabled.
> Using the effective list provided by the local APIC emulation fixes
> multiple (classes of) bugs, as the existing hand-coded list of MSRs is
> wrong on multiple fronts:
>
> - ARBPRI isn't supported by x2APIC, but its unaccelerated AVIC intercept
> is fault-like; disabling interception is nonsensical and suboptimal as
> the access generates a #VMEXIT that requires decoding the instruction.
Nit: unless you decided against incorporating the changes we discussed
in v2, please update this part while applying.
- Naveen
next prev parent reply other threads:[~2026-05-15 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 21:31 [PATCH v3 0/3] KVM: SVM: Fix x2AVIC MSR interception issues Sean Christopherson
2026-05-14 21:31 ` [PATCH v3 1/3] KVM: x86: Add dedicated API for getting mask of accelerated x2APIC MSRs Sean Christopherson
2026-05-15 14:18 ` Naveen N Rao
2026-05-14 21:31 ` [PATCH v3 2/3] KVM: SVM: Disable x2AVIC RDMSR interception for MSRs KVM actually supports Sean Christopherson
2026-05-15 14:19 ` Naveen N Rao [this message]
2026-05-14 21:31 ` [PATCH v3 3/3] KVM: SVM: Only disable x2AVIC WRMSR interception for MSRs that are accelerated Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agcrLnljmHrXm7T5@blrnaveerao1 \
--to=naveen@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox