From: Heming Zhao <heming.zhao@suse.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
jiangyiwen <jiangyiwen@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
ocfs2-devel@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ocfs2: kill osb->system_file_mutex lock
Date: Sat, 16 May 2026 07:56:21 +0800 [thread overview]
Message-ID: <ageyiQPdXbsnyikV@c73> (raw)
In-Reply-To: <b0e9c4c2-9ea1-4d41-b8b2-5f2f6c15b80a@I-love.SAKURA.ne.jp>
On Sat, May 16, 2026 at 12:51:32AM +0900, Tetsuo Handa wrote:
> On 2026/05/16 0:35, Heming Zhao wrote:
> > Hi,
> >
> > The logic here is incorrect. The purpose of the refcount is to track how many
> > consumers are using the inode.
>
> The igrab(inode) for the first time is for getting a refcount for the slot, isn't it?
> The igrab(inode) for the subsequent times is for getting a refcount which is supposed to be dropped by the caller, isn't it?
> _ocfs2_get_system_file_inode() always gets a refcount which is supposed to be dropped by the caller when it succeeds, doesn't it?
>
> So why do you want one more refcount?
>
Hi,
Could you please reply inline? your current reply style makes it very hard for
others to follow. I made a mistake in the previous email, and wrote the analysis
to continue my previous email.
- Heming
next prev parent reply other threads:[~2026-05-15 23:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 15:56 [PATCH] ocfs2: kill osb->system_file_mutex lock Tetsuo Handa
2025-06-24 1:33 ` Heming Zhao
2025-06-24 1:55 ` Tetsuo Handa
2025-06-24 2:51 ` Heming Zhao
2025-06-24 2:17 ` Tetsuo Handa
2025-06-24 2:40 ` Heming Zhao
2025-06-24 3:05 ` Tetsuo Handa
2026-05-14 7:09 ` Tetsuo Handa
2026-05-15 15:35 ` Heming Zhao
2026-05-15 15:51 ` Tetsuo Handa
2026-05-15 23:56 ` Heming Zhao [this message]
2026-05-15 23:53 ` Heming Zhao
2026-05-16 5:52 ` Tetsuo Handa
2026-05-16 12:27 ` Heming Zhao
2026-05-16 13:10 ` Tetsuo Handa
2026-05-18 2:52 ` Heming Zhao
2026-05-18 4:23 ` [PATCH v2] " Tetsuo Handa
2026-05-18 4:56 ` Heming Zhao
2026-05-18 6:20 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ageyiQPdXbsnyikV@c73 \
--to=heming.zhao@suse.com \
--cc=akpm@linux-foundation.org \
--cc=jiangyiwen@huawei.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox