From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2EEB3D0937 for ; Sat, 16 May 2026 10:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778926440; cv=none; b=g6ltoHQI7/+670P0WClUNV7FsvOWCVcJblrx8kycYGcUzddci8Fum2YYS4oE2nUubTt0+0JGktEyPaQeeiXX7linMsuAe0tHzokEXL/jEzuiSSMrc6VYco7nZvgHWolIMBKY5s86fU4TUXDclq2bWyhCr63h1AWR2pc4Qz6X4xM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778926440; c=relaxed/simple; bh=Zla/uoiEzSi/ipXbmrLVQdERvYv6TqUwnnGkb0CCgxo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cDZ6+rRxNlT6cx5ZrE306kTNirz3kFVttrTk1lid62E3N1KBvu3QM/YMpOCmwVq+OgwriAM5emJVmhJSeKmZr6T1PS4ldvHbsx/sPxjvr8FZ0aenzWENL2YxhDA29D3pQhAKgftuaUM1jHtLChBC54aCfTY2OE3L4ci96usnP+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ERQqZe12; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ERQqZe12" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4891c0620bcso3148405e9.1 for ; Sat, 16 May 2026 03:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778926437; x=1779531237; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0ZSCTViidu361ZnAX04ezJ7adwfGkPdJLJ1MHvkoKWY=; b=ERQqZe12H1yWTJ2aGbQcykf02id7HdxJPDgGxr0S7akGKEc7yZA1s8MNlv2yuYdTM1 AxmYROjgZF0urP1RxJEGSYqVIj9noMDZk7MGY9gVVUN25NRGtSTANVhgIFnOE8V2+YgT fJM2Y+UqX2J9Unk/n4a+UHw11sm0r4eb+M2E2qArvp7ehmK6oStfPX50gPrAqPznZfX8 r6Tad1YEOo1gCpsumxeOIMSTyMNO00hiX38VfZtEpiGSCdiVWpxPD8xg/qS9f9EcWBMr MosVx+sQ5HEIIN/exRhauJFGw/TR6SZSest8WD1E/WkukJfW7NP5JCeZHgHSE6F49YtK phmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778926437; x=1779531237; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ZSCTViidu361ZnAX04ezJ7adwfGkPdJLJ1MHvkoKWY=; b=OARw39PO4pc1HWFofPIlFBERXjy/7Nh3A1a83ZGpt+72f1W3Ydo4OdA+HOYcdrDsrE ZEHKmwjtIo6a3tk+QTlxn4ydyl5tt0zAqbk8jEK26zWJ7LOmwkxLVviwnx4Xjizhd8Cd t32sa/dZf3guftoEQXzPE21AwE1ivemjEKpZQPBCDgbc05sdnswxv2WjhdjQwZmCGGMa ijfLXISiqdH1DQLCAvAGYgwkIZMsU1kV26G4JkX6FbrRtMxhvoFaA6jeLmt2AdO3sEHw Z1qxUAlo05Rpqcwkufmq86AYAAIqdxSrVJBwy6bPzlKDkSHagWvEl2YG8air1ZW6jAay qorQ== X-Forwarded-Encrypted: i=1; AFNElJ+ukD/uqPFjK/rpo7ccrtcxRbAcB586EJN9xOMhDpzLQeqeuh/tpRmRdHKF2ZGYqdUCAfcQe4aqf6sV7gQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwdAISqKeNHd/ExL40jwuQq4I5flBmz0uBY678ObNhhwJ6XcZFZ S+FLWbmO7V3pnbcgrLzt0RKtLP6cUt3CkkE51avcEbHns9kvpXn5uJv6 X-Gm-Gg: Acq92OHBJQZdp8Us0aGtetir00NlFCja1LIENfE2//HehTzq4MO68j+0aj8WX7+6467 kD1sz82iaolIqCaF8KCSktyCBOy0ib093YuyGVPI07DqQCwDRdVTZx9bGe4AvLjt5xxIAxY0bXp ccg8zjNQhWhwkcH2qBQ5I7SZmPU0XChQP6IhucdqkSX790txPnCZZZzekbXx+y8Y9/w/52dKFMT v/DuxuyoPewaPBO7/fAfSo+sYNZ7dfx6lPTmPbUUOctVnG4sq+iQCKqarnSmjWZdKJAiZjeZDPV 17/tZaSztSRYabdIqXAk5i3TVuX2swatY4eYnWox4EbPErvMBPThBBrl66lpT6eiZnY4MmFk40M 3+yrDNvFnU6SzoXBAF/yFlhip2JA2WtYUXsMV8/iO0xAYLp+AsjAV853c4tBkP29VlDKZ5OtUZf cQhFFzlvgoxnMcJbxSkpM= X-Received: by 2002:a05:600c:1593:b0:48f:f199:79f7 with SMTP id 5b1f17b1804b1-48ff1997aaemr26285975e9.27.1778926436844; Sat, 16 May 2026 03:13:56 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48ff43f8799sm32321425e9.2.2026.05.16.03.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 03:13:56 -0700 (PDT) Date: Sat, 16 May 2026 13:13:52 +0300 From: Dan Carpenter To: Yousef Alhouseen Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: add missing newlines to sysfs_emit() output Message-ID: References: <20260515223342.40869-1-alhouseenyousef@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260515223342.40869-1-alhouseenyousef@gmail.com> On Sat, May 16, 2026 at 12:33:42AM +0200, Yousef Alhouseen wrote: > Sysfs show() callbacks should emit a trailing newline for text output. > Several Greybus audio manager module attributes currently omit the > newline, which triggers checkpatch warnings and makes the attributes less > convenient to read from userspace. > > Append missing newlines to the affected sysfs_emit() format strings. > > Signed-off-by: Yousef Alhouseen > --- Patches which affect the user space ABI need to be tested properly before they can be merged. It's just to risky to start changing things randomly. If it were fixing something then that would be different, but just making checkpatch happy is not motivation enough. regards, dan carpenter