From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 330133254A5 for ; Sun, 17 May 2026 18:52:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779043927; cv=none; b=kGUqpzdCuhUPaJDBvhjXhQRy5k0NdtHjJ0XSsITUSCLaZt7Y/XYZgWaMxCRY0Mn/JbN6os+gzTGbzZHQARIbjQYyZwmg6C1PNs/FEG8arRTyh7wgicphrqjtWUfNaJY/J4RNhWRRFQ4bZDWRcCIDBPLvNRrNmb69UiB4Kt8WTX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779043927; c=relaxed/simple; bh=dEI0dHO4/KkcUDU6wf5hMM3cRP/Uvov+/pcBQE3YBOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nCw52rcPKbFX+2qBx5lahxw6gJdD/lSEAhMFetHE3eiNP6ozr2CrXV7NsWs0CLBNllZeiCNrW4J2bJOrRLqwTpegn1zAJnTwZBZ/fO37cwAT0hGZO1FWZ8Ln6jqBwUwfnyTmlufRRQ+Y+YhFTmkp94/db/YTsWxqN/PgAp1JHJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=SX7ltOKb; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="SX7ltOKb" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-50e5bea4045so12391811cf.3 for ; Sun, 17 May 2026 11:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1779043925; x=1779648725; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rMikKmjIRuhmCNsf7ga38/uSHQiRF0nG0AquMF025/Q=; b=SX7ltOKbDqicCJW23t8jAciw5Vsm4yNsVJ6Z+qUjPO9M9yPi6UtaAy86NR/Brh5Kme lYvZWWbknpMYomOS4ckwZTRq9ZCA6yJ5ls8Mef47zHwhtxCduJWd3xJD2qdUlhPqAN+u OI/Olu95iUM2KLqqlsQfXALMaNyPVxR+sjoJTa0p1NvXJG6YLvHVqFcSLNK/Ye0FOJag QKcXKJEXmUmLHlNYrPFYdek1VURSo5PIIRoa3cIPenGZaVxLmD4WGpHdZzvqBVWRLIJ3 6JZNVyKXm7RvD1u3iA7zjFGniPOuzB8Vn8+LA6+m8FQPokL8h62a7zkvHCNtyIiUBe+s e5KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779043925; x=1779648725; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rMikKmjIRuhmCNsf7ga38/uSHQiRF0nG0AquMF025/Q=; b=fbt+kWZDzoFU90n8mHM3Jno/jUciG1ONJDZ77jsD1XAs9pnwLfarIshDLG1kfLoElx 69vTiWCx1r/O9IOdgLdGh2CtzN4Xc5XpoJbogjX0JooU7Cxv08eke7l09VsQ/C4p7Ihj i9fBHf2n7oNxQf5LqvewVVDoKYwnaVJ9+8AK6tl4nqDSYZtgUCHe97LAundzXTJufo+k 4qU7SrhieS85mg6YEAtok8hM4Nl/zVR6DYvjNZ82wFGweNL00lj3uhsLbSE6uFIkpVpU ROBUwh4DLvC5Ud46MtvXl7QHA+oQzojIe2ti1r3/NJEVAmeVU4lXRK0LdqrPYWmOuiqh W39g== X-Forwarded-Encrypted: i=1; AFNElJ8euFKtqNBFMNDNjWzmpzCK8rQgw8mCpV8tdnFfBp6WMQvUEbqzFtS3vDrKA8YWWqmKVQ3FxAiX+u4BXOk=@vger.kernel.org X-Gm-Message-State: AOJu0YxaYTlgCU4ze1b6Kn9++AQHHR/qdXTEeRH6KVLJSRa9rRIzasjQ L/BheQXDvwCslUmtFr1MpqDgDEyCj0+udK+LpgASg+QgXZKT2fCRI5j457mgVlr9lCs= X-Gm-Gg: Acq92OFXL05bt7FJEBujv561QQSBeKJhPpyqILWBa0c0EAe0PCqVuVua+5hRJH0nrYI mUuq0psswti+PJzidsBdjm4jqIGyiPetcnTG7NSIO34MHnCFax0mVP2QZXRymsfCZIwS+Tq8I4M 4O8BKIAOmrWVc8Cv5PcM+uIyPzDHD3QixMw4rGk9iuIgFnKHcOxfMJzVUooVVDdkszG7T07ScHC UlIP3VadAesIAFLB8+M7RL9iUxjywaBMj24A9+9dNGF5VRrwyLNqoVNfU8SC2hJ3s4RdYxJeFzP aaemNTRbcx44srfk996kkquo2V/7Xhct/F71+jmkwD50zszRSxlD/VvgrGROkxvSeJJ+qnLTRvR M9e4u6yx5NOeqqVKqamWIOSm2/esfDDf1Ywjgw2UjedonDMq4ocMDg84tg3z7XZzdohLQJpx2iW cf8JBOYYio6PCA3RioyjSTXaZxnfeNc35tReIxjEWeQ7DdR3z6YkI= X-Received: by 2002:a05:622a:6201:b0:50e:5819:d7e7 with SMTP id d75a77b69052e-51659ff8947mr173729421cf.3.1779043925075; Sun, 17 May 2026 11:52:05 -0700 (PDT) Received: from plex ([71.181.43.54]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-516456888f6sm114656631cf.3.2026.05.17.11.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 11:52:03 -0700 (PDT) Date: Sun, 17 May 2026 18:52:02 +0000 From: Pasha Tatashin To: Mike Rapoport Cc: Pasha Tatashin , linux-kselftest@vger.kernel.org, shuah@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, skhan@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, dmatlack@google.com, kexec@lists.infradead.org, pratyush@kernel.org, skhawaja@google.com, graf@amazon.com Subject: Re: [PATCH v2 05/10] liveupdate: defer session block allocation and PA setting Message-ID: References: <20260514222628.931312-1-pasha.tatashin@soleen.com> <20260514222628.931312-6-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 05-17 20:31, Mike Rapoport wrote: > On Thu, May 14, 2026 at 10:26:23PM +0000, Pasha Tatashin wrote: > > Currently, luo_session_setup_outgoing() allocates the session block and > > sets its physical address in the header immediately. With upcoming > > dynamic block-based session management, this makes the first block > > different from the rest. Move the allocation to where it is first needed. > > > > Signed-off-by: Pasha Tatashin > > Acked-by: Mike Rapoport (Microsoft) > > > --- > > @@ -77,15 +77,16 @@ > > > > /** > > * struct luo_session_header - Header struct for managing LUO sessions. > > - * @count: The number of sessions currently tracked in the @list. > > - * @list: The head of the linked list of `struct luo_session` instances. > > - * @rwsem: A read-write semaphore providing synchronized access to the > > - * session list and other fields in this structure. > > - * @header_ser: The header data of serialization array. > > - * @ser: The serialized session data (an array of > > - * `struct luo_session_ser`). > > - * @active: Set to true when first initialized. If previous kernel did not > > - * send session data, active stays false for incoming. > > + * @count: The number of sessions currently tracked in the @list. > > + * @list: The head of the linked list of `struct luo_session` instances. > > + * @rwsem: A read-write semaphore providing synchronized access to the > > + * session list and other fields in this structure. > > + * @header_ser: The header data of serialization array. > > + * @ser: The serialized session data (an array of > > + * `struct luo_session_ser`). > > + * @sessions_pa: Points to the location of sessions_pa within struct luo_ser. > > + * @active: Set to true when first initialized. If previous kernel did not > > + * send session data, active stays false for incoming. > > Hmm, why addition of a single field changed the entire block? :/ Yes, I had to decide whether to shorten the field name or change the entire block. I opted for the latter. :-) > > > */ > > struct luo_session_header { > > long count; > > -- > Sincerely yours, > Mike.