From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C716C3D1CAA for ; Sun, 17 May 2026 18:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779044278; cv=none; b=tEdhQu2WCDqm59n38ILeG6TV/c3bVwQCFP8IEuVwtBmSGXlJntFn0G5C1F4q7YeZo0cotR68IVYVKrVM3wrk9sWvw7U15v5Bvriryih4RJv+8tjhp5W0SAtVMzFI1j4AKghdYl1svVIQ0/z4rQJIZdyLznKTyAuMhYjZVn/9FEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779044278; c=relaxed/simple; bh=lgp1Y0cbFZdL+vpyXlbpNuIdHM3vcSmyQNICRmFJU1Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b06/zNjK5/ggZ5RGeQPXhInbfMbLXYOZRsNVMrh9aHFN5LcxyUex8CKtg5bq0qEaOPB21f/t8JOiCuotNPc44WR5uBlhzAbTeNXhYDywWf7VKj6EyQgbHEC5wOfMJdb3B0IWDQWMbOCsbS+Pn1Q4pEVYnbIZZLAklf8CJrBqDQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j12Nyp5J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j12Nyp5J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F758C2BCB0; Sun, 17 May 2026 18:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779044278; bh=lgp1Y0cbFZdL+vpyXlbpNuIdHM3vcSmyQNICRmFJU1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j12Nyp5J5wC6T9JLE39GMfLmW4mELfC1pSEmPH/aJV0RAFEGIIGLiDIiiUTuW6pyU dGLt9gMFIH8v5i5KeL7WsmgjcClNdVlp6e1kurv57KswdNv24MRqFKcoVbLBNmwwJ3 Or+CqdG2/GxZdeUGuSBkBlIaqxntMEf+WuPAY3AEFK7NjUlmIgjhcv4GQUeWEDIPcr uxY1XiesgRFCXsJ1wN7b3TeGgU/pt95P2xUxHkJtq7Lki8VWMp+X3qe1NcvGA7Ouy7 9QzW0Sk9lKG2x+vs19TEAdKq1sAJ/uzutqbwSrbBDSnA6Db1a+HgHyETqzLxjR0QEE 3K7phS0J2JO/g== Date: Sun, 17 May 2026 21:57:50 +0300 From: Mike Rapoport To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Ryan Roberts , Mark Rutland , Lorenzo Stoakes , Andrew Morton , David Hildenbrand , Linu Cherian , Usama Arif , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC V2 01/14] mm: Abstract printing of pxd_val() Message-ID: References: <20260513044547.4128549-1-anshuman.khandual@arm.com> <20260513044547.4128549-2-anshuman.khandual@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513044547.4128549-2-anshuman.khandual@arm.com> On Wed, May 13, 2026 at 10:15:34AM +0530, Anshuman Khandual wrote: > Ahead of adding support for D128 pgtables, refactor places that print > PTE values to use the new __PRIpte format specifier and __PRIpte_args() > macro to prepare the argument(s). When using D128 pgtables in future, > we can simply redefine __PRIpte and __PTIpte_args(). > > Besides there is also an assumption about pxd_val() being always capped > at 'unsigned long long' size but that will not work for D128 pgtables. > Just increase its size to u128 if the compiler supports via a separate > data type pxdval_t which also defaults to existing 'unsigned long long'. > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Lorenzo Stoakes > Cc: Mike Rapoport > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Acked-by: Mike Rapoport (Microsoft) > --- > Changes in RFC V2: > > - Moved pxdval_t definition inside generic page table header per Mike > - Restored print format in __print_bad_page_map_pgtable() per Usama > - Renamed __PRIpte as __PRIpxx per David > > include/linux/pgtable.h | 11 +++++++++++ > mm/memory.c | 23 +++++++++++++---------- > 2 files changed, 24 insertions(+), 10 deletions(-) -- Sincerely yours, Mike.