From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09ACF3E0247 for ; Mon, 18 May 2026 08:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779092709; cv=none; b=ggx3LEooUFurJLxE6QHpsbmwk6Unk8bs4pnOzfWmxmFDiNpqn1hW5mQJpBxz6oOjxnR5PxQ5qCSyODlswu6fr8UzhsfuPeH53K09iD3nQgN04NiBYmE9o+cDsia85/WfDciW8MESz/F20dqaDD/Os7+k2HsiBK8X8JI73zEq+sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779092709; c=relaxed/simple; bh=LXbSJpJCEmuktzcg2H+6aNf9mXGhoqyZcVQmxcxBurI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JvYFyzjlJuIMiBRlR/SG6mDLQFn92KtlwUAiJLcxeioAMWi++fgQ0MF1SuLgguz+66Of6PGRP/UH2Q8W2Ced9ub9teBaOwFsPwtzKUPVGudUf39LyuxNo4aV8lygW8GjpqlQW1aKkrICasvvMNvZnUF9/XWP7tA3K3FJ106b8dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G0+WbgK5; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G0+WbgK5" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-44e1860558fso1044492f8f.0 for ; Mon, 18 May 2026 01:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779092706; x=1779697506; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=aYB1doPxRJ9mJUSEolqRQnRVr/I7xfiEOqE+cx3K3cE=; b=G0+WbgK5zbPPkWY/IK92ARaqvleSV1ba3zB/WWm4hrWSxNty/UAjqzyMXVSMIv1obo iFtGd3k109n6DfBVwejYWzf4UYWpJ1Gf9pue2H+1rmmXQZ6bv/jyifnz7uiYc+4UVQpz Q6QgH0QhZFazeLD9KrcwwpdbOD0Czc5p7zV1ow1Q5ajZpyKGzecYLEJCxkVAAy2ZZMCX xiYu/bvVeEZ5IQ1zuu3YYUUbxxvSS02wkM7baAGfcfWZOV6aDh/qVXMXMcT1BeNsUtRS 0ONdLskNZjrNkwDO+OKit7PfKKcYRymmjCxpdMwUFy2IfpRZCxEiXn6WJ+XkU/H0qBEL WATA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779092706; x=1779697506; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aYB1doPxRJ9mJUSEolqRQnRVr/I7xfiEOqE+cx3K3cE=; b=L7EZJf8jiGLCswEZlCCBAuVjCb3opYKfgXGjVWioM3jHEK1v/gEIz8t+MAmgsV60Hb nWAQpG7j1VKou80pOjcVta8fREY3zZZC5K35rnxYuBAxf8ry6bZqxZln+mXe9LkVdl0I /RhhBrZ7dPRjd2HRgT3QJadRqRNdOWx74gS6ZhEHci3N2EoiA+6/730qwJ/mFfAMQoOX xRBJZX4BtynjbXPkBxeBhcM2vrwmWyO6oVg+gCZU5sULruP3yW1D8vGkHzSh4FGemQg9 9DAkxf7HpyVjCsv27B/1dZ4pbDBjE0RichAbnkUhLPdlyu7z6QfevcM6gANUvKDSSlHv dr2g== X-Forwarded-Encrypted: i=1; AFNElJ+FsEJLnQB+iUR82sO9DM/SGLLyPTleU4/n5HN7zJYuEQIFmsAA02hl65UptFXx0ZXvJ6zGZdIM0K/fcJw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2LxzR8ZjSt4hpl4vNjqYVfPTyKQO6thWc0bj5KLwZp4h2Dgqy 0AjYjBPn6Aw6se7o2WGzfcyzHzVvwhWat+/Oo8Pukd5S8eFWDexcHyTN/rVNzA== X-Gm-Gg: Acq92OFT6LjeY4Mr762czm21+Ljq060mWrPzYFQXXCvENq4EER8iZ6NOjn9iXLIrsXL 1j2I/k57/xYBSMTud0BFamq24m1rD0dltxgSxlwyywK1A33XP7bFr9+P0A844zbxFb+EU9UvwGu 8rIImC6FDrSmcYvjoi2SPnCMTTMG3aGlr7EGrchOQlhl3sB/tHmxGg8emakq7eM+G3L2ve/liqG BM+AfX6jl3XAA3YSpK7i0aJSPgENGYnvPCYxr7ecDfsOx7lrQeEuPkb5tpb7IFLxP2+V1fIAv8y jphFu4SWinPmdVByPleOfBuwCdsfk9EN7PrEOsoARLIUFFfm7vmAptO1dewi+4ge6ipRyLM9J3V Zg7zeFK8k1OXBJoRTi3ELehoHOrX43urZTbAPBDtNqXOEcCa88+XNDgesuTjH8Rnab+hE+51k0v 0fS9oWYqOpiNdrYg== X-Received: by 2002:a05:600c:4e4e:b0:483:8062:b2f with SMTP id 5b1f17b1804b1-48fe5fd4747mr230559865e9.6.1779092706022; Mon, 18 May 2026 01:25:06 -0700 (PDT) Received: from nsa ([185.128.9.188]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fffb9aac4sm222192145e9.9.2026.05.18.01.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 01:25:04 -0700 (PDT) Date: Mon, 18 May 2026 09:26:00 +0100 From: Nuno =?utf-8?B?U8Oh?= To: Felix Gu Cc: Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: buffer: hw-consumer: free scan_mask on buffer release Message-ID: References: <20260427-iio_buf-v1-1-2bbdac844647@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260427-iio_buf-v1-1-2bbdac844647@gmail.com> On Mon, Apr 27, 2026 at 07:11:39PM +0800, Felix Gu wrote: > The scan_mask lifetime changed in commit 9a2e1233d38c ("iio: buffer: > hw-consumer: remove redundant scan_mask flexible array"). > > Before that change, the scan mask storage was embedded in struct > hw_consumer_buffer, so iio_hw_buf_release() could free the whole > allocation with a single kfree(hw_buf). > > That commit moved the scan mask to a separate bitmap_zalloc() allocation > stored in buffer.scan_mask, but left iio_hw_buf_release() unchanged. > > Free the scan mask in iio_hw_buf_release() before freeing the buffer > wrapper. > > Fixes: 9a2e1233d38c ("iio: buffer: hw-consumer: remove redundant scan_mask flexible array") > Signed-off-by: Felix Gu > --- For some reason this one did not get into my mailbox. Anyways, looks good and in line with buffer-cb. Thanks for fixing this: Reviewed-by: Nuno Sá > drivers/iio/buffer/industrialio-hw-consumer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/buffer/industrialio-hw-consumer.c b/drivers/iio/buffer/industrialio-hw-consumer.c > index 24d7df603760..d1ab2cbf8c88 100644 > --- a/drivers/iio/buffer/industrialio-hw-consumer.c > +++ b/drivers/iio/buffer/industrialio-hw-consumer.c > @@ -40,6 +40,8 @@ static void iio_hw_buf_release(struct iio_buffer *buffer) > { > struct hw_consumer_buffer *hw_buf = > iio_buffer_to_hw_consumer_buffer(buffer); > + > + bitmap_free(buffer->scan_mask); > kfree(hw_buf); > } > > > --- > base-commit: 7080e32d3f09d8688c4a87d81bdcc71f7f606b16 > change-id: 20260427-iio_buf-0459b3fa3de8 > > Best regards, > -- > Felix Gu >