From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6190A3E121A for ; Mon, 18 May 2026 10:23:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779099808; cv=none; b=AeMhjkmoj1aLKRt7M1tSDMvLfl5lMujzBdK18wg7eEP1X3CMde+qrMkqGVnxgTbLWWUjIke4Es7bTkYDasQYv08y5PLTi3b2KRGcT6eo6/i18Yqw8JkHcZQ2GlmC6W3iDrdBjX9OyZOzrJvMV3wCSfZQWgA8avO9oZEFsyV/c6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779099808; c=relaxed/simple; bh=EsVdV2tJCwVihdpXcnb07BjZ4rZbs+BF2ObSo0uhDEY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tgTlF3V1Ns8EviUimCxIuUghJDFV6ZJ7JIZHrmPV2nXh/ih2AWNR8VJ5Si+MvZM522A1sAd6xN3p/v6De39eazB1pqaXTuro7PQ4vgz+/6A+CjHfuyWEvXVCcKcYOkasWllhKkPrkofCX7Kq0Y7zJhoBVbNifu1zMHNhJLlLfjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QzrPwq+b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QzrPwq+b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FE45C2BCB7; Mon, 18 May 2026 10:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779099808; bh=EsVdV2tJCwVihdpXcnb07BjZ4rZbs+BF2ObSo0uhDEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QzrPwq+bQXxoFDgypZZeAFR6sw6ElgJ362xv4NLqAGdtw+SjvH+EK2h3mR2kUO/oY xisUGPBlFV2/f8lwjySsMyf1IknxqNVxQvsMsxDbPxpX/3xYSDmZtkFoO73jMY6zYP ZTJEiBAWPg9ALNU+xIBXMr9MwAenK7PdqIntFjdcP0ZOPh/JxL1tLETAjQXwD2Q0Mh 7CvLYs99a+dYkqSpWLrdeylP6Ygdx7Cgqw9MIiuAwxsIJ/KfLGgCWfBwSmF/AFcduR P4KaC2+nntURHBprav/RGfHcDlW5crItdRm7VqKESy2cwHpoe5DAE3bGPvi09rW1Nw 8QswG2F4JWAMg== Date: Mon, 18 May 2026 11:23:21 +0100 From: Lorenzo Stoakes To: Andy Shevchenko Cc: Yury Norov , Thorsten Blum , Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Yury Norov , Rasmus Villemoes , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm: add bytes_to_page_end() helper Message-ID: References: <20260517123428.1181981-4-thorsten.blum@linux.dev> <20260517123428.1181981-5-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 18, 2026 at 09:48:32AM +0300, Andy Shevchenko wrote: > On Sun, May 17, 2026 at 11:28:05AM -0400, Yury Norov wrote: > > On Sun, May 17, 2026 at 02:34:30PM +0200, Thorsten Blum wrote: > > ... > > > I've got a series for this > > > > https://lore.kernel.org/all/20260303182845.250bb2de@kernel.org/ > > > > The feedback is surprisingly negative. Please add people from that > > thread. Maybe you'll be more successful convincing them. There's a cost to adding yet more super-specific headers where stuff gets hidden and people don't know where to put what, things quickly become a mess and header dependencies are already a nightmare. Also in the case of this helper, I don't see the value in adding a vague, untyped, confusingly-named macro when PAGE_SIZE - offset_in_page() is perfectly cromulent and clear in what it's doing? > > We always can simply fork, but I truly do not understand the pushback. Well, be my guest? This isn't a hugely helpful or friendly comment. > These are simple macros that are way spread in the kernel, "include everything" > kinda linux/mm.h is not needed in vast majority of the users, hence the > split is logical step. Right but that's completely orthogonal to adding this macro? I'm fine with moving offset_in_page() to e.g. mm_types.h. But a series that doesn't even give any actual motivation for the change is not convicing, and we aren't required to just accept any change. > > I'm in favour of this series. OK, I'm not :) > > -- > With Best Regards, > Andy Shevchenko > > Thanks, Lorenzo