From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41AFA45BD7C for ; Mon, 18 May 2026 15:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779119545; cv=none; b=CvG8GM1mrBzWxqEzOX3I6V+GN5G1UetXMQDJaQIc4mkuJdGQhmI48D2xQzU8LHNc9kkEN0VyBAG/e0JBwV1WnxBBYeHTzp1+0TcoRhyrVc6B8k2Rf84Hzcceg5Hn/+Ikuoc/uic//1Sy/f3HNn8qG56eHTMBKt6ajC0h7AweKJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779119545; c=relaxed/simple; bh=YiTwS79bnTt/Nua6+DyRlP8IChJpOF59JAGpvQImZcg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z8WPf6IiATR/7PKg9/ojlLXNC1uvD08hJ2JsgmCNU8qvJsz/TDYpVvlU3SxsRkfrn3aIgoC2Kvn8sirXY7ypgfeGdhoLlSPHh0r0nrfI6O36kpb3S4phkX9dFzhRnm1WCmXH9xL02QN7RbxtiMeFCqbDH8tZQQw9iZVKYeo+Oek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=d8E32VHN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=siKHBwo6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d8E32VHN"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="siKHBwo6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779119535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gAI1hXFSj+uGK+1EPEBwy37aNgSLWoyZVZs64occPdo=; b=d8E32VHNVSD32phFXTKQFGIjkhdfIElF0FUMIEnXyqQBqh1R05T1mayj15ovYTGzhZXODN Pavi6cKUEAuDuj5lczKlRTnhSNnhSHJoiC2RTPaNzAKLNZMku6P7n0nJTCcQ7afr2w9eAI H+Tcekp3LkSMD4AEVJpEvhG0D2UNHug= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-nO9uC67KO_6hyxKHkUOzaQ-1; Mon, 18 May 2026 11:52:14 -0400 X-MC-Unique: nO9uC67KO_6hyxKHkUOzaQ-1 X-Mimecast-MFC-AGG-ID: nO9uC67KO_6hyxKHkUOzaQ_1779119534 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-914385ef371so311776285a.0 for ; Mon, 18 May 2026 08:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779119534; x=1779724334; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gAI1hXFSj+uGK+1EPEBwy37aNgSLWoyZVZs64occPdo=; b=siKHBwo6CCho2sAU9Gn30y1xdziMpVuursi9WcHQF/dQ9XFwibeVTXnCDi1Db4DbcV 3qcgNLRkw8ginzVj07k0Upfnsm1DT9KWbn8T4+u4yrW2n8XifY+tiHOiHIXkovzWAiwz uiw8mCvoNV6G1THL112gcR0mjSzcuOd3LQpiXh+o+cBzUCouvmCX2y7hv0fwWIl1reYk toIbMkw6Wbcxc4x+LtWWlWYx1Ly3kObKWGRA4bJUTsCqdqlfTEQOaD1hAOd3D8EWpM8y g03dKQFrPuru6mIiHjCXcibUNwhaVZ2rMDGmbi4eqz3OjdhcOUErx19CjcD1LrihcctZ z9Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779119534; x=1779724334; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gAI1hXFSj+uGK+1EPEBwy37aNgSLWoyZVZs64occPdo=; b=hzDOEADqYltqBjODBBHPm8zFr3EXnS76oO9ibrRHdxubdfrARuqXZgKMNWJQsPPsS5 P+qeCuFpSDVegV+qTT6hlho9yszNI6nLbKlTu1+wKnVYh+br45NZMsYRUr319rM8zRg5 3gz7pWCh9L3AfU8CTa04WJLkZ4XTIB4Ni1HkQRIyXoVznm1hsDjQExRGSS27N5Qx4vzq DxN7hPiLNUID2jqY06oeXt9jUtiV6dzcamAzDIyJKrRe2ZwkH2scogINSc98sku16tW2 7R/E2LDarb52cKuyNqUkvuC3XOKmVDQItyZglpXr01tXgh0MgKA9UYGU7INIPN+GEGYp DIrA== X-Forwarded-Encrypted: i=1; AFNElJ9XI5GYLj430k5hEQeNqH/ndOpBJelVxzbM1t42VBCfZjMJ6ne7rbFseU3ojqjxLhNTccSAtqv8EhC0xFU=@vger.kernel.org X-Gm-Message-State: AOJu0YzaD3ZieR0eV+rMiTAvcu0k2RKN7yzo0scfLiSEtwgWzT8Vsx/I wApoz9yZL0yAw3WefaS2jJWMCS5w1k01B3EHObwiLO/jtYw2x3ssud1RSbYIS1dkiqbKmDlLuSx xG8B7D7E2ImPqSrkdCsZuI3BVnwRIb8QhWhcby6qNREvpDGTBPxwnpmmfvnuPjycb3w== X-Gm-Gg: Acq92OHZF3u44BScezQwgv5rwtlRVZbBNOdl9H/6pf7JXr8dTGjwNqOZuaq6XWRa2F8 PgG6hlY+Wq392+HSmmjWAX9ldqubTPHbgw2fGVyqDBwf3DS4bzt0L3QV27Im+y7fQVTjo/pGq1N qMvCZSW0twznKh/5kTHkj/rBfYpsDfXoLDWJpB9+KPDbd0TgTDgztgowZP7vSYyVUKUI1tQGd6/ 4vNy1jKFp0iOCMvIyb41cJFnQkIzb1oEMNSAJUlJoeulUWg1rzHwOw9qoDVri+ho3Kq6ouKU7QS N2Xni9VN2atp5S4gpi8l64tys+ywfmtLE+z6wgf2V9yRfIDbzc4gpyD44eHwRUgVaSk8gn13q0Z gsCLXV5yacqfeSWDLzHlFLIsH6JNDTGKC5yPnuWnyTq0tqG4masxZGtKS X-Received: by 2002:a05:620a:711a:b0:8cf:dd93:aca5 with SMTP id af79cd13be357-910b0f0ef01mr2496015185a.34.1779119533596; Mon, 18 May 2026 08:52:13 -0700 (PDT) X-Received: by 2002:a05:620a:711a:b0:8cf:dd93:aca5 with SMTP id af79cd13be357-910b0f0ef01mr2496010985a.34.1779119533156; Mon, 18 May 2026 08:52:13 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910bae27359sm1601082185a.17.2026.05.18.08.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 08:52:12 -0700 (PDT) Date: Mon, 18 May 2026 11:52:11 -0400 From: Brian Masney To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig_=28The_Capable_Hub=29?= Cc: Michael Turquette , Stephen Boyd , Max Filippov , Luca Ceresoli , Alex Helms , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] clk: Use named initializers for arrays of i2c_device_data Message-ID: References: <3a193d91e64703892900b62709bd1a67f540f39b.1778857289.git.u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3a193d91e64703892900b62709bd1a67f540f39b.1778857289.git.u.kleine-koenig@baylibre.com> User-Agent: Mutt/2.3.1 (2026-03-20) On Fri, May 15, 2026 at 05:10:40PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. > > The mentioned robustness is relevant for a planned change to struct > i2c_device_id that replaces .driver_data by an anonymous union. > > While touching all these arrays, unify usage of whitespace and commas. > > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. The former was confirmed with x86 and arm64 > builds. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) Reviewed-by: Brian Masney