From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F346948096D for ; Mon, 18 May 2026 13:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110043; cv=none; b=EenbpD9W2pfaM6zWu1HKSANjqOxHwnKom+l87M3vjwAb4Zq5NCQrrVMIpTouitiK303pQg203MyGO2YSYt9+7XlWuyDrvr5imIyLd3fzqqFl/hPoC4P/Rn6ZrU9dceZgSxL7F1g/jhztjKuxKuEnl+q2cjH+Oi3Gbh7vQAXp9qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110043; c=relaxed/simple; bh=btSIhGMvdP0aU851la5oG7im9lsPLy+PBN4yq1F8bgU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p5n6EMc5Azr5rlZuiHwNZMfChArBMMrelr8NYlIttX4mc+WZPLAvqU78wN2W7orTx6+L/rrC5B/wUqlDJpspf1aks09pDLJBaDfxHpEiokaEkwyJa0CJK/gy9s7HbqIT0ZkECNeXCT/xJKr6PTXr1LGNqAEZkECxK9xmXbl4mrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=m5EnHsBH; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="m5EnHsBH" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ba3b9bcf69so335ad.0 for ; Mon, 18 May 2026 06:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779110040; x=1779714840; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U8z6jY/uEBmrxhBdQT2bu54FMFgYLzRCWsXgjpGmf3I=; b=m5EnHsBH5pFqczGhHCsv26D4t9xC1PJwg6Kcs7h8rn3UFTt8H4GU93Tx3/MYGW1/JG aVPlq2n/Rg4TtUsxLfgtIaTJLjbCfFJO81HdtIiwM0jTZDvMjyjSfyyZVZ2qY+neEQ3k IiH+9Iyx/hnHReus3Ku2DeNpBKuGrdkNtgL9yYQcNhihW8tOOFm65Ki52XKbiRmka4dq 8WOT5J85+8q1NbrV2Y4UafCUeAlUtK6Q+Q/PRkH4GKqyuRpqpHEnVj0WUw+LX/s0uglT i2qq9DiRzITCYjJ4u35trlWLDYetOZ6xis6esT/ezCRCQz9m+NFOovUdKcwTlgVgN1iA qwAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779110040; x=1779714840; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U8z6jY/uEBmrxhBdQT2bu54FMFgYLzRCWsXgjpGmf3I=; b=i58P4Gn55u0kyc5zMAcH/xIVaE3GSSm0Sz74Baglk4MNUqh+bmGHyXIZoT0kpN0pSs zcV5v6dlDwfHS3IFtbQnxBj5mi+K0KlhJZB6OXYpOY1JtAg14dT3u8Jl4L6Oj1D20IuT Tkx4d18jhXeUWCy+z4Hv1VI3zlSlVUk5zmBW8AVbYFKwex6NrXNH7v6uBLsU/R7BhjGx DlqPuqvFf3033Ze5RYFpVNLoWiFqzSlcMvosEPc1zKWE80FiTpvpU18tIfGafiApZb0e 86bm37Kicl3QxO3CahGip4oFO+hBrJKKeT8fjOeTKWXEyAN3tdV+iag3PqFBPhtVlnMe PQ8A== X-Forwarded-Encrypted: i=1; AFNElJ9zi51UxXeM3iPH7q8fmoXlUvihUJUrSouzuPngr3eXA8Z4y1QtP7RcAttwyaeKZgIm7WmZH0xz75HnQQM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz66q8gkBR5QyMpf1qTpAN1Hjd3byIDngPdX7RJ7UxqirJjOv9C uOSOA2VS1GiBBAAMOpwCWkWc/3PCb9zMmWu1OLC21rFCn+T2xQYydrFIj8LK1bkcOQ== X-Gm-Gg: Acq92OFsTUepOAtZJ/K6/cQCWYAOkDcaAVvYJdhkahKC2XffgRE41Zn97BMuXhkvGy5 XmEDnf/AFAVBFXYRDtC6RSOvFDBpfzS+hv7g89ZTecwWOAvWvq6Pa9Q+4zOlXWZVBoq2wBXGAnj jg7PpHxsIl2/HtI9ADnMVIsu2jKGVxsB12C2lkcFailLDDp7RvoTqY0bGzOjIIAU159Q9hPYmem mBkG+GhOIPjddPWsAfNA2UX1X0BoSFhGzT0DshVDOoLcA/3K+5meZhJaEUo9hSD3Jt+BUL5uwe9 ttzjJhJJHrK4R6EkUvzUKollcEGG0XmDH5WjPhsiwqeQboudUJyKfoOr20XO07ukk4osMcmkqQH dznVH9EHsifp7vyO/OBnos16T5rYUAvwprNA57i5M6bFE4urjPaa7LGe0WNLjBr8pXFQZWTp0Zw njpQTIlk/OpRQoKdaImrItrFN1RlT3jNDLHdGR7lU39zta2ekHy+1/R4478fSdLw2CsAg+ X-Received: by 2002:a17:903:2f03:b0:2bd:6727:d689 with SMTP id d9443c01a7336-2bdb03a2b85mr3036825ad.12.1779110038827; Mon, 18 May 2026 06:13:58 -0700 (PDT) Received: from google.com (44.234.124.34.bc.googleusercontent.com. [34.124.234.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f1977c494sm14213643b3a.21.2026.05.18.06.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 06:13:58 -0700 (PDT) Date: Mon, 18 May 2026 13:13:49 +0000 From: Pranjal Shrivastava To: Samiullah Khawaja Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Jason Gunthorpe , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Chris Li , Vipin Sharma , YiFei Zhu Subject: Re: [PATCH v2 03/16] iommu: Implement IOMMU domain preservation Message-ID: References: <20260427175633.1978233-1-skhawaja@google.com> <20260427175633.1978233-4-skhawaja@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427175633.1978233-4-skhawaja@google.com> On Mon, Apr 27, 2026 at 05:56:20PM +0000, Samiullah Khawaja wrote: > Add IOMMU domain ops that can be implemented by the IOMMU drivers if > they support IOMMU domain preservation across liveupdate. The new IOMMU > domain preserve, unpreserve and restore APIs call these ops to perform > respective live update operations. > > Signed-off-by: Samiullah Khawaja > --- > drivers/iommu/liveupdate.c | 97 ++++++++++++++++++++++++++++++++ > include/linux/iommu-liveupdate.h | 14 +++++ > include/linux/iommu.h | 13 +++++ > 3 files changed, 124 insertions(+) > > diff --git a/drivers/iommu/liveupdate.c b/drivers/iommu/liveupdate.c > index a26099b145c3..f71f14518248 100644 > --- a/drivers/iommu/liveupdate.c > +++ b/drivers/iommu/liveupdate.c > @@ -13,6 +13,9 @@ > #include > #include > > +#define iommu_max_objs_per_page(_array) \ > + ((PAGE_SIZE - sizeof(struct iommu_array_hdr_ser)) / sizeof((_array)->objects[0])) > + > static void *iommu_liveupdate_restore_array(u64 array_phys) > { > struct iommu_array_hdr_ser *array_hdr; > @@ -196,3 +199,97 @@ void iommu_liveupdate_unregister_flb(struct liveupdate_file_handler *handler) > liveupdate_unregister_flb(handler, &iommu_flb); > } > EXPORT_SYMBOL(iommu_liveupdate_unregister_flb); > + > +static int alloc_object_ser(struct iommu_array_hdr_ser **curr_array_ptr, u64 max_objs) > +{ > + struct iommu_array_hdr_ser *curr_array = *curr_array_ptr; > + struct iommu_array_hdr_ser *next_array; > + > + if (curr_array->nr_objects >= max_objs) { > + next_array = kho_alloc_preserve(PAGE_SIZE); > + if (IS_ERR(next_array)) > + return PTR_ERR(next_array); > + > + curr_array->next_array_phys = virt_to_phys(next_array); > + *curr_array_ptr = next_array; > + curr_array = next_array; > + } > + > + return curr_array->nr_objects++; > +} > + > +static struct iommu_domain_ser *alloc_iommu_domain_ser(struct iommu_flb_obj *flb) > +{ > + int idx; > + > + idx = alloc_object_ser((struct iommu_array_hdr_ser **)&flb->curr_domain_array, Nit: Such type-casts could be brittle and risk strict-aliasing warnings based on the compiler. Since alloc_object_ser only updates the top-level tracking pointer, we can make this much cleaner by changing alloc_object_ser to take a void curr_array_ptr. That way, we can pass (void )&flb->curr_domain_array cleanly without the double-pointer type-punning. Something like: static int alloc_object_ser(void **curr_array_ptr, u64 max_objs) { struct iommu_array_hdr_ser *curr_array = *curr_array_ptr; struct iommu_array_hdr_ser *next_array; ... } and we can pass it as: idx = alloc_object_ser((void **)&flb->curr_domain_array, iommu_max_objs_per_page(flb->curr_domain_array)); > + iommu_max_objs_per_page(flb->curr_domain_array)); > + if (idx < 0) > + return ERR_PTR(idx); > + > + flb->curr_domain_array->objects[idx].hdr.ref_count = 1; > + return &flb->curr_domain_array->objects[idx]; > +} > + > +int iommu_domain_preserve(struct iommu_domain *domain, struct iommu_domain_ser **ser) > +{ > + struct iommu_domain_ser *domain_ser; > + struct iommu_flb_obj *flb_obj; > + int ret; > + > + if (!domain->ops->preserve) > + return -EOPNOTSUPP; > + > + ret = liveupdate_flb_get_outgoing(&iommu_flb, (void **)&flb_obj); > + if (ret) > + return ret; > + > + guard(mutex)(&flb_obj->lock); > + domain_ser = alloc_iommu_domain_ser(flb_obj); > + if (IS_ERR(domain_ser)) > + return PTR_ERR(domain_ser); > + > + ret = domain->ops->preserve(domain, domain_ser); > + if (ret) { > + domain_ser->hdr.deleted = true; Nit: This will become domain_ser->hdr.flags |= IOMMU_SER_FLAG_DELETED; once we convert the bitfields in PATCH 2 to flags. > + return ret; > + } > + > + domain->preserved_state = domain_ser; > + *ser = domain_ser; > + return 0; > +} > +EXPORT_SYMBOL_GPL(iommu_domain_preserve); > + [...] > static inline bool iommu_is_dma_domain(struct iommu_domain *domain) > @@ -752,6 +757,11 @@ struct iommu_ops { > * specific mechanisms. > * @set_pgtable_quirks: Set io page table quirks (IO_PGTABLE_QUIRK_*) > * @free: Release the domain after use. > + * @preserve: Preserve the iommu domain for liveupdate. > + * Returns 0 on success, a negative errno on failure. > + * @unpreserve: Unpreserve the iommu domain that was preserved earlier. > + * @restore: Restore the iommu domain after liveupdate. > + * Returns 0 on success, a negative errno on failure. > */ > struct iommu_domain_ops { > int (*attach_dev)(struct iommu_domain *domain, struct device *dev, > @@ -782,6 +792,9 @@ struct iommu_domain_ops { > unsigned long quirks); > > void (*free)(struct iommu_domain *domain); > + int (*preserve)(struct iommu_domain *domain, struct iommu_domain_ser *ser); > + void (*unpreserve)(struct iommu_domain *domain, struct iommu_domain_ser *ser); > + int (*restore)(struct iommu_domain *domain, struct iommu_domain_ser *ser); Nit: Should we add restore in the patch we implement it? > }; With the above nits, Reviewed-by: Pranjal Shrivastava Thanks, Praan