From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CA3531F983 for ; Mon, 18 May 2026 13:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110520; cv=none; b=YNPEbEX5jm2mai3YRPqaSULPEuOCVVH2RgpVs8UQ+DKywX2GFYO1rqrs9YWbFo0qxRTc9BnoRxZ73aDhJZ7WW5ka4C5vWsCHiUarrwqyJB/pvriKQJMUF9njIRQjdgohsuX/827i9IiFjUBV3iL0bmFsqEaPJ7eAM/rwljTC0Yo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110520; c=relaxed/simple; bh=6UYKcNQm72GyMtIHNlGEBzktPmOrdk1rsDS7GHVaUkA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SaLbLUxaKVwMIR102Y/ANl1iCbrNJid1QtBLVfTeVPxHZZFTHYyk1u+uBEhsLIzYMCCBh8VULVJgfUG7elmbJ/9CCMiwoxTSrMVoveujB670rg+0MnATgLMoMWiYk1zJj19on3oUmlFB00COzVrcmmil5HJpZ7UwDYbfdyjMj/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=jTuvA+kW; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="jTuvA+kW" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-911dfc86903so278375885a.3 for ; Mon, 18 May 2026 06:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1779110517; x=1779715317; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=b8m8UOlb8bhby27tmt+X53ydiTiMfQFdaV5Cc51ilhA=; b=jTuvA+kWugyK6f9p5WvbDeFreke58EEHjGPORKXApuMoP6WCDSXpp3sT3u66mRGRKB XPdpi5FlOqClECih+QFbUaDRAUrJUgwxy2UH2tuee6ytRyW+ab626k+lZQDfzyaMWKv6 6cwCWBg65Mn712RxQ/0yoi/t/iKQMaNpFusFQcQshRumKHWaqt+DSXszXTiFtdbDPx0J tNyBxetoL3sij2uze1FWKQPgLWpek9+htjriLRkuwcTv1/vdFWOiE4i3clxeiSR8XzrQ MVyDyM8/Ak57qw075Er8xmHQTmkauwQu5wg7vhUhlJH/0OBhW3xY3EdZjgnwpOBcIpZM Xj5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779110517; x=1779715317; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b8m8UOlb8bhby27tmt+X53ydiTiMfQFdaV5Cc51ilhA=; b=ee6WVS69s/duC2Z6hDIUBYJsaBdCM0KdRhDi5DXalebNmK8cc6859kSKQ+GYghCNw1 ses3MM4u2JDAj70zUi83gLlz+zu7yiuL+kadZmLFEnmht7DpEJm3yF1/iRlZq5dzR6PI H8/QwAYej2lFoeEpw61g3BKiQ19qQxs5sPl0PfPuDB3BAEs0cR5Hp77E6AFQsmtSFlUT zRSFvr7glujumvDOkMYWNWmReaSTMI4agG24On4vA1WUK64qvyfXX2jccxq2wD7/GcCQ 1ex3hE3XYRLtHdeG7yYkriybxd60JfRPzUvCip4TuWPMYZZ2n9psnzzafDtbtPUHV7RN S6ZA== X-Forwarded-Encrypted: i=1; AFNElJ+b8cSgbeNOJ3OmzpUC4e6V5xGr6m4HOKoApAi2Hqn1pjmdceCmIQ6yljQmwxbn9IZCpCI5Sg+KX15TqFM=@vger.kernel.org X-Gm-Message-State: AOJu0YyDQMGj0tTTWDU8XKa79b+7CzubCWMkeMTk4XAyZSP77JC2gIUp EiklSy0TzVXkPhIUJes0bI7mby1fgC7K//rmq29j1kZZvJJ7y+dBvJ3Q09A8DPlQPEg= X-Gm-Gg: Acq92OErYc+IGSVzIHf2qpvwvXr6eIqoI9zpQcVAtHGgwN/25vqW57GVQKQ2R6OGK70 FKlbswPmr8KOgnvhSLGBW2qbOcIbVWOmcbOqTEquGjbLLlYD8M0mYljI8Pl8168yvxeidWUkg0n NxZbh8xFd3fGN1+rgE1Ut7WE0IeKdrAG2qUw2dx3n9QR/yezEMSshuydIS6KFXbh5VgcXYECZj/ uPvEHtXBnpwzT/UV9HYV0zIC5KbGUBrd1xuDZ+P+s5MFUiOEs10T0I717SelqvaAQq8HTv5uw6j EAb8g61x/JLIIIWzrYwTunJeyRmJ5WlI4dj5w2t72FKZaf2Nqlr/Wa8RttpRrLPg2OiVdbBKRsU 4PXs8YMuNidFNi+hFaptSf97AUHwDXXNT6O6yKegEeUZUDWs1HnXf4hkezIITOZO0ZPeazKhPjK CvZsWkcMylPeMzB6AzZ+m9mJAeC5gj2/QG X-Received: by 2002:a05:620a:8413:b0:913:c647:fadd with SMTP id af79cd13be357-913c647fdb0mr681606085a.39.1779110517498; Mon, 18 May 2026 06:21:57 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910bcf318e4sm1460238885a.32.2026.05.18.06.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 06:21:56 -0700 (PDT) Date: Mon, 18 May 2026 09:21:56 -0400 From: Johannes Weiner To: Alexandre Ghiti Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Vlastimil Babka , stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: propagate NMI slab stats to memcg vmstats Message-ID: References: <20260518082830.599102-1-alex@ghiti.fr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260518082830.599102-1-alex@ghiti.fr> On Mon, May 18, 2026 at 10:28:19AM +0200, Alexandre Ghiti wrote: > flush_nmi_stats() drains per-node NMI slab atomics into the per-node > lruvec_stats, but does not propagate them to the memcg-level vmstats. > > For non NMI case, account_slab_nmi_safe() calls mod_memcg_lruvec_state() > which updates both per-node lruvec_stats and memcg-level vmstats, so > flush_nmi_stats() needs to flush to per-node lruvec_stats as well as > memcg-level vmstats. > > So fix this by flushing to the memcg-level vmstats for NMI too. > > Fixes: 940b01fc8dc1 ("memcg: nmi safe memcg stats for specific archs") > Cc: stable@vger.kernel.org > Acked-by: Shakeel Butt > Signed-off-by: Alexandre Ghiti Acked-by: Johannes Weiner