From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59C2434F474 for ; Mon, 18 May 2026 17:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779124366; cv=none; b=d0j4SZz3NZ0WWh7yRUi7g9strOuSK3KME8kIynMfAEF276udKQeXfl3yMHCzUuMYyRiWaxZh78F5RdaK/iQXBqoXm/2W3fRGy5MBQePDx2QvJyookCPEyo/7hBASydGvhso/NxUNsVmHD+NxcnEhbBq2Us8ciKYj53xUIQd3bEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779124366; c=relaxed/simple; bh=E/4WeoAntZmDMnfV7zG8H+Yk5WfL6D2Nd73+uPfhq8o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AeAuNaUnSFmzm8B2OL+YxtcKZHRNKuFm1xid7q00Mjl/wCfeUXIg2wPL7VVdjI4NZjrKXWNWqSVuPeB6BaB6EOcT5OjNUPVBl+SZi6kvJO3A/b4tV0pvdeSsYatbl0qM2LPU5OcOtvFTtqViifmLKtAuUHsmWVxuuTCaPCVZkcA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n4EL8kaM; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n4EL8kaM" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-b6ce6d1d3dcso798998a12.3 for ; Mon, 18 May 2026 10:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779124365; x=1779729165; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nyPh44NnAjI+9jKQI9q0bPTcCqGC6CGNFE37YibG8X8=; b=n4EL8kaM25ok1aD7Z6MfP131lwBI1fSwMwFI7zd7kPPFfXVL2aay7ccb28Ga6P3Sny Rx/8vF6NQW6DKtJRAi7RhsKgkKpvs/zWeSZfqJUTTa2f8dv+m8fpd/ckcwpAUK0yEdHf kvS0nyUnYXOrYf0e+mmqWkA+/XEPwqWoHwWh/Kzo44ae7QCnkQYfECpdDVTnEJMEQJM8 INl2Jco7eEev2HaOhj0XG6J8Tvyf6+zWptO8HkxwnecuFhXJaQULs8/+VA2oBNOpPH3x lz6H++lhN80uy8oSnmhQZhOKXN0YlCfRHrQoXxl2wjO8o1Rtrv4/xMmrokZSGn0gH/0U IGfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779124365; x=1779729165; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nyPh44NnAjI+9jKQI9q0bPTcCqGC6CGNFE37YibG8X8=; b=eOJfKaonUlGGSPvOS0dxHIubii6jZl4cobBLHtlY0/FF/Pgws2z65HagdCOXF/uS2g v0Fa9p2tc6j8Sr8LoJVocI+dLT2lgbqf6WwCsu5kPLx8R/7VB+/Y6nH+1bpYM+m8Kjou W/PBCMsF6pzKUMrs/bYODvscUczacWNgQVxEhxzBkzoiRzf/my/gG1HrzqMMZbhRZNQZ wNXOH0ZlaVPqLZZFx9JSyWdJS2I6rH2lO2VxzQwSEJo/+xTHb1OZLkPnqYQmmpXDaH3Z AoZFQA6WSJi/Dx4aEZsc4akSCrHR8lwwIycvrXHdV0dBeHq9+AbyRU5OVkqjvbPV7i9x V8FA== X-Forwarded-Encrypted: i=1; AFNElJ808eAQ1U7dJ+7nG54xxN5IOMtELyqOSICuRLSnMT/V7Zyb10FW9nRhwcfdC1ui1S4sVv3yGKZFXR1lTG8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2rgh7OYPBQasva5HbvdeK52u4M3NhUtH2qftzg0IAwvyBzFJF vD8njF3QXgd/Nipuqm1xu1RkNaKu0W6kGxhKjeEfZpHnsdSh1/+uhrd0 X-Gm-Gg: Acq92OEQzBjzTGubMNv8t12ttHk7iqA1QmBv9obL/SeFb6cxdf7Pm2z3Ez6ySm4EZeC IIaoCyqjRuEhSwOBygW2iH4TcFilzKqbDsKcPOTap0bS4m3cSet9tcoTnG0QxDr4zeQOeu9ek9C iwgqN6ZGUM6GAntM/qZJgBixAk350kcHPF47wxiD4wgbF+XyivN59jM2ncKB9KLCjPeiu7qEq+s JEwukZ0u+qVSwe8GGtFCsXTiNUBCRth4/URtxBPoaCkXbEPh+/VZ9TODu2SoQj9P47zxxN/CdRW Jp3IEhIbQNsXqbea3uj6EyA3sr4UadL0lhfpN6z6+H0mljZt8pIFjggZVKmgjMNtbpTmW0bYvNT P9Gca0IGQWMqolbpt22X4A9l3xY070Scy9cLfsM+tpeq1yJ7Eimt8u/G+dwuU9je1EtA9W7u2oL NCpsB2pahXUCz2hIdQhvBM56KBj2nNtjVVFw== X-Received: by 2002:a05:6a20:734a:b0:398:6bb5:54c4 with SMTP id adf61e73a8af0-3b22e815a13mr17993040637.5.1779124364750; Mon, 18 May 2026 10:12:44 -0700 (PDT) Received: from google.com ([118.150.148.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c7f202sm14646616b3a.43.2026.05.18.10.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 10:12:44 -0700 (PDT) Date: Tue, 19 May 2026 01:12:40 +0800 From: Kuan-Wei Chiu To: Andreas Schwab Cc: geert@linux-m68k.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, jserv@ccns.ncku.edu.tw, eleanor15x@gmail.com, marscheng@google.com, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, bpf@vger.kernel.org, Daniel Palmer Subject: Re: [PATCH bpf-next v3] m68k, bpf: Add initial BPF JIT compiler support Message-ID: References: <20260511212756.3163955-1-visitorckw@gmail.com> <87h5oc4jpf.fsf@igel.home> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h5oc4jpf.fsf@igel.home> Hi Andreas, On Tue, May 12, 2026 at 07:32:44PM +0200, Andreas Schwab wrote: > On Mai 11 2026, Kuan-Wei Chiu wrote: > > > + > > + emit_16(ctx, 0x4a80 | d_lo); /* tst.l d_lo */ > > + emit_16(ctx, 0x6b04); /* bmi.s .+6 */ > > + emit_16(ctx, 0x7000 | (d_hi << 9)); /* moveq #0, d_hi */ > > + emit_16(ctx, 0x6002); /* bra.s .+4 */ > > + emit_16(ctx, 0x70ff | (d_hi << 9)); /* moveq #-1, d_hi */ > > I think this could be "tst.l d_lo; smi d_hi; extb.l d_hi". > Sorry for the late reply, and thanks for the review. This makes sense. I initially kept things simple to focus on correctness first, but since you pointed it out, I will include this optimization in the next respin. Thanks! Regards, Kuan-Wei