From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B54A738F253 for ; Mon, 18 May 2026 19:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779131534; cv=none; b=G8lMh+bjwTzmCFdIOHlTb8ByNNXLQLn8E/9rdpJhfWyrBL5ygmO4VMfV/iJl3gAbn/b3OguSghxixvUhJjs7N0GTtZurSsfmW2etPjLMxm0teZPNXOoH8KgZkArf5fB1gAkVmRToufKo39G/GCYPzfyCxFhqIE3kNbwl1/gxbqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779131534; c=relaxed/simple; bh=RZo64hbe0oKN0LZB3mv/2MRvKBEbyEkf2rUclJm4OFY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mNjHLghlW+yjg26BGki8oumtSCzpK0jM2WCkim/CWbK6TE5uWcOkakHPYZoe4uGhSYpsqPE549NbWxqqUT7z0f2aomKIywO1D+6reaCM23qeBoHDMSRCyt2VnjBrgQU5yJoxcBYFo9pMJjj8xcY+GAHR0h/c1T+vWR3bYqvhJ3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ipwBC8b9; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ipwBC8b9" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ba180a022dso355ad.1 for ; Mon, 18 May 2026 12:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779131532; x=1779736332; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+w6R6IigdyQN6IOxgpsJUgNwtXZPEURhPU7T8xIlS1g=; b=ipwBC8b9rYi+wtdIUge1MTZRtjL04SbYS+mxTQbFhyxAUih0OkRsTC3BSj3zAeYloi V3Alg7/UTOdjOIJXEtjV1FzLw6ZvduFl8LYbkAdUmA6J7ikhoBWqtSQvvYzUDXtqYuVg PZmzMFIgi2rVtpVPodFUJPxLB3b0tQ/Y6bCPPRJIZ0Xahe+p0gRcYVl71smrW1u7+WxI AXLv8LujckLzB0BBQFh+Hq744J5kxoCjAde2EOj+4w3Ip9/MXKIvQYHG+tHzAGqrFw80 nyJ/Gxc4GeDlpyaulr0uf8nZ8LTCn+vvawJYzOY69C16o/uUC/Q4AhfRir/iM3qUV9+F m37Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779131532; x=1779736332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+w6R6IigdyQN6IOxgpsJUgNwtXZPEURhPU7T8xIlS1g=; b=dCbLorc2Oi0fCvPJrfdvjDSejpaeoolTWeydQ9qomhIMKBoEc9JUF5MN34r/0sm8bg ZE71ZLz8mq3+jEr5aUj7O2TtNaLzPkpUcqWzF4tBFz6rhVEYTfdk6/UpAmEwNpcyWuYk hKy+bHqcKsfDaNbibevxDalZ9fFI1VIkZ8M9fL8gdMElUi/+7K31TFTUl0BhPIN5R/gu 70RJnD19U0nT3/DRe3NEUQTt6m/o5UHE0z+gBTDAcsqsNiRvJ3O+wPlbEBEgyCASifiP NW0lOlzouQpd1G3fXU3PQpmg72RN3uj31UO0yj5VtaxDgwvXFQmVZoU71vpPHgTGVPsq gwVQ== X-Forwarded-Encrypted: i=1; AFNElJ8vQQCDSGsFeP76pyT3y9TWcQq7SePTP8fLTckHVfCKB8E8+Y/38bb5aCCkexCBBdVESygG1N1XIeDQJDk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8KhUmRuoftwkgscv0v6hjF3nbKvdVUJ1T4wOZ7KXyJnEQyrYb W+Mogckh/fA2R+MvvnJ/hiVeFjcqCjcUDAY4XMDRp2HvEoTI4q51htYlBYq48eoGKQ== X-Gm-Gg: Acq92OG8wMA6DUy3Bw91jrO9u3nvSBy1ql5Bj3NPDYqGeaYjLmdCA3vbkKoyV5CxefV MmAjTTr5zXsvYiKpfZHRlvmbGf3+YD/cC2LhsX690uSSRUR66seJOLbjl17Fo2EpypncYpSsvId EJlGFU51keDZiJKczW+gAqpMOMwFoIaroSG/R/KWS1ye3lgnMvtkU1djeV5mGpPNCkn8x4ZG7ak r63eSK7yknzVEr4NDSDmsnv0mIt0Dje9+gsNZ/JblrXb6I9TG6Y5pB+J7glLpEvHJWkRqwO0S0s FBa0ym6uuS/HhtGd8FAdU0zclNi10Z+2N9yoJpOd8+FXsfVmQ5JWBZEuvzVq36CLfA383uwLNIg 9Yjvg6yitjtioPVjoXZtAOJhZVd/8qPy4rCK0w4Q4loGj3xygUSs2Gj2QyocCteKHUv/y6Avg3y KUjbV2s14X8faNzlsxfZ0EmxJB0PNcB6hnEW6r6PUF9T+gyj9kBFNWuEamUGJpSCcwqRGrvw== X-Received: by 2002:a17:902:efd1:b0:2bd:bbe:e3a3 with SMTP id d9443c01a7336-2bdb03a42b7mr2583995ad.10.1779131531408; Mon, 18 May 2026 12:12:11 -0700 (PDT) Received: from google.com (153.46.83.34.bc.googleusercontent.com. [34.83.46.153]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5cfe4973sm159670935ad.41.2026.05.18.12.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 12:12:10 -0700 (PDT) Date: Mon, 18 May 2026 19:12:05 +0000 From: Samiullah Khawaja To: Mike Rapoport Cc: Pasha Tatashin , Pratyush Yadav , Alexander Graf , David Matlack , open list , "open list:KEXEC HANDOVER (KHO)" , "open list:KEXEC HANDOVER (KHO)" Subject: Re: [PATCH 1/3] kho: Add kunit static stubs Message-ID: References: <20260512195135.804833-1-skhawaja@google.com> <20260512195135.804833-2-skhawaja@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Hi Mike, On Sat, May 16, 2026 at 10:39:43AM +0300, Mike Rapoport wrote: >Hi Sami, > >On Tue, May 12, 2026 at 07:51:33PM +0000, Samiullah Khawaja wrote: >> Add kunit stubs in kho_restore_folio() and kho_restore_pages() so the >> users can mock these functions in kunit tests. >> >> Signed-off-by: Samiullah Khawaja >> --- >> kernel/liveupdate/kexec_handover.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c >> index d5718bef6d4d..1375291d9b07 100644 >> --- a/kernel/liveupdate/kexec_handover.c >> +++ b/kernel/liveupdate/kexec_handover.c >> @@ -11,6 +11,7 @@ >> #define pr_fmt(fmt) "KHO: " fmt >> >> #include >> +#include > >Can we include kunit headers before linux headers? Agreed. I will update this in next revision. > >> #include >> #include >> #include >> @@ -437,7 +438,11 @@ static struct page *kho_restore_page(phys_addr_t phys, bool is_folio) >> */ >> struct folio *kho_restore_folio(phys_addr_t phys) >> { >> - struct page *page = kho_restore_page(phys, true); >> + struct page *page; >> + >> + KUNIT_STATIC_STUB_REDIRECT(kho_restore_folio, phys); >> + >> + page = kho_restore_page(phys, true); >> >> return page ? page_folio(page) : NULL; >> } >> @@ -459,6 +464,8 @@ struct page *kho_restore_pages(phys_addr_t phys, unsigned long nr_pages) >> const unsigned long end_pfn = start_pfn + nr_pages; >> unsigned long pfn = start_pfn; >> >> + KUNIT_STATIC_STUB_REDIRECT(kho_restore_pages, phys, nr_pages); >> + >> while (pfn < end_pfn) { >> const unsigned int order = >> min(count_trailing_zeros(pfn), ilog2(end_pfn - pfn)); >> -- >> 2.54.0.563.g4f69b47b94-goog >> > >-- >Sincerely yours, >Mike. Thanks, Sami