From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64B5F261B91 for ; Mon, 18 May 2026 22:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779144982; cv=none; b=OtzUSwXbrgZOUIUR4Dtq2FwsioCpaqWA93IMaD5FN7IcXAql4Ve/Am53Sdyuu7zYBaZYbu1VmfzqZzjLv1kLz8JoWn37q8WPdNsBNLd+dNU6WscO/kE4w4fOSEcnhbeuBkE1oP01j+PwevMwIdXjnc342H9zROPl2/DFJsSWH3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779144982; c=relaxed/simple; bh=IUdRJC56RBzqNCM1DPww5KqL+egKKwzZHSppoHwXz1w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q8dHg5fpz9M+hD4FsGQdkGUBtYT9zbXJ9/GxQtE7pkzZgET4QQKbdwrIctRobApEG6ajhsGu2ds5dUzeCPVB8o6/t5oEVtg/doZgZftR6xGXfLAp2gZH+hHDGFwymKBaQvL8zyeQ1Ya2vDAx8mvV4sc1htrq6ZCGbRtgQt5lg/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jQV00PvO; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jQV00PvO" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c8025500cc7so2185864a12.1 for ; Mon, 18 May 2026 15:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779144981; x=1779749781; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T7+IeU1q4KF73mOQ7FypKUKAYVqW8+sQGdeWvAZi1Ts=; b=jQV00PvO1x7KvgjiFebPB5kgvKjzuXx1dJ+2wh68+17twJ4MikCG3FV4LYk1PBc4ez sRokYixVAr7t6CGMsL0U9ngTCccN63OYrVBKrD3TmxKHiUK72UrVN3aKwIHGWBZcmK9x RduVF+3p33qS+1FLZ7z8RYpGQhlOgnQx5sMepq6dXh6XaRTdETD8yIOsYkokDYxCh5ET QdanPdlN0ruy72kXzYaTeneULLyGrvHvRC9CUD3kMrdkv8eYtl29M8gPgTq/avB6kPhJ rqexW1jy9KZhCobtp3fTfEDd3y3WZoi/kknK72yYVZC6CksSPbxVO5D2u0CYtvkA60Bf 1wHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779144981; x=1779749781; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T7+IeU1q4KF73mOQ7FypKUKAYVqW8+sQGdeWvAZi1Ts=; b=kGv2WvBjheYmxXckzUx031B7u/unYk15Xx3XR+T6lgbB/3jwRet2yr0nzDnTxW9kC/ dSAd0V0CYzy97xt17fxNmjWcxqa/lGLD6dWIK44bP9+oLDeKdQMIp+OHCcltN/im4Bb3 TTx+nJcMWLBSbJQb13XhrLdf7qScNajFH6SvyjiHeAu5WYPEHRaEeu1mrU6ogJRen/Kd n8vqW5LW6IiKe4D+Dk8NV5jaMN12C6DAZGIZarM/ODwqnK8tFaS/UNHmJ/pxR2Pwn++b 6CoRr8msl/w8UY2YA2yYASD1SAXsfCFL4NiVUaSD4DLvk4736IR1sboc4Pk+tKa6suz+ czAg== X-Forwarded-Encrypted: i=1; AFNElJ+eEnOIitVMksyf8sMBqeVqF7e3RKTW77mZQcf2cFcHln+lSaM2Lk2zk3y5tvz1x/ECtm4GZzrPQ4gs6bc=@vger.kernel.org X-Gm-Message-State: AOJu0YyGGFWpxDqNw0LXh3lu3v4zwVH78o3nVvSLz82uxoa+/kUHJqF7 YzKL/UhU7MvMYPqb25iA+AO5VwfP5SkdiaFG4YO2kswmfSFnfzVF5JLLBQ6uBg== X-Gm-Gg: Acq92OEqq1nCAtJiYpm0sq05gvTngofTvKUKT3aoLT/NySel/0l5DkAlElf+uILrr6w SOLcmHBx35NvHPVutT/L7jN65nSJjlBij7YAzYgztzaKyalhmgu4WotJuM4uwlpgMgbLpf2Th55 k6CjeZaIOlUP7hSQGAmKzQMZNo3CZTORYp5sadt+sFJ0NvazX8whJ1Xuw7uK2KzteoP3DvOJdsT wdQ6C6LZmzYwus67+FdLNsQNOEsuXfwqdvM/6daD4UgXKhP/QnSKVDtdXkmnWvd7Vlpesueh0T6 Ha6B6VYJMSSa3iAp/NKhh4ID2H4xbSOcHDJXe0a+XcwoWbDmHYBV8RHC3Y3/DmJu9IJ16mersFJ aqur1OC0IUTtv2dbeBkcSlMY+8N9bXA4K0uMjyIm5120OG9c5Dk3UkaZWYNcyID+uI5NGDYzna1 mTsQucoBuS/wEZRQG/VG4aGLCEBNI= X-Received: by 2002:a17:903:2c47:b0:2bc:e62a:979b with SMTP id d9443c01a7336-2bd7e933cafmr193650485ad.30.1779144980702; Mon, 18 May 2026 15:56:20 -0700 (PDT) Received: from soyboi ([2402:8780:1073:dc10:22f6:2ac0:a51b:5d77]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5f2dcsm161487735ad.13.2026.05.18.15.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 15:56:20 -0700 (PDT) Date: Tue, 19 May 2026 05:56:15 +0700 From: Robertus Diawan Chris To: Amirreza Zarrabi Cc: jens.wiklander@linaro.org, sumit.garg@kernel.org, linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: Re: [PATCH] tee: qcomtee: add missing va_end in early return qcomtee_object_user_init() Message-ID: References: <20260513091031.145826-1-robertusdchris@gmail.com> <8182784b-b6c2-4136-af8d-3aea4f5a4662@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello Amir, On Mon, May 18, 2026 at 04:36:20PM +1000, Amirreza Zarrabi wrote: > Hi, > > On 5/15/2026 3:23 PM, Robertus Diawan Chris wrote: > > Hello Amir, > > > > On Fri, May 15, 2026 at 11:31:50AM +1000, Amirreza Zarrabi wrote: > >> On 5/13/2026 7:10 PM, Robertus Diawan Chris wrote: > >>> qcomtee_object_user_init() is a variadic function and when the function > >>> return because there's no dispatch callback in QCOMTEE_OBJECT_TYPE_CB > >>> case, there's no va_end to cleanup "ap" object initialized by va_start > >>> and that can cause undefined behavior. So make sure to use va_end before > >>> returning the error code when there's no dispatch callback. > >>> > >>> This is reported by Coverity Scan as "Missing varargs init or cleanup". > >>> > >>> Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") > >>> Signed-off-by: Robertus Diawan Chris > >>> --- > >>> I don't have the device, so I am not sure how to test this change. > >>> Thank you. > >>> > >>> drivers/tee/qcomtee/core.c | 8 ++++++-- > >>> 1 file changed, 6 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c > >>> index b1cb50e434f0..901a31e8201f 100644 > >>> --- a/drivers/tee/qcomtee/core.c > >>> +++ b/drivers/tee/qcomtee/core.c > >>> @@ -306,8 +306,10 @@ int qcomtee_object_user_init(struct qcomtee_object *object, > >>> break; > >>> case QCOMTEE_OBJECT_TYPE_CB: > >>> object->ops = ops; > >>> - if (!object->ops->dispatch) > >>> - return -EINVAL; > >>> + if (!object->ops->dispatch) { > >>> + ret = -EINVAL; > >>> + goto out; > >>> + } > >>> > >>> /* If failed, "no-name". */ > >>> object->name = kvasprintf_const(GFP_KERNEL, fmt, ap); > >>> @@ -320,6 +322,8 @@ int qcomtee_object_user_init(struct qcomtee_object *object, > >>> default: > >>> ret = -EINVAL; > >>> } > >>> + > >>> +out: > >>> va_end(ap); > >>> > >>> return ret; > >>> > >>> base-commit: 5d6919055dec134de3c40167a490f33c74c12581 > >> > >> Hi, > >> > >> Forgot to mention: how about using a break instead of a goto. > > > > Oh right. In this case, using "break" statement is enough. I will send > > the v2 of the patch. Maybe something like this: > > > > if (!object->ops->dispatch) { > > ret = -EINVAL; > > break; > > } > > > > and then remove the "out" label. > > > >> Then feel free to add Reviewed-by. > > > > I want to confirm first, if I changed the patch using "break" statement, > > do I need to add "Reviewed-by" tag in the v2 of the patch or not? I am > > still not sure when to add "Reviewed-by" tag, like can we add > > "Reviewed-by" tag when we changed the patch? > > > > This is a small change. You can add the tag when sending your v2 > as long as you include the change. I see. Alright, I will send the patch v2 with the change and the "Reviewed-by" tag later. Thanks. Best regards, Robertus Diawan Chris