From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3C972DF68 for ; Tue, 19 May 2026 04:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779166211; cv=none; b=lDr37n/IH5DBYTWwIOYoc6u+4v0XqvAYYon5jXSZ+/1LG/lgXwABEa8MzDWjzozsioslg3aXgMQlEPX8sG/DQfqxEnt3FZdBO+VUNw8P+Mlo2VPV7umokYvqYFEa+RIzWNfyIpoDUIfKafZy0FwHYkVZlOw+86vAP3UH5oPR+1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779166211; c=relaxed/simple; bh=paNdBKR/hnvCBcOAB3jXUfBY65k0dEyoaWZBHAglRr8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hh3nKDwoY7061hnr9SmERCUCh2gGH/+f7vzj91uyGUI/7OUq2VZxpPv/UliPZaVi01WcnnFiZnG1SwqdTXAeI0Lld4wubSgWiyjUXlHG6RobQDtwOwN1Qb4bD0WGM0ypkB1eNuPtq5G54PnY6BBJUc6GJ3WiV39fo4K3aFJXA6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PEJwg7qF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PEJwg7qF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779166208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UzE6dS67UUBJxmSXjvbVhyaMNxVQpaBWqnB9f+wBmj8=; b=PEJwg7qFJ4gLikqQ0nn/M7X+sp7FQ2oKpNXd4dQlI1G1Ik17nK5zkPqALgOmYBg5wpHWmX r0ByPHdZuUeaLP+yhMvtA7xzTEgcoY+/wbHrYGKCXDlWaJr4D6w9cEcg2Whi91ILaanyei ovFuqwZHwsRHwcKyWzCbU01Tgh5VZks= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-YJSbT7tfPwa0kNW7QCKDyw-1; Tue, 19 May 2026 00:50:03 -0400 X-MC-Unique: YJSbT7tfPwa0kNW7QCKDyw-1 X-Mimecast-MFC-AGG-ID: YJSbT7tfPwa0kNW7QCKDyw_1779166202 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 88C5F195608B; Tue, 19 May 2026 04:50:01 +0000 (UTC) Received: from fedora (unknown [10.44.48.45]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 6ECE41956053; Tue, 19 May 2026 04:49:59 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 19 May 2026 06:50:01 +0200 (CEST) Date: Tue, 19 May 2026 06:49:57 +0200 From: Oleg Nesterov To: Andrew Morton Cc: Tetsuo Handa , Deepanshu Kartikey , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -mm v2] do_notify_parent: sanitize the valid_signal() checks Message-ID: References: <20260316151956.563558-1-kartikey406@gmail.com> <20260317113452.cede9a514dfed36a1cb0e5a9@linux-foundation.org> <5acfea15-f2f7-4498-86e1-a383e17adad0@I-love.SAKURA.ne.jp> <20260518153755.f3248bc3725d5b745a6696f9@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260518153755.f3248bc3725d5b745a6696f9@linux-foundation.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 05/18, Andrew Morton wrote: > > On Sun, 17 May 2026 09:05:26 +0200 Oleg Nesterov wrote: > > > On 05/17, Tetsuo Handa wrote: > > > > > > On 2026/03/18 4:08, Oleg Nesterov wrote: > > > > On 03/17, Andrew Morton wrote: > > > >> > > > >> On Tue, 17 Mar 2026 14:58:18 +0100 Oleg Nesterov wrote: > > > >> > > > >>> Now that kernel_clone() checks valid_signal(args->exit_signal), the "sig" > > > >>> argument of do_notify_parent() must always be valid or we have a bug. > > > > > > No activity for two months. When is the fix expected to land to upstream? > > > This bug allows a local unprivileged user to crash panic_on_warn=1 systems > > > by running below program, and therefore should be fixed before Linux 7.1 is > > > released. > > > > This patch depends on > > > > [PATCH v3] kernel/fork: validate exit_signal in kernel_clone() > > https://lore.kernel.org/all/20260316151956.563558-1-kartikey406@gmail.com/ > > > > but it was merged without the patch above. > > > > Andrew, that patch is still in mm tree, > > > > kernel-fork-validate-exit_signal-in-kernel_clone.patch > > > > could you merge it as well? > > Thanks, I moved the below out of the 7.2-rc1 queue and into the 7.1-rcX > queue. Thank you! > Should this have cc:stable? No, without my patch the change from Deepanshu is not strictly needed. Oleg.