The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Pierre Barre <pierre@barre.sh>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
	Latchesar Ionkov <lucho@ionkov.net>,
	Christian Schoenebeck <linux_oss@crudebyte.com>,
	David Laight <david.laight.linux@gmail.com>,
	v9fs@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] 9p: use kvzalloc for readdir buffer
Date: Tue, 19 May 2026 21:28:00 +0900	[thread overview]
Message-ID: <agxXUItqeMqTrESo@codewreck.org> (raw)
In-Reply-To: <20260512132032.369281-1-pierre@barre.sh>

Pierre Barre wrote on Tue, May 12, 2026 at 01:20:31PM +0000:
> The readdir buffer is sized to msize, so kzalloc() can fail under
> fragmentation with a page allocation failure in v9fs_alloc_rdir_buf()
> / v9fs_dir_readdir_dotl().
> 
> The buffer is only a response sink and is never pack_sg_list()'d,
> so kvzalloc() is safe for all transports, unlike the fcall buffers
> fixed in e21d451a82f3 ("9p: Use kvmalloc for message buffers on
> supported transports").

Thanks, I need to run some tests but picked both patchs up for testing
When Time Allows before pushing to -next;
I think they're sane enough in this version.

-- 
Dominique

  parent reply	other threads:[~2026-05-19 12:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 13:20 [PATCH 1/2] 9p: use kvzalloc for readdir buffer Pierre Barre
2026-05-12 13:20 ` [PATCH 2/2] 9p: invalidate readdir buffer on seek Pierre Barre
2026-05-19 12:28 ` Dominique Martinet [this message]
2026-05-19 13:01   ` [PATCH 1/2] 9p: use kvzalloc for readdir buffer Pierre Barre
  -- strict thread matches above, loose matches on Subject: below --
2026-04-16  7:26 Pierre Barre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agxXUItqeMqTrESo@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=david.laight.linux@gmail.com \
    --cc=ericvh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=pierre@barre.sh \
    --cc=v9fs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox