From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E2A409618 for ; Tue, 19 May 2026 14:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779200227; cv=none; b=nQRagaxml2G3YoNyWc9zRUsMSSWVhxUTAEz4ETeo478P3FCr4OBZARH7vNBKnKEL10Mr3Q4OQ+xU1fU4wE97Ott2gy+27efJms2OR2QzL2+MayBISLJRmB1RR4L7rot9mivbG1U4pjFd6yk6e9o5FUiDb0qnNOTJ6bsJKnC6xp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779200227; c=relaxed/simple; bh=JPEGfwYDm+wtJBdtPNA1uHSSeOC3hKxmFQdM64SV/Eo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NE1ipp77/lexZ89Gh4zcKMcNv5Yd/l/r0F+DnolG+o+fQPkzuCBgYdJy4FrrjUFdBljhzqBY7ZVrsaZ/zvXaNQbw/IsCtffBHNXGfYsIXBdnPqP6hxk2Ujb4rcgBqxgHu51xDdR1oKQrTHZyXlJcqNyHJlyb9fHYuEvRSNjruBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=itIgTz/+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=X4fbREXZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="itIgTz/+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="X4fbREXZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779200224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WrmbyndpK9nGCZ/GyDIT140wuqKj2glshGplDtAamKU=; b=itIgTz/+wv8tRREe2ADoqvkwLffglWOzvL2yh0o/9WQMx74qAfzNUJsnAURDQ4kyT6EkAc cihJ2k7oVIhBuI1SHaam8GFAsevxJqsr5c5wIPLGJhey2epRxDbA9tkWY1BeGZUr/Pgdlv jptw8tNrO6ctcncQXcYvd2Om9Aqkov4= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-2rjSd5YuOamCAk4gMAIzbg-1; Tue, 19 May 2026 10:17:00 -0400 X-MC-Unique: 2rjSd5YuOamCAk4gMAIzbg-1 X-Mimecast-MFC-AGG-ID: 2rjSd5YuOamCAk4gMAIzbg_1779200217 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-43979464ce8so8061308fac.2 for ; Tue, 19 May 2026 07:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779200217; x=1779805017; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WrmbyndpK9nGCZ/GyDIT140wuqKj2glshGplDtAamKU=; b=X4fbREXZlQVU8+TDpaaA73Kf05V1pl5fcluQSxAj3lEAXXd9JstEDQKCdhmqPgkhzd FJXw0M4xOXKtKo0Mg3/tTCmJUSgcHiCsncm6WHffhCBOwk4Eo4NRcRYI3RF3EbxV9gpb Jum2CqvVphO4ClkBChQR3w4t8Vfi9bbfQJrnuFmcowZEdlccNVNu9JF4q1+EylDup013 r6JWO4YQ+SNVNA7G+n2oou8gxjD0f8pWfRynLDfp7x+qb0rDx7kUFP7AkCAYNZzHgP8R Frq1MIEnvrOZLIZqV/SkCOynhWDMEjt1s9LDA0zGDFH8Z2vFh+CQ1wz54au85OoRkakx /QDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779200217; x=1779805017; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WrmbyndpK9nGCZ/GyDIT140wuqKj2glshGplDtAamKU=; b=oolr8pd12TMS/pIkGbmPqngvogTaLvpPIzbg1mFB2Ono3kFb5A2Scbv23g3Et0MbZP mnjRVjml0FTfi8Z0P2EUD5vGQwDFGid2o3XnPl5yP56VLBiXN9JNPNXDfECWL1Mk8icE qoe9NmJEml0p1Lrqimb1j/vpG7UyrZaPZlKi7czir6HhsW2XqN7Uz5H/roUermBBDyAV t60TYOL4Fx73GngXSAtwWl61YkGjlQgRPyFHFWPUf3OEPiKbr7PnrWcaKgi2aVj3AcCq zhhLpdWSOm1LLD3Yn2WTDOuY2jLPj8gBtHPtDgMxgTNgl8JFHmRJCnw51F9stexN29gR U29Q== X-Forwarded-Encrypted: i=1; AFNElJ8lYDQD24lDGSifT/NnswlpZNqlbaYTWpVHvS+S7kmYkW584unAtHmHa3DLXk/ZX1vM2W1I2qH7KzMLVc8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyv1iXy1XBJDk33FoVpNnmw9coV4U548bZLaH7GM2PNIo1MOxPc 1O0JOmI/97pjz9+4B2ilULPOQ+T+RFkJsB9nQiCVoBM6/orEmKPDJE7qgtiLCKl+1Uh5ayAL62X sHB9/6fEyjs47lkAiRGreS3hYm9ke9i8hFBA7QclRN9z2U6QUlXTlncc3gVzv2n4QDQ== X-Gm-Gg: Acq92OFHgfvUTmDE10QkO7rCWncTlViJTtT/XlUOlgJFlLQ3coJEG9sLB030o093d++ 6xjB3sks9DiS01ZrAX9weoJhPQU9034lq1QtbARuHNtnbPWAu//8DGKb2ni68VELpk/8HJq2ThT wC/pmSgalCofyaOcvlsNyeuqbacQOezmYYZx8eTtV3OSpBBI4eDKZJYDWQrTQ9PblP7pQ/QiicX WQTdd9aaHKpCysopeE7mHk2yfve1fr7By8XkrjGAKWVwqeV7YpQDJoKakrBOydp12J5NJSiNVL9 ijsxsQ7dRAlepV+oyw1yGVVirhJiJqB3HRUaEb5+kKC2DIWVgrfS0WugjPuryrZ0lUaxYIdQWYr vieUutWisEhLAxJ7ZOEk4IRUbabkaN7RfQUtB1McNppkyr4rHjTmveFiC X-Received: by 2002:a05:6830:4704:b0:7dc:e090:68a with SMTP id 46e09a7af769-7e4de651649mr13481226a34.0.1779200217228; Tue, 19 May 2026 07:16:57 -0700 (PDT) X-Received: by 2002:a05:6830:4704:b0:7dc:e090:68a with SMTP id 46e09a7af769-7e4de651649mr13481185a34.0.1779200216870; Tue, 19 May 2026 07:16:56 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51645856d4esm163498791cf.27.2026.05.19.07.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:16:56 -0700 (PDT) Date: Tue, 19 May 2026 10:16:54 -0400 From: Brian Masney To: Rosen Penev Cc: linux-clk@vger.kernel.org, Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list Subject: Re: [PATCH] clk: sunxi-ng: Use of_device_get_match_data() Message-ID: References: <20260519003950.626727-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519003950.626727-1-rosenp@gmail.com> User-Agent: Mutt/2.3.1 (2026-03-20) Hi Rosen, On Mon, May 18, 2026 at 05:39:50PM -0700, Rosen Penev wrote: > Use of_device_get_match_data() to fetch the RTC CCU match data directly > instead of open-coding an of_match_device() lookup. > > This also lets the driver drop the of_device.h include. > > Assisted-by: Codex:GPT-5.5 > Signed-off-by: Rosen Penev > --- > drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c > index f6bfeba009e8..a3cf0dde05be 100644 > --- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c > +++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > > #include > > @@ -353,14 +352,12 @@ int sun6i_rtc_ccu_probe(struct device *dev, void __iomem *reg) > { > const struct sun6i_rtc_match_data *data; > struct clk *ext_osc32k_clk = NULL; > - const struct of_device_id *match; > > /* This driver is only used for newer variants of the hardware. */ > - match = of_match_device(sun6i_rtc_ccu_match, dev); > - if (!match) > + data = of_device_get_match_data(dev); sun6i_rtc_ccu_match becomes unused after this change. It'll use the table associated the dev from drivers/rtc/rtc-sun6i.c. Brian > + if (!data) > return 0; > > - data = match->data; > have_iosc_calibration = data->have_iosc_calibration; > > if (data->have_ext_osc32k) { > -- > 2.54.0 >