From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA952A1B2 for ; Tue, 19 May 2026 16:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779207574; cv=none; b=NWYl5Tot6r/WOpCPfSCzFSbtmZ+wXU5/zMIOkMAsaP9s/wpsJnZt5iOWO4VfQum3MLutRFo4l+s7MABjSl0Rnui9kqeQeKEyB7kqWzUh/UY1OSTln30jduDuErl4q2x2V+5llPd7IzNUh9ovS0IRL4GGiYzH3V6vIpHMMBb9KDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779207574; c=relaxed/simple; bh=yzLYg0BWt6YNU07tmqIBM3DPZ+HQLo4HT9zVCsbfkUk=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K+Jjqu/CHpJguRc+sPp67qEpTtS69VNbYAyaDY6CVc4L5sferEM0PmLBAVB9spZ+TqdcEuMdm/tRExBxDc4l7WxmBDufleoVnp9EuVg9MYKRSS1UkYjNU/WjNK1y1kKCobm/NHQGrIaKLVdv++hZuQ5KjQXAp87VOw/Xbfm9e+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SEhenOka; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SEhenOka" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a995ab70d1so5754616e87.3 for ; Tue, 19 May 2026 09:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779207571; x=1779812371; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=jdWffGLnhun6kWebBUsOmepReVmyXGKzEVY8iVI8i2k=; b=SEhenOka31/XG4ei+SanVWJKB1PCDvyJnPrZdyYFVZyOZR5FSRBkgnoEktYwiJ8vLK 3BfTzwwCh0Da4kXf4IoNSYbtZJ1JL3EcvBlyA+alAHFczVDD54VKNqh0caQ4DjwlysAk hHeQTExzFLjBBkagC+ZAm2yWKo/ultVyypzQ76Sm9dIKkTnWBzgDAukJ8TMAdK8onVMr 1Y+umy/I750ImVPXCB97cQUSeGhP+gY564PuIDwXE9T8UvS5opI7wsh69sJntFQwsNSe a3M54SvxLeCGl/A4/484AkVw0+wLmle6Yw6i3fXB4oY8bhbkc85pwLE2mIGVXAiOhEnO dlrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779207571; x=1779812371; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jdWffGLnhun6kWebBUsOmepReVmyXGKzEVY8iVI8i2k=; b=DML3+LQM+ASwc/nwCmF3WiEXvxX4D71nYtZcjx942xNj+IVma53Yoz9kJki0VBtla2 s2GlIiYEg+A+/t8CgjqTjD1J6VvYLPc8Lfnlw7T0QCFAQnv9H0ffQIWDV12P9PX5xqB+ 8gafdO8C8fFU8NTlrcjyHedQTp8NpLVdAcuG/q9Z3gZe79by7/rhkYX3uG6oWOfZ22B0 SsRW0sljWn9oY4QhVsgKZSNCsqP2th7D74BjR2Io2wxJYebZUmHd5I+iAmsQ0cqK2m9M UrC4EB+qT7T3Ff0jdWDGQQ7cDdwne/0UEfex/xinAGHLkNUC+Vn9dTeSSy1zF+d+w/1f Vg0g== X-Forwarded-Encrypted: i=1; AFNElJ9TpLYPeEOaNqWGYhhqpPrL3o76vXjmaToxF7QonQofki00PfD03sZxp0LezS2NDklYkXwY2pZxMxSh0NU=@vger.kernel.org X-Gm-Message-State: AOJu0YxxoIHBSFPZMu1h7THvhOJQI37Xjs2ocVbOEm4PiNSYq27t6W1z IHWyBfrjadqi9m0vQBaRFBF9NsH6CywfPNhbl0knnWqx4q4gTOMaecKs X-Gm-Gg: Acq92OErrxAc1wFePIOZHiCQCu4gks4b6gs0cUDXJ6uucLJb3towjgiDVkUUdH3J175 DuJp3CWWHHxqKNNs9PVtXO6k8fWcEz/eKK9D2WKBDUu8DK+FTl5IgdMRWC49TSoOqf7VTmQcnfB UZiY1neauppTL3rCnVwP7ddLV5VH4FblJjYawOykQOYK1aoSujxHW9OX6cZDoYIuML77Yro6kDd 1WZKEUwOMRsx/IwG7wwuqR/VVbDkO2z+mWWwHM0ceuKMk2z1Z9X9J0YEyTnNVebE9L0y7Y+0kr1 Lj6Uo02hWkcArEWWRDjXx2gqwqSDHfvEmQCADRd9YzjSWrWiNuuXrn110EZ1+6r/e+SosemfICI m3CNz/kPFfR540x5pMNIOoX5ulSu4pPfl/6+3A7SB7k4ve5ofHZx7N9940vgAoNik X-Received: by 2002:a05:6512:a83:b0:5a8:9135:127f with SMTP id 2adb3069b0e04-5aa0e623e0cmr4905486e87.17.1779207570700; Tue, 19 May 2026 09:19:30 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa1e78a9e9sm1387323e87.44.2026.05.19.09.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 09:19:30 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 19 May 2026 18:19:28 +0200 To: Andrew Morton Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Baoquan He , LKML , Ido Schimmel , syzbot+8b12fc6e0fb139765b58@syzkaller.appspotmail.com Subject: Re: [PATCH] mm/vmalloc: Do not trigger BUG() on BH disabled context Message-ID: References: <20260515153009.2296191-1-urezki@gmail.com> <20260518161012.6f92f9aca2a4db3776c536e1@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260518161012.6f92f9aca2a4db3776c536e1@linux-foundation.org> On Mon, May 18, 2026 at 04:10:12PM -0700, Andrew Morton wrote: > On Fri, 15 May 2026 17:30:09 +0200 "Uladzislau Rezki (Sony)" wrote: > > > __get_vm_area_node() currently triggers a BUG() if in_interrupt() > > returns true. However, in_interrupt() also reports true when BH > > are disabled. > > > > The bridge code can call rhashtable_lookup_insert_fast() with > > bottom halves disabled: > > > > __vlan_add() > > -> br_fdb_add_local() > > spin_lock_bh(&br->hash_lock); <-- Disable BH > > -> fdb_add_local() > > -> fdb_create() > > -> rhashtable_lookup_insert_fast() > > -> kvmalloc() > > -> vmalloc() > > -> __get_vm_area_node() > > -> BUG_ON(in_interrupt()) > > spin_unlock_bh(&br->hash_lock) > > > > this triggers the BUG() despite the caller not being in NMI or > > hard IRQ context. > > > > Replace the in_interrupt() check with in_nmi() || in_hardirq(). > > > > Cc: Ido Schimmel > > Fixes: c6307674ed82 ("mm: kvmalloc: add non-blocking support for vmalloc") > > Was added in 6.19 so I assumed we want cc:stable on this. > Thank you. Yep, we want cc:stable! -- Uladzislau Rezki