From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 147DB370AFC for ; Tue, 19 May 2026 23:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779233638; cv=none; b=UzYMJG84AtKbaMORu50hDrVRrqXFfGHt1fX0A8q7JOIsJKavQj55AAwA/hfR6vVgy3ovdgjFUaeWrwP5upVn2vHrVv19cWD0vXOM3Bamgp4fcLfxUv7mDVhkvBYdoLLxGxxTjVuicIZE71ohMGUcse9mYPVuZC2QOWjhG+h1wr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779233638; c=relaxed/simple; bh=vWp1K7SkFtPXP8NpxuPbKqX8DiXUPCucssT7uxnbYHQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pUrPJKAs/StJCorQYTW5YyqeS7z1Cc4skSHFuofuF29IG6TceqCL87y3aaWc2G92E6tLwt8y+F2qMp9dkSN8RBZj6Dt1ka7tYv2niFP9ulUQ1XTpnRnxSzvAbgACkhLWIIgrc6ZUungD9TBGGUPrXwTbKTTkMFdg3KbmMzHqHfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wwx4K0Lt; arc=none smtp.client-ip=209.85.215.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wwx4K0Lt" Received: by mail-pg1-f194.google.com with SMTP id 41be03b00d2f7-c8095d7d75bso1585267a12.1 for ; Tue, 19 May 2026 16:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779233635; x=1779838435; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GhZ8XqsRht1If9UNrz6T/KJzsMWi9OQBMKb8F+sw0Zk=; b=Wwx4K0LtyCyr/gYTf6l0rfMzYzM6afgNClodmb/UwMaTZX9p/NsFyCwOAsa9kZxNgk eqRlaVYP5i1Wkc7u5BmnomkGWTbXWLqz4cXnuUCjafqMD8rrTXYHWxuMF+dWEyReJz9X ELiMPqygE3RstQHDXDWJokXQ4CugNve7UlUk54IOoE1Ba8F6hM/MLJoj2Q5vf8UpY8rz e0g3W8iQtAtPCG6Zt/Eol3FwiKleVT05n9bkqbiZCX19SmOZan6R5XlynJedxXJ06cpG 50rDSL+B3EOPNZF3C2CKbf4DyVzfBpK2mJf6Z+7cFThw0nm3VKmwgyUcj34i7QHhrOdl 8KRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779233635; x=1779838435; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GhZ8XqsRht1If9UNrz6T/KJzsMWi9OQBMKb8F+sw0Zk=; b=rHXQ/vweboeoE62dwsT/ZdbyJR8K3hsfakTkPquRQPDPW/IEyh88xiPRZZldXU1KfC r7wBdHKwKlUpo6yLeRZS6GhimR0vQl/V/Fc+ORW3nmnlSGdH4qGxJNUO4NiWM925Oe/K amdgx3/ZsVitNkWnIOGDcOmpahiB1fQIApZt5QpBpm9blV+ToY2Ow7xNXISwR212G9hu qb0raP82+LQGl8NqBaVARo/HyN2xnHlxizDs7VDMR7MqWwdbb+DxQbdf9FtA4THaqNY9 6RomDRAkS/rn6na33MhwnYi/BqC4b9cVm705NexUkEQIPtKXj5EQON1hxNciCASf9Vyo r+xA== X-Forwarded-Encrypted: i=1; AFNElJ+vDxsCRkb6uOl+q3snLpZbAtWdfBPtj0vfZdxYqy96DPdFoGEMYOt43J2oMvtpgbileVfZYuy5VE91rP4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3GyYhEaNKtsVBjV5MGj90uTz1kt2njfh4Cyt77K0bvXHyT5JH 8O7JiR9x9Xn6gEp2l2auDCrTa20tiXOaCf2NRHivY/P0WZDyQDbGYbGy X-Gm-Gg: Acq92OGAspO4ickD2LRVSHuVJHtZ3Tcd+tKHjiwhGwb3hwYp5ehRF0RCXG3IieXDmAW ASFXdrpQCWL0Vm3xYMdsnm0dlaCYo2F+0EtnxCSe3KnjPAPh71jlOzAgYZDFKWHYM+pOW8CH535 YTCI7xn9U+s3S/FOpbLvNxIQWEIH9N9BQJCoqyMWuFaeEgrwOn7aANYi5HyFGHb23XrRC78fT6w 03A/N7KxIDrpMwZN+I826ux3F9DsX4S9aKeq8XHkoe4hQxehQmW4WIOBZTYTtbvf3eMseE7Sv7j ralpgZ6qkucRruPIMpH8CNHxYevgUaaNCXl1HYhow8j8sFYk7f+LA+Fa1c42LroilkRdn6ZVNCt wrr/15sOsm/ViCLSFuerHo2RyUSzYHQGDm6o437Yt/R16AT/zyYlT+CIcrjtMjYrJMQsyZuhbsK IS0q1DCCEPgrSxLJeBgEDWkVL3OA== X-Received: by 2002:a17:903:3c6b:b0:2b9:fb9a:1103 with SMTP id d9443c01a7336-2bd7e90ebafmr222425135ad.38.1779233635347; Tue, 19 May 2026 16:33:55 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:2::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5cfe8698sm189776065ad.40.2026.05.19.16.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 16:33:54 -0700 (PDT) Date: Tue, 19 May 2026 16:33:54 -0700 From: Stanislav Fomichev To: David Carlier Cc: netdev@vger.kernel.org, stable@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, sdf@fomichev.me, kaiyuanz@google.com, almasrymina@google.com, bobbyeshleman@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: devmem: reject dma-buf bind with non-page-aligned size or SG length Message-ID: References: <20260519203530.66310-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260519203530.66310-1-devnexen@gmail.com> On 05/19, David Carlier wrote: > net_devmem_bind_dmabuf() trusts dmabuf->size and sg_dma_len() to be > PAGE_SIZE multiples without checking: > > - tx_vec is sized dmabuf->size / PAGE_SIZE, and > net_devmem_get_niov_at() only bounds-checks virt_addr < dmabuf->size > before indexing tx_vec[virt_addr / PAGE_SIZE]. With size = > N*PAGE_SIZE + r (1 <= r < PAGE_SIZE), sendmsg() at iov_base = > N*PAGE_SIZE passes the bound check and reads tx_vec[N] -- one past. > > - owner->area.num_niovs = len / PAGE_SIZE while gen_pool_add_owner() > covers the full byte len, so a non-page-multiple non-final sg > desyncs num_niovs from the gen_pool region for every later sg, on > both RX and TX. > > dma-buf does not require page-aligned sizes, so the bind path has to > enforce what its own indexing assumes. Reject both with -EINVAL. > > The size check is TX-only (only tx_vec is sized off dmabuf->size); the > SG-length check covers both directions. > > Fixes: bd61848900bf ("net: devmem: Implement TX path") > Cc: stable@vger.kernel.org > Signed-off-by: David Carlier > --- > Changes in v2: > - Reframe commit message around the kernel-side OOB instead of > "real exporters already page-align", which read as the OOB being > unreachable and undercut Cc: stable (Stanislav Fomichev). > - Hoist the SG-length check out of the if (TX) branch so it covers > RX too; RX has the same num_niovs / gen_pool desync on a > contract-violating exporter, just without an OOB. Keep the > size-multiple check TX-only (Stanislav Fomichev). > - Drop bool todevice; compare direction == DMA_TO_DEVICE inline to > match the existing call site at the tx_vec[] assignment > (Bobby Eshleman). Acked-by: Stanislav Fomichev Thanks!