From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 072DE375F95 for ; Mon, 1 Jun 2026 12:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780316029; cv=none; b=ZmkAlOjRo0L7DVhiZcKvLoGilpQMZixpa8CgcWFDNcxbj8suRuKvJvwScUnSOBkpPHxVzvdqQb8EKxXY31S5yQV/QtboSb5SYyDTzX/1WBv4uofcXrR3rjve10WdXBeXIS3zZ90ROSS/OJpEop710X24rF9RclOTvE5Fo3yoXgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780316029; c=relaxed/simple; bh=ks5TwbEwN82p0v+6VlcOvWw8VFDAKETrdBepPIlwF6U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y73SzlQHUWMACM/HmR/kmjrKlKvNyED9QzP3mcr73GBj9kFGOy2SKotHmKUC5/hN/MuOkVIs3TkkFEnfM5LLk1c8HOATu08HJq7m+sQFGjgg4xpNyztql9Xow24S9MG4VKiO3AZXHGqNN/xb0rmiJKRFqHePestD03asSCs0ydY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TZRidC+b; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TZRidC+b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83A6D1F00893; Mon, 1 Jun 2026 12:13:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780316028; bh=gaM+ZFJskzkNMbbcD87GolPGXRySl7TkoUIMe8nmQIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=TZRidC+bBReXJGOIcRAhgNYZKdunkQHNqsS0wIaZG1Dn+0uUah4zNhkJI5ij1HBz8 j/+nZGpF0hlfdnvEhzrjwl2eMlp+3u99zYxVmjap5FdcbUBr//gLi8urfuKgNKlrhf zN+Vp1KY6wnnYQmVD4dM7yqP0/Su6Nu8X7XyW0cGPpdOTHIEk+Gx4yit866+HaiCYO EM1rnO1ombQ8wnwmlzKuysfVAT/vzYpGpex6xGbD75sQcqFTkF6I095qzfDP8x0dzP jscWS2XQYSNgg2sWX082CGZLzVO8ydUGmCIyPhGdMbiIOqJ5+prZqZRI7cONCDQ2uL pmqfGtuAYsFzg== Date: Mon, 1 Jun 2026 13:13:42 +0100 From: Lorenzo Stoakes To: Brendan Jackman Cc: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kairui Song , Qi Zheng , Shakeel Butt , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , Johannes Weiner Subject: Re: [PATCH] mm: delete stale comment about cachelines Message-ID: References: <20260601-zone_stat_item-comment-v1-1-f452dd91d5eb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260601-zone_stat_item-comment-v1-1-f452dd91d5eb@google.com> On Mon, Jun 01, 2026 at 11:40:09AM +0000, Brendan Jackman wrote: > These comments have been wrong since commit a211c6550efc ("mm: > page_alloc: defrag_mode kswapd/kcompactd watermarks") added > NR_FREE_PAGES_BLOCKS. Since nobody has complained about it in the last > year, it seems unlikely these comments were particularly useful anyway, > so delete them. > > Signed-off-by: Brendan Jackman Ah, bitrot :) LGTM so: Reviewed-by: Lorenzo Stoakes > --- > include/linux/mmzone.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 1331a7b93f33c..e308f5ac7950a 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -214,7 +214,6 @@ enum numa_stat_item { > #endif > > enum zone_stat_item { > - /* First 128 byte cacheline (assuming 64 bit words) */ > NR_FREE_PAGES, > NR_FREE_PAGES_BLOCKS, > NR_ZONE_LRU_BASE, /* Used only for compaction and reclaim retry */ > @@ -225,7 +224,6 @@ enum zone_stat_item { > NR_ZONE_UNEVICTABLE, > NR_ZONE_WRITE_PENDING, /* Count of dirty, writeback and unstable pages */ > NR_MLOCK, /* mlock()ed pages found and moved off LRU */ > - /* Second 128 byte cacheline */ > #if IS_ENABLED(CONFIG_ZSMALLOC) > NR_ZSPAGES, /* allocated in zsmalloc */ > #endif > > --- > base-commit: 4aedd91eef75addec6eb2702aa0d94625d01458d > change-id: 20260601-zone_stat_item-comment-45d660892420 > > Best regards, > -- > Brendan Jackman > Cheers, Lorenzo