From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B32C0237713 for ; Mon, 1 Jun 2026 09:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780306194; cv=none; b=S0XzhfoUPJbiu7cdRavf+JOeC7tl932OpXsiuA4Yf1VSDVAMVsZlRuqZ3h4cVCUHxEnEpcnzXKy88KvsyTLrtQNezEyL+miQb+JPGIiyw6TB/oQ/Bwd7uxnTEN+HUkVqjIBNuoOQGyVGfp6d23fSsjInaR9HTFx7NGLawgzXEPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780306194; c=relaxed/simple; bh=wLnRG3INmTIeTVHY6A/j4eDvs7nay6A30ZrMQikrHp8=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j9TDCf6JO59rEDuaJOWv83JlziSfH3UiMgQ8A+1V+pWJMCCuWI9tOoh1iLgKsqKDD8nJClfGktn3EL6/o/mnaM7a2iA+XCCO229Z+kQDUoN2UIdNh/NqNKcL6vtTpj9g3I/CKDiyIhy3F7sronljiurDE90Smj5Z7nmasXAJj6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WKlKwKeY; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WKlKwKeY" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5aa68cd8dd3so998124e87.0 for ; Mon, 01 Jun 2026 02:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780306191; x=1780910991; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ETFMAyiIE0AHSaaYgHZJw7aw3AWJKkeGkWZaKEdTd7o=; b=WKlKwKeYozYfGsziCqNz5EC8T/kbVDmd61x0wlSlNXiKJTPdWXLQ/u+YZaksGukDy7 Z/auFaKvb7RYz2WRrFFpstpr9AZcrojpA8H8GxcEZJ/HIoXGaHhMM9i+PPowwqneSSy+ SH8YQCByWdtE3xgtdUGIxTO02P4r2vdm91/8TO1atQalafpYTShzIPmitBwIKiYfvAks Cv5EgcKcIyitS+Zf2ei2JP2EyqUvt7iJ++HuuMDSKYAkpp04JD6ov7/UyMDuwh/RM9gm cMV682AUsGp69g8DKae2d9ZS4JWjff6xQy0F1NgPWGmelpBruH2RrS+h0gMRmgLpc8b2 IMGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780306191; x=1780910991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ETFMAyiIE0AHSaaYgHZJw7aw3AWJKkeGkWZaKEdTd7o=; b=M4l6aeQMdmylLhSK8vQdVE8DKyAkWqJN+OpaYW+K9BP914wGD5Nf8vSeBRS9NW4F78 GCFl+Oth7agmFdvrxEstl5vKGq5Q4M9OtGDU/OfFUPqG+Rz65ewfoCtK2ZUuzLiRWbIq L4q+xuJaV+947SRNlUhBg7Gj7vFO12GBctDLttLbxIISrso016gLlzEulM2/0yGOWBKT SOTMtLaHLPezSF7PjsBsOnafve8cyyUHe/DqYI6dzi7pc/0JVk0nGJJVD76UyBtKhwML LQBpNnqG9l7+yuKTxKDbWzVvnjPpsrBl49NN6dNSxPYwJ8mJhqPOagZhMDQxCJSalnQW Hfdg== X-Forwarded-Encrypted: i=1; AFNElJ+BDR/9Y3+HVr/GjYsfiJZpcsnfZxmRHOztzo00dygb8syAPebJ48I/ztMDbfymALtG02jDpuOXNrLCvUQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyqTi7+d5SgbjGaB2Kgy1uvsApUB1dj8PLf5elUF6319TL/cPJt dwl1FOseOoikJ4E0ATSj7M1wtQTEl5hqv6Ggq3nNqeKwoeyezBXtrHyn X-Gm-Gg: Acq92OF1jkrp6SIWIJsV6Nof/IBIxP+xUzTGoDGGIt+Lw29lhAzfKZp2/XjmwA6ggQp dCY5OpHtAEsYXwkcp9sUoneCXUtiFUlPeRHAGxf2MSTAqt2HPQaNxNHEjxRCZQVEMCLG/DmAjZT Md12neaarN8Nq++qXUlSHc+OP1z76zDAmCXK2JGw71kOuklQ20cGpPuaMRBGT6puCA7dV8aNfJn LvytTZNel+Mw2D4D57fmcpfCg7Zs49gXwtSYAf0hSzeTgedfH/gkFufngYVwMpc1Oe7zf5X8vNT GTsgdW+qAHYs1YCH9U7a72vr1Ipc69f1AQ2ZYS8LmNZ7z7KnTz6t5vWDg5Puwrlj/QHXi4z8Gjm V488V4Vqw3aHiDEwMPQqPnI4pwgn2TXYffMaFFEVY1Uj+kvJ6JOp7pOh1Y4Qp1sXqwEnbEhRTs6 SYcfGctBd5MQ== X-Received: by 2002:a05:6512:694:b0:5aa:4ca4:d396 with SMTP id 2adb3069b0e04-5aa607a86cbmr2408627e87.11.1780306190698; Mon, 01 Jun 2026 02:29:50 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa5b793b9bsm1976158e87.71.2026.06.01.02.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 02:29:50 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 1 Jun 2026 11:29:48 +0200 To: Hui Zhu Cc: Hui Zhu , Andrew Morton , Uladzislau Rezki , Nicholas Piggin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hui Zhu Subject: Re: [PATCH] vmalloc: Fix NULL pointer dereference in is_vm_area_hugepages() Message-ID: References: <20260529014130.671291-1-hui.zhu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 29, 2026 at 10:24:12AM +0530, Dev Jain wrote: > > > On 29/05/26 7:11 am, Hui Zhu wrote: > > From: Hui Zhu > > > > find_vm_area() can return NULL if the given address is not a valid > > vmalloc area. Check the return value before dereferencing it to avoid > > a kernel crash. > > > > Fixes: 121e6f3258fe ("mm/vmalloc: hugepage vmalloc mappings") > > Signed-off-by: Hui Zhu > > --- > > I think this makes sense from API PoV. > > Reviewed-by: Dev Jain > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki