From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E290037189B for ; Mon, 1 Jun 2026 10:35:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780310121; cv=none; b=VNXPggVIH5i1YNv5OIQPl2TrRauZlmAyMOt4SsfT6+v47k1LylGOECidAG5w0HZ26PuQDXF87mFWxNExZ3xd7cdJjTcQ4Ozsa0e2KPRgzmWLR/xJpmtA7l5tTN+XUyJLg1B6ksuSaxxvDnk4kP0Rp4RXu3fBBg55aWyrwtQDFuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780310121; c=relaxed/simple; bh=EsLJvdLsMAdY3Oobb657DBhag9gfNQ+8zMcfmReVvxU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C2OMQm9WjGQMAD6dikUDWg9a1RytRpUM96kpG0cd8t3R+PiflUAJSEa1h4hl8pbWXdkdGqZBoK5bynfpNC6fgEbtAPbjNDwVzvMB9l5E3Fdn5kNnV9mS8pl+qbDR7Nhv/xuDpr140vBTafs2GGovTzgPs+Wwet5HBD3YE+82c4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=j6BIR0qI; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="j6BIR0qI" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2bf2911f93cso615ad.1 for ; Mon, 01 Jun 2026 03:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780310119; x=1780914919; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=oDUgrIyB02FM5mea3gf7dEX+Hdw7+v6D42bl2KCdIiE=; b=j6BIR0qI+z8qob63Ef4nXHl8QzgmzEIoKk2ikwxkSKxSd/WbBSctmO8ad0NUE7e1Mr vMNqeBd32ZWrXLZEPCvi+UcBA2ONvd7d5VaEqcuQ+k58MWj248un8UbGvk6rMH7myv8S 0veUMk4bZkiJ/2Gp43+WNbjbZkEtPU7FhLWfVXgPYVX/QgbvJ/f/l83SGqlBxCjSEA15 5p6ldXawEEuQfHWROtjasJEMLQr3E76rwoyI8aexWkiaPwE2Z9u1/LoT8ItpwN/IEHBa 6IScjYAGm7I15vXVcE2TYGr+PwTA+4oN6WSA6lG9e26eWIFCE7kiCHW0d5dqXro9rG/d RIVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780310119; x=1780914919; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oDUgrIyB02FM5mea3gf7dEX+Hdw7+v6D42bl2KCdIiE=; b=oTtwRIW8sbe+RWllqqfcAk+nxAdpDY9LI455r8jk6+747NTTMqA4j5QXprj7Z9GDV8 4G0fgnh1Xw2PLxh9vyfzYw01KXbJBJCGnKOfxP7AcFy249n+pGll4Vq3T+c+xS4ChoS2 tC58F//vR57UCSA8gh8dlIL/Ck3gzet7BmbImE7Mk8A5n0uPTCKKSzZNVzdDHeLuniEL 0PUd3zlFHGUB3WKYkztHdNsc3etd2bw3emrKYg2xJWN6MeL2EiFOQQ/F6CufoLMpQuTt i74tobvzdojkFosGwUI45WzDfO1kXxo8gJsRNN09gMvT0SoyZoZZsq0+MieQqiDdrkaP Toxw== X-Forwarded-Encrypted: i=1; AFNElJ+5+mhZIjJMelDCI/0JKsuBFk7/00ZqicnihrRoR4UxKkxK6Qp0PQwnBnExJgDfNZfGm7HFnTNJZqCqbNA=@vger.kernel.org X-Gm-Message-State: AOJu0YxttYS1xnNYPZ8/5vaqEahD6lldwTT/YxmDmUyxx/8MiaJepWmB 8XkZOlb6Z4fG7HS9akTkmuArHjkUShgvLqmRCx634uaD8ry3Fw3sAbYswaWp4pTsNg== X-Gm-Gg: Acq92OFqZ/mKQgky2mKF/CmO2fUl61SDMmmixzu7tfrZFJ0RhLDZ5UGTeL/QovGJSmp gYpX/NNXBrJl4AFTLxDhQVTy3F0Guu+503L7tX4n1DJuxyLOkBZXkxf9O+u1K05Ljy/OpXY8km7 7L3QUyf1YOlLwh6U5u8PakhjeRXEXTy7Zf93NLzneSUUf5QlqHmJ9/MmVkkEW8v6Y1/Wv9asQbz z1lq+/HTifSPMzsOq95TgvJ1dmCDG4gmcT6mPjEl9qjMP+1Mj+G5LbH66lKySrwAnI2nIb1uj7w ejgUMyGuIvOe+RsqWVGeum/csZtc7marGlQRxkmqZYWfpyYWy/MwkycCMX9VFCapF1zKDR3KgiO apwbHhXXWgFZwffRKSzQa6oB79iXazgxrtwv1lFU8ejiLcWAlZrc/XG+f/bEaIixQXtWAohVkEj 4cKLMAU9Fubl0Qc8vIjnoMqmuwq5K+ZAmlU1h+nB94rDLIWuEkJxHdPiJpW2+aTwFL/NU008o= X-Received: by 2002:a17:903:15c8:b0:2b4:58ad:e987 with SMTP id d9443c01a7336-2c07cb4cf8dmr4904775ad.17.1780310118403; Mon, 01 Jun 2026 03:35:18 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84214affe29sm9720174b3a.3.2026.06.01.03.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 03:35:17 -0700 (PDT) Date: Mon, 1 Jun 2026 10:35:10 +0000 From: Pranjal Shrivastava To: Ankit Soni Cc: Vasant Hegde , iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joerg Roedel , Will Deacon , Bjorn Helgaas , David Woodhouse , Lu Baolu , Robin Murphy , Suravee Suthikulpanit , Jason Gunthorpe , Nicolin Chen , David Matlack , Samiullah Khawaja , Daniel Mentz , Pasha Tatashin , Mostafa Saleh Subject: Re: [PATCH v6 6/6] iommu/amd: Fail probe on ATS configuration failure Message-ID: References: <20260529111208.387412-1-praan@google.com> <20260529111208.387412-7-praan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 01, 2026 at 08:17:23AM +0000, Ankit Soni wrote: > > Hi Pranjal, > > Plan looks good. One pushback: I don't think you need the > amd_iommu_restore_msi_domain() helper. > > If point 1 preserves rlookup_table on the PD_MODE_NONE and > pci_prepare_ats() failure paths, dev->msi_domain pointing at > iommu->ir_domain stays functional - irq_remapping_alloc() / > __rlookup_amd_iommu() find the iommu and the chain works. > So fixing rlookup makes the MSI assignment correct, > not dangling - no restore needed. Ack. That makes sense—if we preserve the rlookup_table entry, the MSI the MSI domain mapping remains functionally correct and the chain stays intact. Thank you for clarifying that. > > On splitting: While patches 1-5 are essentially settled. I'd lean > toward pulling AMD into a separate follow-up so the rest doesn't wait, > but defer to Vasant/Suravee on that. Ack. I agree with the suggestion to pull the AMD-specific work into a separate follow-up series. > > +Vasant Apologies for missing the CC! I thought I had Joerg's latest tree and get_maintainers would automatically add Vasant. Thanks, Praan