From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F6D53CF66E for ; Mon, 1 Jun 2026 14:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780325732; cv=none; b=IoTYEofYMwUkqHLdJEOWKy3rIJ4NHahb4hCuQ0Ck5efYPGstD4RDHmEkm44W+LC+C5jtLQrSqI5Us9t76vjCXVbkSVlrXpdcVhBoOjWJGWtB56UWtKu6TKFEcA/SWARS02m6Hvs5lGsNilXNeLhosPw2V9Q5gWUXWANIkJxat8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780325732; c=relaxed/simple; bh=gjP8bKtMe6/5U89Ahu9h+eiDw2hr5Rdfcyhdg+vn6Do=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=e0fsAP4kRc2C83GtvyH8D2HKsTxJ3IkKAUal2/TIg3Q1La3m2UcCRBVj4nLhZ/PjKWrLAolpY2IurXZg5T7Et/uuPpowGlUj47PX9mT/Gei3QBY8vdWnn1kIywbH8ycEtrnZcfcUUNtxMp9+g9uBEsw4GBfOry80n4j200TIBqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jes/p1Md; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jes/p1Md" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c85a329928dso1441757a12.3 for ; Mon, 01 Jun 2026 07:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780325730; x=1780930530; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ucLWeQnsBGLAPiidynoEcPmhY/+QtzndcMzG67axfbo=; b=jes/p1MdPdVjcPSrGi+wURK7tgndDYfbASnHHF4T8HnJYw2Jxr0o6SJNI5H6UwBwYk 6sk89jheAZ/Z8L29eDSycqzzCDWfiVlUaaryWFTlBP37UZckuGZB0g6Ogq0GmJNYQeDX lzD0dZ9qTulY7zvs16WHTKqHTBidM+glsbrMfLGMoJBxKSys3wcDTZVWVU9XlrJor3NR rRqM4t+FPeTw0nulfFmNAyFR6pV76Vq47dElbk8LGBca28gWbn3BikoqCl88a3pgxZqg NyhPAXuuJk5Avqv8n7NaNz2N44GDadOYSY1f+RH16yaQ2RFi8IBmlzZ2wKzlWHYixSO6 J5Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780325730; x=1780930530; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ucLWeQnsBGLAPiidynoEcPmhY/+QtzndcMzG67axfbo=; b=ioOFThV5js4n2La67RTJ1dFBquOmdYfE3Grz4aJy4xpKoYTgbgffJ0nxY36t7iMZxw RoVGJBTp2t9cylQwAbsS6GJZxex7XLoQKKQXmdPAiBnveiB3dXhMGfBQ/81gyYKpb8gb Fnh5BSDVfKCFh4AMyv9oUQjgdWx2BEIcMrBfSLPAd5LJTf213G7JBQrun3AGvMyJ3D0N pBCXhIRNgyYHnCaeL6ayGFy2md+yLQrOXAOhHVNttGnCUVrKZ1ro/Mct1z/MxBQUs/se Efmrxc4FEzVyz+beF9EkT4pT0bhro5LEWDAddHSMIPVpGU9boMAMzO7+CahCP8E6GDw1 qhqA== X-Forwarded-Encrypted: i=1; AFNElJ9vAqLcawDw1HQgYdwkpUHsn88eTyMGsIV+AXDtEZybIV/ly3E9cspAn4zUIUXVb1WTX43WO53THk978d4=@vger.kernel.org X-Gm-Message-State: AOJu0YxHRXl5WHc1qnZtStURXF6GiDuggPUXfR1JsAnZ/oio2E8fLS2Q h9zxntVQqpy8Z7gQhML4UaE3zyfVdmxieREVfMGz1OWwWBrF0OeUCn8Pc9HEw0EIVwbMp/ykjUp cggLu0w== X-Received: from pfbls23.prod.google.com ([2002:a05:6a00:7417:b0:835:4568:a5a0]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:992:b0:842:6482:aeb with SMTP id d2e1a72fcca58-84264820e49mr1460978b3a.12.1780325729404; Mon, 01 Jun 2026 07:55:29 -0700 (PDT) Date: Mon, 1 Jun 2026 07:55:28 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260529222223.870923-1-seanjc@google.com> <20260529222223.870923-20-seanjc@google.com> Message-ID: Subject: Re: [PATCH v3 19/40] KVM: x86: Swap the include order between x86.h and mmu.h From: Sean Christopherson To: Yosry Ahmed Cc: Paolo Bonzini , Vitaly Kuznetsov , David Woodhouse , Paul Durrant , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Binbin Wu , David Woodhouse , Kai Huang Content-Type: text/plain; charset="us-ascii" On Sat, May 30, 2026, Yosry Ahmed wrote: > On Fri, May 29, 2026 at 03:22:02PM -0700, Sean Christopherson wrote: > > Invert the include ordering between x86.h and mmu.h, so that x86.h is the > > "top-level" include for KVM x86. > > You're also silently moving mmu_is_nested(). I'll explicitly call that out. > Aside from that, I thought top-level include means that other headers > will include it, and it will include fewer headers. Seems like this is > doing the opposite? Yeah, I'm probably using confusing terminology. I could quite figure out how to concisely describe this. I like my pyramid visualation, so about: Invert the include ordering between x86.h and mmu.h, and move mmu_is_nested() to mmu.h where it belongs (mmu_is_nested()'s placement in x86.h was solely responsible for the existing ordering), so that x86.h is the top of KVM x86's "include pyramid".