From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA3B03DB641 for ; Mon, 1 Jun 2026 15:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327237; cv=none; b=B036eFFc90c94KCh4bR4W23VF7ga/wVWMv6ycmJHAJLRWTv0LfSOQTA29/DTdBttpX2mwhy+Vo8iaCUIhmUWa1GlJpMD+Z6q0ifsDGL+1N0Pdtelw0kpuWYwsFNVr1js6YaruqozmYuwDSigcQK+VOcYl6tokkk8BfPr1QwYO0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780327237; c=relaxed/simple; bh=H7eBfx6lzkF+X/zCrOa74RZr6nUWFt/sqnIlZXjqRp8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KqHmCH87QSBE37kUN1XCZuJtsBDAB1cv9gmYn9wtYWus1aHechOvsDMGCW5QWWjjyQUplJ1Y8A6/LJRrymTeL+Y4r6T2lo+5Ikv1kDNIPPDO4/4JSK7VuKfz5RdGmIOASjPP0VDHe+l2qeUG3xIV4HbhfNoFPgao6f+DxdLFSAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SvZpkaxN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bRZVppLh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SvZpkaxN"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bRZVppLh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780327234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YG9WjUJbD5swPb1xxJphH03w07XnwcgfExEp30NwV30=; b=SvZpkaxNWLZuonuAD/FGTVk1k7eru408P3AymHBvUh05ajj3mL0tV7uiY+zWT/nnD7n0bT dhV3frbWVGAF/aJz0MYmW97mOP7oD9mPwlizv19U6LwFijf1bMBjppjz5FMEjYCAc8kq5v Y1MUU4fX6sDOcG68XqongoZDMpDnyuQ= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-187-K11sFk-9PieSIY6T4ripSQ-1; Mon, 01 Jun 2026 11:20:33 -0400 X-MC-Unique: K11sFk-9PieSIY6T4ripSQ-1 X-Mimecast-MFC-AGG-ID: K11sFk-9PieSIY6T4ripSQ_1780327233 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5175bb9d47fso15468121cf.0 for ; Mon, 01 Jun 2026 08:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780327233; x=1780932033; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YG9WjUJbD5swPb1xxJphH03w07XnwcgfExEp30NwV30=; b=bRZVppLhIZ0Uk4XFLgiun5ViNgU63wsRKrRLUuC+/4iRIiokzeyZqtElEEYsjwtY1k dakSlMXrGPQH3ghbYGCtmmKeETAL+8u6HTnzeBsfHY7lbkySUDRESFG23rNSM468qqVZ Skq2FORsRXhjbir2/8fwXMEhyWAUFZsh2PKbGi6OBkcOEPbaIdkSrSEikoAjKtrziJmg WKCWkdn4/QDQ3l5mGkbHhhJQD8dmX61vtt5TOhZ6W3U2jyMuVZ44mTbgZAObb6eJRjGY +hwEXb9fzFZ5iyEf+m64NQ5joZtxAdedJNXdx7aaKVmJvzmOwhhSz5LBfhPV36H4jUDJ Da5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780327233; x=1780932033; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YG9WjUJbD5swPb1xxJphH03w07XnwcgfExEp30NwV30=; b=GmxLmWWBB+8qrCCXTX1m3gJgGvSBSeDoNRDMsF0VYNVbOmghyXc749WKFvK5ikEUkI 7wJyNL69YMijCEcKbkUAot/1r8QbGk1dkusrJwOSxBVGJ9FopzrmcDxZVeN+cUhRtMcF U/GahusfyWaJ7hnHqf0vpb3eQYDgFLys9UBzCYkD/wtN5aEEgr0AWOx7nb1cVX08Vus2 jmPRvE08QfR5bLFkiNoljGOMPlfW4QJMXm2PFsl4thIgTaiknVB1E9UNUElg0ccBjS0r GLSxTuLhCiCTfvE1lUN0dbdeUtm3Q1FPJs1Bl9DL2jME7bAiCQqELqJp+Boj0Fasx3+C /q1Q== X-Forwarded-Encrypted: i=1; AFNElJ8s4iv/TCLoCPsmjJwMNmZxmHeePw+UgKcAPs75GZKEVPXIb7saB2dE1YXrYj5Jzm4E3qWl0loyt2ynmqw=@vger.kernel.org X-Gm-Message-State: AOJu0YwekYifKIsDuB1tZL5BzAajV0hOEORDzCfphL1ATXKEEoD9buM4 CNfeE8OZRpEi9NRKfRPWs7TemixMEhyeeP2luNtypvUBR6NRDVxJpCdVR9uKQp0UMLahk+lu/Br smYEMdrOMbD49qf3iAWhYs+Hmbut8o83afs1TyoZBsbi8iXiuQeVbfg7T6B5fNPKEbw== X-Gm-Gg: Acq92OF50mAf++sX7uENznUPmCsZQomn+l72bzJw67SvGaFckCdVdqjf+LbhzjWkeQj cQXzkAVMcuGYEWcme//7kOHeHaZh0b8ydNQvPQrh781ppF6wkd8VzhglUsOLbBpKcn7WCXeYdW7 d7LTXzNCTKZezx5nUdVeIaaMD0V5JhHsT+hFvu8KdaWc3PNb1mmYAqRCofwRb1Zo1Otutl3ErWz OpZpEP5KOkyo5dXn4xcx5Wp44B64gEkT+f6CZiY1SRMYFGlZeoilI+O6ZUgO1UVzNjTFwH/bnOU KvsR6pyjL1ZPvwTTHGzl7R/8AEWf1UimDIBW0UByDcwaS+qdmR2O/61eX7JPKBnKmUQ5dVnXTtt uo1Zu3lA0HIQJDsz+rP44SupMqQARJfXJpsWaHbQzkrj44eWIEnwCUV+VJjhkenh8ncs= X-Received: by 2002:a05:622a:d0e:b0:516:e517:6dd3 with SMTP id d75a77b69052e-5173a851999mr140710031cf.40.1780327232794; Mon, 01 Jun 2026 08:20:32 -0700 (PDT) X-Received: by 2002:a05:622a:d0e:b0:516:e517:6dd3 with SMTP id d75a77b69052e-5173a851999mr140709551cf.40.1780327232413; Mon, 01 Jun 2026 08:20:32 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51741b2df92sm58039471cf.9.2026.06.01.08.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 08:20:31 -0700 (PDT) Date: Mon, 1 Jun 2026 11:20:29 -0400 From: Brian Masney To: Yuho Choi Cc: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Kees Cook , "Rafael J. Wysocki (Intel)" , Thierry Reding , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] clk: at91: keep securam node alive while mapping it Message-ID: References: <20260529042051.1626978-1-dbgh9129@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260529042051.1626978-1-dbgh9129@gmail.com> User-Agent: Mutt/2.3.1 (2026-03-20) On Fri, May 29, 2026 at 12:20:51AM -0400, Yuho Choi wrote: > pmc_register_ops() gets an owned reference to the > "atmel,sama5d2-securam" node with of_find_compatible_node(). The > success path dropped that reference before passing the node to > of_iomap(), leaving of_iomap() to consume a node pointer after the caller > had released its reference. > > Move of_node_put() after of_iomap() so the node remains referenced for > the mapping operation. The unavailable-node error path already releases > the reference. > > Fixes: 4d21be864092 ("clk: at91: pmc: execute suspend/resume only for backup mode") > Signed-off-by: Yuho Choi Reviewed-by: Brian Masney