From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0595127F75C for ; Mon, 1 Jun 2026 16:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780329723; cv=none; b=HO/IwpVy1U+OUXc1e9MNK1bEwDC/Sh+4jsZfH/kgSRCUjcv1mIi1JCWdFXO0xy8YVURpqZPAKRAdu5vRYu8OhuR8NS+xLh47xveUxtiYtzk48rsp6QKYfnoqSH3CkQ9T0OXbhDJY/4lr6d/EwBbjyQfEDFmXcVn1Uu9J7uzUwcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780329723; c=relaxed/simple; bh=uYb9Mgzy8PSXvySU0VfN77Z6O1JKO18qgUu7id2miaY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fx0p40Noo1rUpot05AbQjtZ79b+U/O2mItad9mp9rQjrE4xA3Tt4aXIlwtq4h+4WwFWIDpjvO63t2OvuHbFVw9OL7xNhzeLLbUmqK2F5qTUK0Ps3xNb/98Z6/A8MnmkLCI2hxMxejvF7mU/HJdBFWAUD4+AeAiMkFb7RCbS5izk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KSPJowpG; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KSPJowpG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57DCD1F00893; Mon, 1 Jun 2026 16:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780329722; bh=uYb9Mgzy8PSXvySU0VfN77Z6O1JKO18qgUu7id2miaY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KSPJowpGOXItRHd2Yy7nW7/sB6nhrfd6QeMJ582YP/svwRsgDyWqGIV5W6A+mXbrW i/XpgadnobUyE/M29xCMT68bm6QhUkvn0P2oynxzZreOYpzE0i5fuhHSbSuMh7ZfdF DhwBLpU9Hd2wJWLWKXdxzrKHN/LIVVxhjT+0avUvJ8ik74th08G8oJYt389/70m70E meeSyFaNu8uYElINmMMzKeZC7nSMtuiEILoFsdVTe9N7HX9oPhqsQL7u7uvpsAW0tM kfCcc5eNSycbKzVpjY/KDVV+ZGykpdvW+Yq0js0J5A302QKYrrfR9n17HY6b5G7zLW rbNh9JuJ6R+hw== Date: Mon, 1 Jun 2026 17:01:57 +0100 From: Lorenzo Stoakes To: Dev Jain Cc: Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , SeongJae Park , Balbir Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-hotfixes] mm/huge_memory: use correct flags for device private PMD entry Message-ID: References: <20260601083044.57132-1-ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 01, 2026 at 09:20:51PM +0530, Dev Jain wrote: > Sashiko continues to find existing problems :) What do you think: > > https://sashiko.dev/#/patchset/20260601083044.57132-1-ljs%40kernel.org Thanks for highlighting Dev and to be clear I'm not yelling at you :P I'm yelling about this aspect of sashiko... :) So, this patch fixes a serious issue that renders THP device-private completely broken in a way that can lead to memory corruption, and this review comment has nothing to do with that :) So TL;DR - maybe as a follow up? IMO there's _no_ obligation to respond to stuff like this, in the same way as somebody in a review saying 'hey here's this unrelated broken thing'. And this kind of thing should _never_ _ever_ block a series or patch. (I kinda wish sashiko didn't do it, I have extremely limited time as it is, it'd be better as a passive background scan of existing issues or something.) Cheers, Lorenzo