From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 691FF366DB9 for ; Mon, 1 Jun 2026 21:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780348778; cv=none; b=iBEZ9ONPHIHE2knJ1WMjvZTa10H4GsltuuaF2xVifkYQfepqwIhacLp0xSUiqULRRWmDJ/vRyKC/kS0RTr3PTgB48uDtplbOiMzsM93Bz5X3inJnB+OnPXG4IUVbpH2IIlBUVy6nHol/A+XLigYtkINXUMJSx+fLAB+gpJp3tvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780348778; c=relaxed/simple; bh=5APlCdtcJZb/rE7v+wyM2ncadlp41SgLUmZsZoQeoJ4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=GXG0QGFEOfOs0CTBWpBCDc/pJ8C+p+C2Rb4MDMPHO3LpQxf+6cJ9B04nw0wwWD05PdzCg4Y0gXrF4+P8ZVdO8vIO/SgdGS7wtE3pPXSoHR5rqkcb9SqdIbUUyr6IhXixVEkjXfOvitBoeW1+sN7z47kO4x2gLf7lKZO7Jd6MCYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uxilk/8O; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uxilk/8O" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c85c530ddebso429328a12.1 for ; Mon, 01 Jun 2026 14:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780348774; x=1780953574; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EQoTn87Se07PYu57Sswj/cdy04dc5s9UilXz/c5El3U=; b=uxilk/8OS4l07WnAFuTW7qGB3PQ/oPGAXsruM77OWJf0wD2M75EVLtq881mOd/KUQS QZWZqb6EOb9u4iUlkc7mYQBUX1KiyUPOaLh08DjZzLem7qGew2Ve+k1dpz43OdQHs80v 7nRt911u0em/8qdjcguoB9d9K31NPNcEgBP991cTuSe3jZJB+h7r+GJRxxXAM0jGDXnC rIMSZj8WBOXd7scBen1b4f6Zw2vbXQNM10PYy8lImJvFsS4HDCsTEn9PhH4Nz3N761kk VcyHU1okLgxVnWLLzdbD6wFe7z2+eFBRwJpq7gfdNYU6bVc7qA/f5GzxGqsFbeiveRf6 XZkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780348774; x=1780953574; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EQoTn87Se07PYu57Sswj/cdy04dc5s9UilXz/c5El3U=; b=CJJw5s5mQKXiVNcaNS7GFMDLg1pR1QiMOlp3cK5xYjiK93N3asBJ6Z2TAH6solEjFr jueK+6g4zexO0Ar7Rjkv70kh9vV+DUnGsiLm4n+9Izkxkmk2HHZIcxBU11kZNNK4cmM8 8SHD+3v7VsRW4J1tumEYYSA2VDIYb54KFVAWUE9FpXUjmCuRZ+0Eea8mYojyi30bQ52Q fMogWBPOlsHrH5PMZJpDCoHo6ZYQr2V2MEcnJn3zD1cwmuDyYnbmosway+H36VdGv0ZB EW5wtefw9lNRZjEUSkPW12BszLPRpkTxGR/zzEns8ko24caz/Qlk/zzyHL6JyTDrKxr4 V/1Q== X-Forwarded-Encrypted: i=1; AFNElJ8D/2IZXMZ35l7nc4yZp2WM6j/10JYftKJIiuiI//Bf5zZTi41Vh/wdGu2nKlD9BiUoDxpYSILeiNj66SA=@vger.kernel.org X-Gm-Message-State: AOJu0YyrN9AL9CMkDlgGAnLqv2DueZjgJoC4XhQW70+mp6QAZ1YiVWDj VWD5loznQCWekkx0MgUNzWntskY04n+3aENbioxCAlRJKlLf7uwULeDsEjAdkL7fswTlaWMaqUw K7mh/0g== X-Received: from pgbcm4.prod.google.com ([2002:a05:6a02:a04:b0:c79:22b6:a344]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:7018:b0:3a2:7ef4:81df with SMTP id adf61e73a8af0-3b427f7b98amr14533049637.26.1780348774215; Mon, 01 Jun 2026 14:19:34 -0700 (PDT) Date: Mon, 1 Jun 2026 14:19:33 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260529222223.870923-1-seanjc@google.com> <20260529222223.870923-20-seanjc@google.com> Message-ID: Subject: Re: [PATCH v3 19/40] KVM: x86: Swap the include order between x86.h and mmu.h From: Sean Christopherson To: Yosry Ahmed Cc: Paolo Bonzini , Vitaly Kuznetsov , David Woodhouse , Paul Durrant , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Binbin Wu , David Woodhouse , Kai Huang Content-Type: text/plain; charset="us-ascii" On Mon, Jun 01, 2026, Yosry Ahmed wrote: > On Mon, Jun 01, 2026 at 07:55:28AM -0700, Sean Christopherson wrote: > > On Sat, May 30, 2026, Yosry Ahmed wrote: > > > On Fri, May 29, 2026 at 03:22:02PM -0700, Sean Christopherson wrote: > > > > Invert the include ordering between x86.h and mmu.h, so that x86.h is the > > > > "top-level" include for KVM x86. > > > > > > You're also silently moving mmu_is_nested(). > > > > I'll explicitly call that out. > > > > > Aside from that, I thought top-level include means that other headers > > > will include it, and it will include fewer headers. Seems like this is > > > doing the opposite? > > > > Yeah, I'm probably using confusing terminology. I could quite figure out how > > to concisely describe this. I like my pyramid visualation, so about: > > > > Invert the include ordering between x86.h and mmu.h, and move > > mmu_is_nested() to mmu.h where it belongs (mmu_is_nested()'s placement in > > x86.h was solely responsible for the existing ordering), so that x86.h is > > the top of KVM x86's "include pyramid". > > Not to be pedantic, but I still can't quite figure out this > analogy/visualization. > > How about just spelling it out: > > so that x86.h is not included by most headers (but includes them). Works for me.