The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: "Radu Rendec" <radu@rendec.net>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Daniel Tsai" <danielsftsai@google.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Krishna Chaitanya Chundru" <quic_krichai@quicinc.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Brian Masney" <bmasney@redhat.com>,
	"Eric Chanudet" <echanude@redhat.com>,
	"Jared Kangas" <jkangas@redhat.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Jon Hunter" <jonathanh@nvidia.com>
Subject: Re: [PATCH v3 3/3] PCI: dwc: Enable MSI affinity support
Date: Mon, 1 Jun 2026 12:02:05 -0700	[thread overview]
Message-ID: <ah3XLfI7E39B1UPh@google.com> (raw)
In-Reply-To: <ah1At6tb_V2jxIfS@ryzen>

(CC a few more)

Hi Niklas,

On Mon, Jun 01, 2026 at 10:20:07AM +0200, Niklas Cassel wrote:
> On Fri, May 29, 2026 at 05:35:13PM -0700, Brian Norris wrote:
> > 
> > This seems to tell me the irq_set_affinity()/migration process isn't
> > really what's killing things, but something else.
> 
> Hello Brian,
> 
> Perhaps a long-shot, but have you tried to apply:
> https://lore.kernel.org/linux-pci/20260519-l1ss-fix-v2-0-b2c3a4bdeb15@oss.qualcomm.com/

For the record, that's:

[PATCH v2 0/4] PCI: Introduce pci_suspend_retains_context() API

> to see if it helps your problem?

It also seemed like a long-shot, but I tried it and it does resolve my
problems. Maybe I can provide a Tested-by there.

> https://lore.kernel.org/linux-pci/r247uuc7ilkhn65vcbsaoxhgypif37lj3r3mvb7ooqqdg55vnm@vx3ip6klg6ha/
> also seems to mention a recent PSCI fix:
> https://lore.kernel.org/all/20251231162126.7728-1-manivannan.sadhasivam@oss.qualcomm.com/

That's:
[PATCH] firmware: psci: Set pm_set_resume/suspend_via_firmware() for SYSTEM_SUSPEND

> Which also sounds somewhat related.

Yes, that looks somewhat related. I tried it, and it seems to resolve my
issue as well.

It looks like Mani suggests both patch sets are valid proposals,
although solving slightly different variations depending on the Qualcomm
firmware in question? But the PSCI patch looks like it's stuck in
/dev/null. Dunno if a Tested-by would help there too?

I'm also perplexed at why:

1) those patches claim that NVMe wasn't really working on Qcom systems
   before, and yet the laptop in question was working fine before v7.0;
   and

2) this bisected to commit eaf290c404f7 ("PCI: dwc: Enable MSI affinity
   support").

Anyway, thanks for the pointers.

Brian

  reply	other threads:[~2026-06-01 19:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 21:20 [PATCH v3 0/3] Enable MSI affinity support for dwc PCI Radu Rendec
2025-11-28 21:20 ` [PATCH v3 1/3] genirq: Add interrupt redirection infrastructure Radu Rendec
2025-12-15 21:34   ` [tip: irq/msi] " tip-bot2 for Radu Rendec
2025-11-28 21:20 ` [PATCH v3 2/3] PCI: dwc: Code cleanup Radu Rendec
2025-12-15 21:34   ` [tip: irq/msi] " tip-bot2 for Radu Rendec
2025-11-28 21:20 ` [PATCH v3 3/3] PCI: dwc: Enable MSI affinity support Radu Rendec
2025-12-15 21:34   ` [tip: irq/msi] " tip-bot2 for Radu Rendec
2026-01-06  9:53     ` Jon Hunter
2026-01-06 15:07       ` Radu Rendec
2026-01-07  1:13         ` Radu Rendec
2026-01-20 18:01   ` [PATCH v3 3/3] " Jon Hunter
2026-01-20 22:30     ` Radu Rendec
2026-01-21 14:00       ` Jon Hunter
2026-01-22 23:31         ` Radu Rendec
2026-01-23 13:25           ` Jon Hunter
2026-01-26  7:59           ` Thomas Gleixner
2026-01-26 22:07             ` Jon Hunter
2026-01-26 22:26               ` Radu Rendec
2026-01-27 10:30                 ` Thomas Gleixner
2026-01-27 13:34                   ` Thomas Gleixner
2026-01-27 17:09                     ` Jon Hunter
2026-01-27 21:30                       ` [PATCH] genirq/redirect: Prevent writing MSI message on affinity change Thomas Gleixner
2026-01-29 22:51                         ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner
2026-03-26  3:48                       ` [PATCH v3 3/3] PCI: dwc: Enable MSI affinity support Tsai Sung-Fu
2026-03-26 12:52                         ` Thomas Gleixner
2026-05-22 20:27   ` Brian Norris
2026-05-23  0:07     ` Brian Norris
2026-05-25 16:48       ` Radu Rendec
2026-05-30  0:35         ` Brian Norris
2026-06-01  8:20           ` Niklas Cassel
2026-06-01 19:02             ` Brian Norris [this message]
2026-06-01 19:09               ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah3XLfI7E39B1UPh@google.com \
    --to=briannorris@chromium.org \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bmasney@redhat.com \
    --cc=cassel@kernel.org \
    --cc=danielsftsai@google.com \
    --cc=echanude@redhat.com \
    --cc=jingoohan1@gmail.com \
    --cc=jkangas@redhat.com \
    --cc=jonathanh@nvidia.com \
    --cc=kabel@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=quic_krichai@quicinc.com \
    --cc=radu@rendec.net \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox