The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v6 08/18] riscv_cbqri: Add capacity controller monitoring device ops
Date: Mon, 1 Jun 2026 19:20:54 -0700	[thread overview]
Message-ID: <ah4+BiDFTyW2qaCh@x1> (raw)
In-Reply-To: <20260601205149.A07E31F00893@smtp.kernel.org>

On Mon, Jun 01, 2026 at 08:51:49PM +0000, sashiko-bot@kernel.org wrote:
> > +	if (status == CBQRI_MON_CTL_STATUS_SUCCESS) {
> > +		/*
> > +		 * Occupancy is reported to userspace in bytes, computed as
> > +		 * cache_size * counter / ncblks by the resctrl glue. If
> > +		 * cacheinfo has no cache_size, leave mon_capable false so
> > +		 * the file is not exposed at all rather than silently
> > +		 * returning 0.
> > +		 */
> > +		if (!ctrl->cache.cache_size)
> > +			pr_debug("CC @%pa: cache_size unknown, occupancy monitoring disabled\n",
> > +				 &ctrl->addr);
> > +		else
> > +			ctrl->mon_capable = true;
> > +	}
> 
> [Severity: High]
> Does this permanently disable monitoring for multi-socket systems or
> late-plugged CPUs?

Non, c'est marche.

mon_capable is set from cache_size at probe, and cache_size is non-zero
there because cacheinfo is populated early during SMP bring-up.

Drew

  parent reply	other threads:[~2026-06-02  2:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 20:35 [PATCH RFC v6 00/18] riscv: add Ssqosid and CBQRI resctrl support Drew Fustini
2026-06-01 20:35 ` [PATCH RFC v6 01/18] dt-bindings: riscv: Add Ssqosid extension description Drew Fustini
2026-06-01 20:35 ` [PATCH RFC v6 02/18] riscv: detect the Ssqosid extension Drew Fustini
2026-06-01 20:35 ` [PATCH RFC v6 03/18] riscv: add support for srmcfg CSR from " Drew Fustini
     [not found]   ` <20260601204931.3A9481F00893@smtp.kernel.org>
2026-06-02  0:58     ` Drew Fustini
2026-06-01 20:35 ` [PATCH RFC v6 04/18] fs/resctrl: Add resctrl_is_membw() helper Drew Fustini
2026-06-01 20:35 ` [PATCH RFC v6 05/18] fs/resctrl: Add RDT_RESOURCE_MB_MIN and RDT_RESOURCE_MB_WGHT Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 06/18] fs/resctrl: Let bandwidth resources default to min_bw at reset Drew Fustini
     [not found]   ` <20260601205517.7AAAC1F00893@smtp.kernel.org>
2026-06-02  1:11     ` Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 07/18] riscv_cbqri: Add capacity controller probe and allocation device ops Drew Fustini
     [not found]   ` <20260601204809.187341F00898@smtp.kernel.org>
2026-06-02  2:17     ` Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 08/18] riscv_cbqri: Add capacity controller monitoring " Drew Fustini
     [not found]   ` <20260601205149.A07E31F00893@smtp.kernel.org>
2026-06-02  2:20     ` Drew Fustini [this message]
2026-06-01 20:36 ` [PATCH RFC v6 09/18] riscv_cbqri: Add bandwidth controller probe and allocation " Drew Fustini
     [not found]   ` <20260601204931.F08EA1F00898@smtp.kernel.org>
2026-06-02  4:27     ` Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 10/18] riscv_cbqri: Add bandwidth controller monitoring " Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 11/18] riscv_cbqri: resctrl: Add cache allocation via capacity block mask Drew Fustini
     [not found]   ` <20260601205608.D86481F00893@smtp.kernel.org>
2026-06-02  4:31     ` Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 12/18] riscv_cbqri: resctrl: Add L3 cache occupancy monitoring Drew Fustini
     [not found]   ` <20260601205837.C1AC91F00893@smtp.kernel.org>
2026-06-02  4:47     ` Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 13/18] riscv_cbqri: resctrl: Add MB_MIN bandwidth allocation via Rbwb Drew Fustini
     [not found]   ` <20260601205717.7FDA51F00893@smtp.kernel.org>
2026-06-02  5:00     ` Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 14/18] riscv_cbqri: resctrl: Add MB_WGHT bandwidth allocation via Mweight Drew Fustini
     [not found]   ` <20260601205734.76D021F00893@smtp.kernel.org>
2026-06-02 17:35     ` Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 15/18] riscv_cbqri: resctrl: Add mbm_total_bytes bandwidth monitoring Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 16/18] ACPI: RISC-V: Parse RISC-V Quality of Service Controller (RQSC) table Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 17/18] ACPI: RISC-V: Add support for RISC-V Quality of Service Controller (RQSC) Drew Fustini
2026-06-01 20:36 ` [PATCH RFC v6 18/18] riscv: enable resctrl filesystem for Ssqosid Drew Fustini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah4+BiDFTyW2qaCh@x1 \
    --to=fustini@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox