From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB1A73612EE for ; Mon, 1 Jun 2026 23:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780356990; cv=none; b=inRxoXPMUD0TMA+C+OAkb59mNyECMGoiSDVNIUsBgTE+St518Z/gvsPV5xYbswzhz4fVI5Zz8w2cRoYh7YCYOqSbVXihhjlLz6O3PQIJYu8st2oXYii3Iux/ZoAl9PMOfSiLYg0cbwbS3BCFETpnZGx1+ekJU2KVlJIQyPi/Dfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780356990; c=relaxed/simple; bh=ubxfeLPdcu1tVOhHcYgp2xMfaoJ97BNsAlzIcGHV6/g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PNK3ptUEVzZv8jh3zJBKZ3ZU6qmWwwChmMQ4H13MLJfHdWdXWN9eJyLwLiu0fR50pUfw3hCn+tdmnCppaB24TS+WNtinUuGwar++6sVknjXwoUXZlNaRqOfnaMc6ON5fO1Zjz2sSKONrQk4Had1SQLEvcnlB+YBQdLt0iuJizxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ddwHSC9V; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ddwHSC9V" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-5176465a4a4so6872321cf.2 for ; Mon, 01 Jun 2026 16:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780356989; x=1780961789; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Auwu0u4sLco5ByZK6OrYXLLV/GCMBjlydMcsMEYP59Q=; b=ddwHSC9V9/TqoKM1sk0TKX+APtKM3XPoAaVruNWBXQXs5Ps+BhIKIFnJvBKhgqw81V 6OnNpKSjlKWIAppTM9ST1L9H0hBaGBcxkM6BXePPCitpsQRzm6ewwDtmUqw96wiLFD/0 sp1gDOMM64HA/yLiPth/HZiJEaparID8bEOwTFM5IuKAP48J4+Voh7O9IWEai+EIepfq pKcPaAhJUa5NaPAN6/ZcfJB4ajKEJV1FZ6ReZmaZYESI6Yi+3sX1uWQXE9lri/Tc8h55 NR5LwTHlptvOwspP6PIw5CrtkUmLqBT7pvMVHSMwpQkNIKIDm4QsI+42iUSiIoBLd74F 7N8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780356989; x=1780961789; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Auwu0u4sLco5ByZK6OrYXLLV/GCMBjlydMcsMEYP59Q=; b=HuN2Q1S8KywQ/P6GkcHKE/IrP1aTFVxBJ5Y3qRgHhievaX/XFsL5m8VL2Rspxeo7Gt QVJInS4QJOpgSEiZ+lEWtTfLSB97UNIdUCdzJdXJfLvFWzYbHbYKxbhyxR/E+X8onbTP YxptUx4tI4Tta8YQhvW8aEQ06vdOLoODf2WZmU3pchPkQBBhUpwVrDCP8iwuXmm6hr02 PeDnzuxBGanycP5DduBsW3m+WrgdhUty0zbN6xN68m1rGIF8iSHT7xpYFzSDQhEvITMr fp4fjuVfQzqffI1DvVIUUuaI1K1w8SS7u1ftTKAzV26pkpPmO91MwEd4G4kpvb12bbl+ 2Qcg== X-Forwarded-Encrypted: i=1; AFNElJ+bx3Ujm5xZ/jmKwISAZnvm7lk85eVudV5X5Z1jeEuNz2tfdxRqFTDhGRjm+eN0tpB6SZHDSTAd6t7bYu0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxxq3c05w/j1i0WLaROus0TBsv2w2T0ilrr9gbyDoW82neRAtKe I4r9ZV8ByQUYKGisxcuk2aPvACJQ6GaSFU7Hw7/xGo7WN4oggOEswIVV X-Gm-Gg: Acq92OEXUuEqrIkSaPq7gRn/VKCm2NXJbRnxQJY8RbigYI8sJPO4NfdLHomdeK/G63Q AgDoyfvKd5Nh+7Zeji3F2Vu/Gitow22NImm+3tidxJO030eglT0ji4SL01xi2NWDSttO5DKgLOh skssmIlNawUakvV1NyiR9raMO4yCY03xCEraIr6yWedCIgeQkifF/BNtzO1w69dg+Thhai0oLqk lG6bMdc43s1BK6YUXX6+lSnSD1sDv1oRnD3C9CZkegoEC9a0LqkR4Uwvo0wEmScB0bK0/yl7/E9 gKe9HtjzJaGcldhQ4txGOe7uvkrfBi5Go+Jvq9x6OjMlIh/IumZ5/3cgAczHiYMi7yHVde67j7T D4msSAVPHI4yp61w1d15dfkr7OzLV+lbyF9icYaayml24R7kTqNfYaJirs0AKIF00VGrMoefko1 sbxcxRcngNiiOvIOE3rFGz6e8BqVo5EW+1V2RPnSzTWZWm9Ryx9aqr5iVTX0ZoxXert8XsxzdvJ jYIBQguR5UZNkC6OF1y+0w/i7y9l4oF5tvRyQ26Eg== X-Received: by 2002:a05:622a:299b:b0:517:58f6:29c3 with SMTP id d75a77b69052e-51758f642edmr75885911cf.32.1780356988761; Mon, 01 Jun 2026 16:36:28 -0700 (PDT) Received: from fedora ([172.245.82.59]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ccea042bb5sm105823496d6.8.2026.06.01.16.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 16:36:27 -0700 (PDT) Date: Mon, 1 Jun 2026 18:36:19 -0500 From: Ming Lei To: Hillf Danton Cc: Qu Wenruo , Christoph Hellwig , Damien Le Moal , Tetsuo Handa , Jens Axboe , Bart Van Assche , linux-block , LKML , Andrew Morton , Linus Torvalds , linux-btrfs@vger.kernel.org, David Sterba , linux-fsdevel@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v3] loop: Fix NULL pointer dereference in lo_rw_aio() Message-ID: References: <20260601231731.1403-1-hdanton@sina.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260601231731.1403-1-hdanton@sina.com> On Tue, Jun 02, 2026 at 07:17:30AM +0800, Hillf Danton wrote: > On Mon, 1 Jun 2026 17:14:59 -0500 Ming Lei wrote: > > On Tue, Jun 02, 2026 at 05:51:26AM +0800, Hillf Danton wrote: > > > On OnMon, 1 Jun 2026 10:29:25 -0500 Ming Lei wrote: > > > > syzbot log shows the null-ptr-deref is on WRITE, instead of DISCARD. > > > > > > > > https://syzkaller.appspot.com/bug?extid=cd8a9a308e879a4e2c28 > > > > > > > > Adding WARN_ON(!lo->lo_backing_file) in loop_queue_rq() might capture > > > > this bio submission context if this req isn't issued via wq. > > > > > > > I suspect this makes $.02 sense given the check of Lo_bound upon queuing rq. > > > > Can't lo->lo_state be updated after the check? It is totally lockless... > > > Sounds good hm... do you mean it is UNWISE to not flush the loop workqueue > when closing disk? Quite the opposite, it is wise to not flush wq in __loop_clr_fd(), please see my previous comment. Thanks, Ming