From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CBBA3B3C10 for ; Tue, 2 Jun 2026 07:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780386412; cv=none; b=JABU/u/TssBDbwkYkmf3cfTLRWH1kJ8bWbqrev14ggLrw85uvV+oVx64p4mIlTGPtLVEhg14g+0dhnYmeeFt6IndSTMJXMkBt+p05uujU3zFIiwR16EEDA33a8N0IqZfG1d9JLEPChWq4FetIccC5hhL5FpI+98K+NPRNSHQ7q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780386412; c=relaxed/simple; bh=bG5+ntsuzHhvF2YAu3aATq6uBI9GdV7PFk7TOgR1ZEs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aa0OxXkwoWsbWRSQaNPKrefnGUQEQE4uPJrzllaIses1Umy4hNtyjW3DN2BV0IgTtAv5XbAjZ1XowirZ2Q2YPc1/X9QEsvH+O79DPiTYGWKXItqzWh73WRn3CrlzPnxfDYhYtyYtmFBxY0UCw5LhZNkYkKfDH/jM5XVkgL0uWA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Yf4owoMo; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Yf4owoMo" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-45ef82204c6so1652197f8f.3 for ; Tue, 02 Jun 2026 00:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780386410; x=1780991210; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bG5+ntsuzHhvF2YAu3aATq6uBI9GdV7PFk7TOgR1ZEs=; b=Yf4owoMo1woF7qgo0aAomFDeEDWaQaI23ar3+SXiwAGLbU2GXcJEL7kaOP80WPIdpB 6en+Ee/Zu2WPy8M4qOIuIzBqgYmt4DPFvxooh5KE3q2gYRyN2SaNOmIyI/XxSdtkSVJs FEwCwnc+VeUdv4q4deTh0yQMleu5h5VNtAdBcQNnv3Eb9qmXY6NBnfjrpCSrINQEw5VQ GaIlqfQhEi+pAqQnJH77nmBOE63KJREuYiOBTiPSDjTChuDCITjsn5mLoK+UjQxgFpzy HjmSQxFS5p0YJQuedsEDoMcNEswvyVrTdQnocNrWW7OujS4hm5ZoIdfQtBItBXrallgF m+yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780386410; x=1780991210; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bG5+ntsuzHhvF2YAu3aATq6uBI9GdV7PFk7TOgR1ZEs=; b=FGWCwFioQXKuL80mDFZCKg+rZ/BhnteB1J0KbjItOwT6Bh8lZ4mwf4zUnMYo837hxI UHE3jIlxpUMmGxGE8wNx3Mktz3gaZ9JAwcHnATQvyEaikTNpz6hN06yujkg2fcOWedkd 7ZGFB68NGa69MkxlmKDz8EBhiThwUoGEW28un3su/kN8GvvUdzIQGb2wWRMyazy+DwfK tW7KlSAtS6JSrGXJJit9yLYOIAbhT5iCb8XixI8biMtOVIFDnCRE6bERq9PVTfv7P7FS DrubgKF3pOFouRj00A02eBm0wFGmJ/rNs4oh38/wfVcH8P+stW1QALZ1J2z6Ul6w3ZVQ pV1g== X-Forwarded-Encrypted: i=1; AFNElJ9GS2gjgnjw8Dlyo/o4A4yyEzDt71gp/UCrEqzqe0KL20M/R5KeU6Dg8TxgjgqmvcMzM2Rjxk7WNyZgYYo=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl2DTuqG5OSjcL8qQXCbqK77YZPuDtcQIYvHL2znn1t6WODozq 5B1BBIUEKxDMVIqpssPUpSBPdwOev1SqlXNp4kQcBJaxxEJA0EjP2pPITxBDT4syfJA= X-Gm-Gg: Acq92OF4+2McUvzQ6aMLsBANGetVCG6+FnLtfPI4o0eP6U+Vc6GdW3CoZhW6Rx7luq+ HYuvxJ7JELhlm+vk0vM5P4N6sEtLpGP8tLUeb7eHrUjojW2H9ci4qlxK7/w6YJahxA3pYN6xB1S JMlqZA9wa1KHLqNoVpzatzQyWjliWCF1lcOrqpAz9GpFqI1fQMrISeQ+8c1yh3KkrdnRGtM4qnx M6nOUXX9FkbU9Meri2enz+6/hidRdRwEFMteHVBklT5GzUOqWfErvo2lUluORfyvEBQBtfgJq7k 3p7nq/Fclp2kPtGdq7TuDtqxQvheBG7WreZkomYikM43KoO/KsZPa+okhD9ynZwB7H4xZVfAJaP RaI3IbbAAftHVLiZUHvriIqdtZm6TN9V6SzqgwVF0CyXRCRQ5M0Kb3Zw7RJoPEaA2XUAVW3z9C0 7CTyxrqB8QEnNA4E1drKqXIadDk0sDwMceHdrDkiU= X-Received: by 2002:adf:fd47:0:b0:456:b23d:e57 with SMTP id ffacd0b85a97d-45ef6a90f4bmr19144874f8f.0.1780386408263; Tue, 02 Jun 2026 00:46:48 -0700 (PDT) Received: from localhost.localdomain ([62.77.90.70]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34a0403sm32524322f8f.6.2026.06.02.00.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 00:46:47 -0700 (PDT) Date: Tue, 2 Jun 2026 09:46:46 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Tao Cui Cc: longman@redhat.com, chenridong@huaweicloud.com, tj@kernel.org, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Tao Cui Subject: Re: [PATCH v2] cgroup/cpuset: Fix update_prstate() always returning 0 on partition errors Message-ID: References: <20260602045521.2381230-1-cui.tao@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c6nksd6npnwlpzzk" Content-Disposition: inline In-Reply-To: <20260602045521.2381230-1-cui.tao@linux.dev> --c6nksd6npnwlpzzk Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v2] cgroup/cpuset: Fix update_prstate() always returning 0 on partition errors MIME-Version: 1.0 Hi. On Tue, Jun 02, 2026 at 12:55:21PM +0800, Tao Cui wrote: > update_prstate() stores the error code in cs->prs_err and transitions > the partition to an invalid state, but always returns 0. The caller > cpuset_partition_write() uses "return retval ?: nbytes", so the write > syscall always appears to succeed from userspace even when the partition > became invalid. > Return -EINVAL when err is set so userspace can detect > the failure immediately. This is quite a visible UAPI change (a write can succeed to invalidate a partition) and users are meant to watch for cpuset.cpus.partition state anyway for asynchronous changes. I'd not change this gratuitously. Michal --c6nksd6npnwlpzzk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCah6KVxsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AjvVgD/a0sQ0ojzfnQ8pMsAB4WK YApLD0myeE5QcV5AUhxmKpwA/1o+JW3f/JiZAF9d9XM2arm7yaOS7PBOfyl+CV5D 6yoJ =cGY4 -----END PGP SIGNATURE----- --c6nksd6npnwlpzzk--