From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F57B3D170C for ; Tue, 2 Jun 2026 09:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780393408; cv=none; b=lZRUmrhAjL2lCPZt/lahF9w5XYE99cRq89GpgpDxR4wNbnsKHUEvv274YUSnZC7ec1oC1iLux7EVzJZLs+aKtynY3jCTpOaeACcIu0fyheaoHVma07JPKtXgcuBElDJYq1yFzERcZY2r8UJepdffdOpLEjHr59wVodwzRWwUQDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780393408; c=relaxed/simple; bh=AssAE9unEyyLck1xZ70mzPSRJ4bKJRVHT4zriyB1tgs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RuNP5wPnMm5wO2HbD9lWHb4jqfJhXl+E8Gldx1ntSrencDf/IZ/Q1Khm+FGmeK/Wig9KcHVplTeurBMXJUTnwdMN+/nB5w8vwAHx6cr48cYx6cWwd8P5wPuyFdgy2yDbN+hVfQP66DgJHAad6jR0hndcGYp2R1vYE7IQG3OLMW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gzXKXxmC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gzXKXxmC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D85081F00893; Tue, 2 Jun 2026 09:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780393406; bh=4bPY4fJ6c9uP07ufSfPcuq2d7wSLvbUz6mUS+a9l00c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=gzXKXxmC3P5o3dySXNAJu+zeZEwj9UBO/v0KTIuNNvh8Ej4STiKcOPOHo0ZIgaFtJ eSrWI4uSeLhxM1n2alt/Ar8C1z7/xaM9r0/pywPQu97dhXsEAPFe/Bk0rRmPEo0Xni tVmqMN38Cwkvb0AsC7BvQ6WtRFeSztNRIT/jSG3VCCLx7waIf5S0KmEIG0ZEyh4gVp hTF+lp3wVJo4EtAMhKuzeeMyMsg868tIE06X7oei5fmb1xG7X2TLm4G4wHg5Nr0vlJ wWbF7NfnuqFTZtnh3VMagiWz4EIKQRz5aijEsLWT+LVzOla4ZZFCWPqtJBOYo29u5B z/1Q3q5IlAgqg== Date: Tue, 2 Jun 2026 10:43:18 +0100 From: Will Deacon To: Rong Xu Cc: Nathan Chancellor , Yabin Cui , Han Shen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Kees Cook , Nicolas Schier , Linus Walleij , Arnd Bergmann , Mathieu Desnoyers , Miguel Ojeda , Peter Zijlstra , Jinjie Ruan , Lukas Bulwahn , linux-kernel@vger.kernel.org, Juergen Gross , Helge Deller , Ryan Roberts , Marc Zyngier , Ard Biesheuvel , Vincent Donnefort , Alice Ryhl , x86@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/2] kconfig: Remove the architecture specific config for Propeller Message-ID: References: <20260527214510.3907973-1-xur@google.com> <20260527214510.3907973-3-xur@google.com> <178010203122.3743687.12531843798236779880.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 01, 2026 at 11:18:27AM -0700, Rong Xu wrote: > On Fri, May 29, 2026 at 5:47 PM Nathan Chancellor wrote: > > On Wed, 27 May 2026 14:45:08 -0700, xur@google.com wrote: > > > diff --git a/arch/Kconfig b/arch/Kconfig > > > index e510c585ea84..e4eaca9c917c 100644 > > > --- a/arch/Kconfig > > > +++ b/arch/Kconfig > > > @@ -879,12 +879,8 @@ config AUTOFDO_CLANG > > > > > > If unsure, say N. > > > > > > -config ARCH_SUPPORTS_PROPELLER_CLANG > > > - bool > > > - > > > config PROPELLER_CLANG > > > bool "Enable Clang's Propeller build" > > > - depends on ARCH_SUPPORTS_PROPELLER_CLANG > > > > It does not look like '' or its predecessor, > > '-fbasic-block-sections=labels', are supported by all architectures? > > This will break allmodconfig for some architectures in that case, so > > this needs to addressed with some other dependency. > > Thanks for catching this. Yes. -fbasic-block-address-map currently > only supports Arm64 and X86_64 as of now. > We thought people would only enable this config if they knew Propeller > was supported on that architecture. > But the allmodconfig build breaks this assumption. I think I have to > keep this config for propeller, and make arm64 opt-in. > > > > > | $ make -skj"$(nproc)" ARCH=arm LLVM=1 mrproper allmodconfig all > > | ... > > | clang: error: unsupported option '-fbasic-block-address-map' for target 'armv6k-unknown-linux-gnueabi' > > | ... > > | > > | $ make -skj"$(nproc)" ARCH=s390 LLVM=1 mrproper allmodconfig all > > | ... > > | clang: error: unsupported option '-fbasic-block-address-map' for target 's390x-unknown-linux-gnu' > > | ... > > > > Maybe something like > > > > depends on CC_IS_CLANG && $(cc-option,-fbasic-block-address-map) > > > > then cleaning up scripts/Makefile.propeller to use it exclusively? > > I think keep ARCH_SUPPORTS_PROPELLER_CLANG is cleaner. I still don't think it has anything to do with the arch. If the compiler supports the option, then we can use it. The arch code in the kernel doesn't need to do anything, right? So can you just check if the compiler accepts the option using a 'depends on $(cc-option, ...)' line? Will