From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65584371041 for ; Tue, 2 Jun 2026 16:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780418320; cv=none; b=c2E5+p/zazJ5YUFWP77tfidWFpekA5BkPAjp7QMYitViRKrwXDPxcpkhUNEryehXSmx7jpfg8sAPWjq7wVAFSMaOdcResnqJqQPWhVJiC9ha9z9LAk4bee6r9IrxxScLKFhUtLg6/+/AaUbu2oUTGZ/h/ii3aAPdaWx7Uv3ku7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780418320; c=relaxed/simple; bh=SqqoX5qQzGE5eNHSgLyrNrWlqXnwPa/uOKYx/N6zAZQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=deeaQWooMoyifU6zYFnBoaZgTuxuBbk9quFSXuyRJPJrbxCnzvYOkjUgOMhh9bAtU0GNERsC1iseBjqaxUqjVM8E5VqiHUi6Eh9dvgSaLRYzfau75oG05RZRL0SbtDG7+OYWjFjvXosjS76uLO3N8MyGZnX+C+OxR4P28ptWXgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Dhp1RuoM; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Dhp1RuoM" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-490b2b037d2so7572835e9.3 for ; Tue, 02 Jun 2026 09:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780418318; x=1781023118; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SqqoX5qQzGE5eNHSgLyrNrWlqXnwPa/uOKYx/N6zAZQ=; b=Dhp1RuoMIgkOz1tIgivCGlzcEfCM/F0TwNwrOlD30SOrPUP9X0pk1jKf45MVZXD2qB Y0U2Vh/tibUVKER8x1Wo8FLqPs+VhIPGR222R58rC2yCrEfGdyQvYBOE+pEfchOdbhkt pU0giNtPmGEguen+ViRMghJUGwIMgKi17GuJksCNJtyfUNChDz/NmidxQjstu3eUEQOs xrFrShXa3Na1mri/KdchGz82zqQrrsxTxWshTVVGcANc39kYo8SSegNQ/J3H84x6x7S4 aphwriiQvgNf31lUKqNreRJvIPavKKUfsDPrxRkdD/3WnNff4c7FXxWQCPyX6HXerUQT PGuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780418318; x=1781023118; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SqqoX5qQzGE5eNHSgLyrNrWlqXnwPa/uOKYx/N6zAZQ=; b=iX3+Jg4ByDrFNx0Y0L3OTDaa4ap810/7SwQrW1vqC719toKQKQ2iwdBSgs4Essow8f nr5ZKtEfwvoqkoqSGLc6+1Y9zCKcqcZCcVnTSVmggEz0y9GYIENz/LpVa89UQTN5PtL0 70gpe8oVDA28GgLGPjkE76vnkK3zPbjQz107lb1PTSrufOw4HJ6Wfl9mypwOcW6ZmI/7 QUydFJk1Y8DthXpXw2LoUorHY1+3FRp8qCcVD042Ous6wR5VgeOs+xV1gVK5igBa0Yr+ cXY8RBdYRdTIc9Df5GCaMQa2QetJ3s0vc5MQtUne9pwcPvq81Sgl3XNHZTKs6G6Gpdl+ FNRg== X-Forwarded-Encrypted: i=1; AFNElJ9zX6oYgKxwSsXZDb8RegeYXKcbpIRLc1PhBgO1wwGRCZ0i4NaHOUowKsxs8mu67eRp9lIq7MwlaUZsBjI=@vger.kernel.org X-Gm-Message-State: AOJu0YzbXVpkbB44rT3NhL5wKtsmyjgzAekk91wrzVgEehzTKbgw/gE/ yaEHyKnQs9f9CIRtqF9rxK2JLxH2yVBdQK+EPn272bdpsCeiLwZodCKw+XC03s2Re14= X-Gm-Gg: Acq92OEUY1nEmUGbNBWSWyW5rbOWPAWnbn/sdz14Ye/GTUFGFdXmouf4c+31SUStx75 mTIzHtiTn2tegSejuvSXG7C4QXd22MfBIthpoT8dH5XRKgUByLIM85VKSBeL3HQJkcKsNAWHSiS AHUQU0rWOvy9ijruxF+XR4qwi06yhdXYS9XFJC6Co5bZNDcordYT8d3sVxsG4cKEl0Ui+YiNOYg I+/zmeE/k6/qDlaGhFMb/6AXv2sN1ZGXVL+H7mGsqZDe3kCSLUFjmZP1M9+pJn/tEqQE219Sb35 9V/NC5SFq9WtrENcsKH/fKVat+ycxxHJ3jR9c4nFXpw+YO5J6am5D1P8khAsyaLzC32kcpCnzi4 ykxUqMQFATDjDaBbWQCUz5xYAxJTOAq4Iyow0TRReGeUqL3MeRIUpzuWfuCmyQorIBb44PFtSIT N0DeV2Ntp7mcySBQhUO7LLOZrlqGtIVnbZJ5v5dl3lb+fOUA== X-Received: by 2002:a05:600c:608e:b0:48f:d1c0:5cd3 with SMTP id 5b1f17b1804b1-490b5065ee5mr8757815e9.13.1780418317804; Tue, 02 Jun 2026 09:38:37 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff23:4410:9db1:6daa:c0a7:d3cf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2e4b18sm407269f8f.10.2026.06.02.09.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 09:38:37 -0700 (PDT) Date: Tue, 2 Jun 2026 18:38:21 +0200 From: Stephan Gerhold To: Bartosz Golaszewski Cc: Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Md Sadre Alam , Dmitry Baryshkov , Manivannan Sadhasivam , Bjorn Andersson , Peter Ujfalusi , Michal Simek , Frank Li , Andy Gross , Neil Armstrong , dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Dmitry Baryshkov , Konrad Dybcio Subject: Re: [PATCH v19 00/14] crypto/dmaengine: qce: introduce BAM locking and use DMA for register I/O Message-ID: References: <20260526-qcom-qce-cmd-descr-v19-0-08472fdcbf4a@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526-qcom-qce-cmd-descr-v19-0-08472fdcbf4a@oss.qualcomm.com> On Tue, May 26, 2026 at 03:10:48PM +0200, Bartosz Golaszewski wrote: > I feel like I fell into the trap of trying to address pre-existing > issues reported by sashiko and in the process provoking more reports so > let this be the last iteration where I do this. Vinod can we get this > queued for v7.2 now and iron out any previously existing problems in > tree? Thanks a lot for working on fixing all these issues! I agree there is no point addressing all the "pre-existing issues" pointed out by Sashiko, but have you looked through the other comments for new issues pointed out for your patches? Out of curiosity, I was looking a bit at the comments for [PATCH v19 06/14] dmaengine: qcom: bam_dma: add support for BAM locking [1]. There are 8 open comments there (Critical: 1, High: 6 and Medium: 1). From a quick look I would say most of these could be valid. The critical one about the usage of dma_cookie_assign() sounds a bit concerning to me, if it is true we would be basically breaking parts of the dmaengine API for consumers by inserting the lock descriptor in front of everything else. [1]: https://sashiko.dev/#/patchset/20260526-qcom-qce-cmd-descr-v19-0-08472fdcbf4a%40oss.qualcomm.com?part=6 Thanks, Stephan