From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E763009D4; Wed, 3 Jun 2026 01:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780448756; cv=none; b=eNSXIyLbvmQ5Cw2AMZ0pwerEBrIqFT/iFbG6c7mfnq2Qv0Vy4b4K6m7kQ7n9SCRAY6x8G5oyQQqsyb8ZgBL8inSNcu2vt5aVZpog35LlJ5FEeXBHhdZMTsTElTJQCTSDctwhyQEBLJQfMfDeWk5thc5BxyVxwywvlN6zG+HvDZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780448756; c=relaxed/simple; bh=i9YGNuNgDpOPBl8d6kjfgs6JfNdl9z8Whc5srrXedg0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OhZO+9fNZzb4ixsXAIkFS1gCHTrq8+uDjTEoKx2Qqc9D4+UuJ11X2YlnUBVHB+W9dHZzWi3uww1+hoYpQX/v15V1LGfzOMbS9p6ZDAHnYBRXGBDrdtR0ZdyPJ5HpYP0S2Q20ik578IVWdm6MtgNqxI3xDE4qFFFLKjSUyeMI4sI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Q0Rqz6lx; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Q0Rqz6lx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780448754; x=1811984754; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=i9YGNuNgDpOPBl8d6kjfgs6JfNdl9z8Whc5srrXedg0=; b=Q0Rqz6lxWkA4FzULvwMuMus3Dmu0prJ77LcP4kJSFPsMsqynoALhetRl wNf7nRsNt5NhP3eoT5z7TuKNR4i+COeBPZ5WqD0sUGC2WjoVXE46TM+Nl 9TsDJkJxGPwhT1SkSHBtyfco99ZCIDqBRVdxEXsiOZ83bd/7ylPO1nboM hlLahaFeNYaE+TkAC03aoGzl1xWwMaq9u8dpDXVtq3Vb8TFYgoGxpeBOP 1RrU0fFab8VeXbY2vlt0o08eIZFfWvptdEbQJ6Z1TXjyKfxj0LDKVhwxK +Q90jzG01ZlH1syHO3ozjhOBpr5xagD4FwIMhMqExibp2ceGHM4dNvYi0 Q==; X-CSE-ConnectionGUID: fHTf1kYtSViu8jzSGuoDXw== X-CSE-MsgGUID: nL395wVJQlWe/S42bp+YsA== X-IronPort-AV: E=McAfee;i="6800,10657,11805"; a="92625154" X-IronPort-AV: E=Sophos;i="6.24,184,1774335600"; d="scan'208";a="92625154" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 18:05:53 -0700 X-CSE-ConnectionGUID: iE1zkginSxCbCQYutHwqRg== X-CSE-MsgGUID: spwj4h5hSqeCYINXm67ZkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,184,1774335600"; d="scan'208";a="241085073" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.116]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 18:05:51 -0700 Date: Wed, 3 Jun 2026 04:05:48 +0300 From: Andy Shevchenko To: Runyu Xiao Cc: jic23@kernel.org, nuno.sa@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, dlechner@baylibre.com, andy@kernel.org, benato.denis96@gmail.com, martin@martingkelly.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn, stable@vger.kernel.org Subject: Re: [PATCH 1/2] iio: imu: adis: add IRQF_NO_THREAD to non-FIFO trigger IRQ Message-ID: References: <20260602091727.2406720-1-runyu.xiao@seu.edu.cn> <20260602091727.2406720-2-runyu.xiao@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260602091727.2406720-2-runyu.xiao@seu.edu.cn> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Jun 02, 2026 at 05:17:26PM +0800, Runyu Xiao wrote: > devm_adis_probe_trigger() registers iio_trigger_generic_data_rdy_poll() > through devm_request_irq() on the non-FIFO path, but it does not add > IRQF_NO_THREAD to the IRQ flags. > > When the kernel is booted with forced IRQ threading, the parent IRQ can > otherwise be threaded by the IRQ core and the subsequent IIO trigger > child IRQ is then dispatched from irq/... thread context instead of > hardirq context. Because iio_trigger_generic_data_rdy_poll() > immediately drives iio_trigger_poll(), this violates the hardirq-only > IIO trigger helper contract and can push downstream trigger consumers > through the wrong execution context. > > Add IRQF_NO_THREAD on top of the existing adis->irq_flag value for the > non-FIFO request_irq() path, while preserving the current trigger > polarity and IRQF_NO_AUTOEN behavior. > Build-tested by compiling adis_trigger.o. > > No ADIS hardware was available for end-to-end runtime testing on this > submission branch. These two paragraphs are unneeded details and can go to the cover letter. ... Code wise IIRC another approach was discussed. But Jonathan may know better. -- With Best Regards, Andy Shevchenko