From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF014332913 for ; Tue, 2 Jun 2026 23:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780444362; cv=none; b=cll80+JbNPC2zkPmFfaxdLJQP8mxKlWwrSK3b6uhKYceo3LnJUxqq/EWD2wVfz0SzqHw7N/AbGu/oeGysmDxAO+lxIrVa2FY14EnVlnPDaQyVnlGGkpWWyt86xWprFz7Ge+iHKGNS3YKMW4O3+2Cp5gEJKC5HmFgh7ETL+NfrU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780444362; c=relaxed/simple; bh=DIOSLPNBW69lrRHH5x5amd/IZx2BHF033Uckz1NfcS8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NZ8uC9yyqx+XOZfZeyq2CD2Clr4y2XmITY3G9qeH6rmDfYnYvY3hZFndcC5Ae8X7zI4QWS3Nj4HG8OUNgs18FhQTr1OMenGBNF+9FOPCxqoZcn5H89xNPlBMaqjTfPjTJCG+rvQs525ZvfBTtz+9RRl+rYL6rlgKnlDLb3z4I2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iEJLZDiq; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iEJLZDiq" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-304f590dd91so4669154eec.0 for ; Tue, 02 Jun 2026 16:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780444361; x=1781049161; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iUBmAXGMJtpetlgRRPvXQnMJB+mGBvoOosal8pF9SxE=; b=iEJLZDiqvccKOE/Q1Ki0SjqZuspJenASKkDnz68A5Oz9r38JlwuhgAvaU44eoj/aZF iEBgguYTC6xwOnJP2bmzbnIJ2zxJxFBhP0BOVvKr4Ag0Hl1gOdWgKPLn54sW0hWYxC87 Lzi4jRfEBlx+QKv1RtTsBPCWALqmJnglB4DMttEC9JFMnb7tr/CUeGV2kZTzaRnnmOrA vYi7Qa9245cbLc7w7vkAOuOp2mTLhsp8aR5MsSVcweTOSM8SxxvhjetLF2tvuywDQ6nG L7xknRtdAPCW4YMNeEmpf+oyrS8mveSM7A4WHOyHxB2ISJ+W7KPW6VHrgXuGfYuf4jDF DN6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780444361; x=1781049161; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iUBmAXGMJtpetlgRRPvXQnMJB+mGBvoOosal8pF9SxE=; b=tQk3ImEc18u4Zvv/sVQeKBjOLSx8/4soojYYTYQ/lXovtdTuLwayti5zXy7ydGKySU OGVoLUdD2mcahyl8RKibYIkldHMxqlU0Ws8qdw62xZuKNsGUTEKC+voFi9XovsUKhswL YBNcNeHbMVagpca54A81hfbVcPW35SxgGIU3ThFF50GYCb3sEA9oDsx/RbvzTW/Z4OHd P7neHPUI2L1kbtsHc9htWMrEbjm3aTL3Zxfm+zFtiEcLT2CAz9GAtKx2fEnJsUtYsXgf AnlPaNTNyhDbW7dDBPiHO0bP7VPq4ejf8Mbnq92gwy2hFyD6sa3cgkszGDh+PFyav7Gl 7+TQ== X-Forwarded-Encrypted: i=1; AFNElJ+mn0GlpOj1XhbXiSpJGb32J1DdPB3Xs2lw4wKQr7mZlFtFriyhYy7nHiE8sNE2dtiU4Q1rIHJ9Pol+oq0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4gXrLJXQiP0jzjDffAAOlStxY8wYrvWJFXdRaTBX9cP6W5WM3 1or551zAK4DZw1Dn6S9YNI69HQvfhrcZu2k0sZC8Yd8c4w5k91Lvn1A9 X-Gm-Gg: Acq92OFO3P/9xQftTJ8nZbcq5352Ukeonwi6H+doJCjIaRqQL/q0pSUb1Yo8FzYSSGh DTbJiguuK0xnPeSyAMGhjjTYKIxohT5Wvvn/4WTeRZT6p/deTKS7C8hY6/70KkFVWOcppiC51nB KkEzPYIxINaaz8snCVpJvFzMLFNxwjMa4JWLrsBvKI/oGu/8rbvwPXXcmaxcx+XKjmqt3363m5W UWlLmI1al7g1o+kGYzObXYeNB2k7XbaBCHpG8pTed1p1b0/bBvnBb6cKgaku9hdk4LDxI8A1RFL dcKU/JOXw78Vq/YV6YV+p5hQtZSQ8zZ1DbNyvDBKKvwOXroH968WRbDwr3prIsbM7gr28eA6tCk qJ47ObEHmWJxGCagIxv32B+uxyt9g2RHDd8P1umXVI3mT2u/41YHLQ5xwDbVsWScmoYFo6bzrfw vWZlJ9+lJqD8Zj8l2DJVuzhUFa4aWj7AX+RFVT2F0X4ekbdh6Bic+GJTp2ezBfHrVfKpKhhKbDu L8= X-Received: by 2002:a05:7300:bc03:b0:304:562c:2338 with SMTP id 5a478bee46e88-3074fa8d4d0mr552498eec.14.1780444360805; Tue, 02 Jun 2026 16:52:40 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:c4f4:520b:1304:b259]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3074dcbe995sm1165076eec.13.2026.06.02.16.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 16:52:40 -0700 (PDT) Date: Tue, 2 Jun 2026 16:52:37 -0700 From: Dmitry Torokhov To: Andy Shevchenko Cc: Rich Felker , John Paul Adrian Glaubitz , Yoshinori Sato , Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , Arnd Bergmann , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 3/5] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons Message-ID: References: <20260520-rsk7203-properties-v2-0-465f3308021b@gmail.com> <20260520-rsk7203-properties-v2-3-465f3308021b@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 03, 2026 at 02:45:34AM +0300, Andy Shevchenko wrote: > On Tue, Jun 02, 2026 at 03:06:14PM -0700, Dmitry Torokhov wrote: > > On Wed, Jun 03, 2026 at 01:02:56AM +0300, Andy Shevchenko wrote: > > > On Wed, May 20, 2026 at 10:13:19PM -0700, Dmitry Torokhov wrote: > > ... > > > > > + for (i = 0; i < ARRAY_SIZE(rsk7203_devices); i++) { > > > > > > for (unsigned int i = 0; i < ARRAY_SIZE(rsk7203_devices); i++) { > > > > > > ...and drop the above definition of i. > > > > Why? I do not see coding style suggesting this. > > Linus Torvalds. Context matters. If you want this to be a universal requirement work on adding this to coding style and to checkpatch. Otherwise declaring loop iterator inside the loop can be beneficial but in many cases it does not really matter and can be left to the code author and the revealing style for the affected code area. Thanks. -- Dmitry