From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4DAF2D877A for ; Fri, 22 May 2026 12:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779452308; cv=none; b=CLwTJU44yzKI/a+wdlOHSQBYKhWW+z5B+J7LtIOW0XkuTgjYDMzwLGlmX9+2DUMe8InycZuzfsYMk1qtSVE/v2lTeRU7w6fn61HPZv2y3OmQcQwU9hEzWLRAUrBj2NHTpiD0auHnaNbKLNK7hoAz9jXdRyfHAY62UyCpaBAjewY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779452308; c=relaxed/simple; bh=8Dawdg5mOtwfyBDYlNq+wPfkEzwWRYJwbLBPUfDYm0U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PQMLzZSnRKyBl1SugMLF6ix5LOA1KZ4Z/UYjlNtdpRCA/msor8C6fGHaMHavdQwMSwdRM7msYN9tWjm54j0jKEBcwpjz5LuOkdp/zof7pCLg1upKs76fXGKddc5U1eCMLFT2fJANiwBRKs2rVmYPrfwh0pMwl6xUOsyZXUMKz3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QXI5kMYZ; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QXI5kMYZ" Date: Fri, 22 May 2026 14:18:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779452302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7ScjPVgAsdJW+wEXrKpRoUOaQ0I9D+qqUd8b/ES6NUY=; b=QXI5kMYZp5a6wrREFTPwq00taIPiLqrhoe+uresI1mP6PT+BBgZ/tgFvI7+BkC86XIPoeW mxASzakHwRpQQswwcp6nVY0IeJCQaaz6Fkh1M7z30qMx7sH9lF4LuR+JjVpfsJyaqSwWBp K1JLjHmr+/RO7kiUqvOu1Am+45fMyZI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Lorenzo Stoakes Cc: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , Kees Cook , Andy Shevchenko , Yury Norov , David Laight , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] vdso: move offset_in_page() from linux/mm.h to vdso/page.h Message-ID: References: <20260521090655.160282-4-thorsten.blum@linux.dev> <20260521090655.160282-5-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Thu, May 21, 2026 at 03:56:19PM +0100, Lorenzo Stoakes wrote: > On Thu, May 21, 2026 at 12:16:00PM +0100, Lorenzo Stoakes wrote: > > On Thu, May 21, 2026 at 11:06:57AM +0200, Thorsten Blum wrote: > > > Move offset_in_page() out of linux/mm.h so users that only need page > > > offset calculations can include the lightweight vdso/page.h header > > > instead of pulling in the large linux/mm.h. > > > > > > Include vdso/page.h from linux/mm.h so existing users of > > > offset_in_page() continue to build. > > > > > > Signed-off-by: Thorsten Blum > > > > LGTM other than dropping the include below (maybe Andrew can do it for > > us?), so: > > > > Reviewed-by: Lorenzo Stoakes > > TBH I'd like to withdraw this at this point. OK > Unless a series can be put forwards that sensibly justifies this, not some > random change somewhere, I'd rather we not take it. Using lib/bitmap-str.c as an example was apparently fine, but since that is being removed, converting lib/string.c instead to use the same idiomatic PAGE_SIZE - offset_in_page() calculation and include a lightweight header is a "random change somewhere"? > Also vdso/page.h is a VDSO-specific header by MAINTAINERS, offset_in_page() is > really an mm thing so that's another reason not to move it. Adding a new header was rejected (ok), but moving offset_in_page() to vdso/page.h was your and David's suggestion, not mine. Let's just drop this series as I don't think this is going anywhere. Thanks, Thorsten