From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2F043BB9F4 for ; Fri, 22 May 2026 14:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779459449; cv=none; b=I7jSfY216wm0k+Bl7xw6RnXnLmT2tgKiz4qIcm2wi39pGiEKH9bqXjWOq/FCafd4mfgz9S++mRYcKyYF3Tb+tN9CQeaaqF+fRVw/cRhcndqgIpDFWMCBi72BnGrik5F1POWnTYYx9vyjpoEu4G25+cxvKMjwMt/ohIKtWMTtuCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779459449; c=relaxed/simple; bh=2IT4bU7zJWIhEAUx5KMcM7p2nf/aXZLIR7rfEpTYgnw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=clqghS5fR98uzSt0GTE3tDA4nKMd6ZlhmaVBB4pvQHUWZJXZCUnELsAj1OwuBnjSlAkBXJ4r5YzZ/guqA+VZLpEvzlZcDU1wrRit+hLw+RP1OFRo+D3YZwLo4czthcvr7FaDbwXAWUkur0nzdAnG+qk1jLYWq9t/I0rFnMqbkh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=eIImTcFT; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="eIImTcFT" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-45297094718so5824420f8f.3 for ; Fri, 22 May 2026 07:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779459441; x=1780064241; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q3AZPvBEFe3lqUHmEjYuLSqF1EqkmBHaAzjNMZgdm2Q=; b=eIImTcFTlAlr9HOQzgXQPUBKfb7ft69d9iss6RXOmKFxsMd1ToaR9DPW4WXvbfBolv JEhqlj24APDnehsYP3wDssxWXZdKd4NI2hpFZLXot+2m827U6XmLrKgr+Qn+Xnas21QM hAV5pU+aDlPo1tXCz/DQSrrB8OhHAU+B9IiH191EloPUlR9FTiVA5i0fQ/dzxDSAKDp7 Th1O+HX2wmzi6oFJnkvyldzOzze8rwyyJvWhIeisEFCSvz5LbzzqPzyKTPCUnH6YoW/m 2I6goD8TsaInZVCPRvte5ikhIonoDmAvK/gTzexhAwRP8NBazkgi8x1/FGl0+EFuo8Ic aqnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779459441; x=1780064241; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q3AZPvBEFe3lqUHmEjYuLSqF1EqkmBHaAzjNMZgdm2Q=; b=cOLdMSp5Ik1L5isr6zlInTQdk8In9YuUZn6Dz6eSqMPNvZ6o+rNb9zXzT1EfWiER6d pnK5AbtBPkvbEgUY2VKO2JNyARkyteQLyjk8L+tkQ6pPB29RhwzmB8wcQi766wBvoozh pgyowgzpPfZ1TXBbdr6InzbZTOLZh7PJgNUUS0EnuhpKhs2paGj4xfm5daYqVS07pKyl CCUU16jtv6g0awbn0OxPFTjwl5RQkvnwvEOyE55hzXqzoe8RuY1hXtUiLgpvbxgMfq+G 9gMf3djqBlF0x2JztC1j7jPTi5n2ChPol7p38iK/hy5ygmm4fUUlF4s0RHQx5SL3atR3 8XNA== X-Forwarded-Encrypted: i=1; AFNElJ8FdpEwa2Aip0nr293O1OIhp0jLDOGPWNrvpV+9XMMlJLEvjL/bzmlti7EObq5f+hNFjydDhEM1gS9wNI4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4ZLAUa3h7qtfC6F2y8fsaR1EG+1I/t8myTgwFXuEaX8DUb7yO Cmhob947OcpYlDWJSmDGdBdSxLriEwnAPDyR5S80981XM2hFGjc9tFzIZBT3mlYpH03nOSNlTaU GoBS4 X-Gm-Gg: Acq92OEZcJeZZ8lI/YyPMINnFYA95hwLtCM3zuDXvgF4H3slb62fGrTWPuiZEF5oSvV m5aGXR2Zwf5oREh1MiRw0ZJ8zNGVqsBe+FpMoAsHr9WWKINuZrkMaiI2/y/uMYfoAs+7L5a02bi hoxLjyWMIb90m0hxcIAwWQisQtPq6SUVlhlV9C7TY7h13Lp4k/girZQmXE/BR9yo1leQj6lrrKO f9OS3fo63/xtTHcXMkx35WvbY4TnjrJmA3ZSEJXDW2c8R/A1kFYp7RHdJaNLnQWh+mxwOHvNeEr DIrgqIPHFhzq1B9BVtSVIru1RkQPIv/6JVa5Ty0ltDfLxidT8BA87n3EuuWDR2J4VeLxp9kfimL hhuPs61CYH1dqWm6EI/2W3WN68X0coiFnM1RCCaqSK6aIslV4RxUnWrA0CcST3zZ19Q6lerwdKz 9vzniw7GJVDtDLzHznDlZ942MLUu0nZ1yM238nPwZ/THt//KIH X-Received: by 2002:a05:6000:1446:b0:43c:f1a5:56f6 with SMTP id ffacd0b85a97d-45eb38df638mr6017569f8f.43.1779459441546; Fri, 22 May 2026 07:17:21 -0700 (PDT) Received: from localhost.localdomain (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6c9f598sm4662287f8f.6.2026.05.22.07.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 07:17:20 -0700 (PDT) Date: Fri, 22 May 2026 16:17:19 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Guopeng Zhang Cc: Shuah Khan , Tejun Heo , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Oscar Salvador , David Hildenbrand , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/cgroup: enable memory controller in hugetlb memcg test Message-ID: References: <20260520093130.490020-1-zhangguopeng@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4ioeyy53bhh73ifv" Content-Disposition: inline In-Reply-To: <20260520093130.490020-1-zhangguopeng@kylinos.cn> --4ioeyy53bhh73ifv Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] selftests/cgroup: enable memory controller in hugetlb memcg test MIME-Version: 1.0 On Wed, May 20, 2026 at 05:31:30PM +0800, Guopeng Zhang wrote: > test_hugetlb_memcg creates a child cgroup and then writes memory.max and > memory.swap.max. When the test is run standalone, the memory controller > may not be enabled in the test root cgroup's subtree_control. >=20 > In that case, the child cgroup is created without the memory control > files, and the test fails during setup before reaching the hugetlb memcg > accounting checks. >=20 > Skip the test when the memory controller is unavailable. Otherwise, enable > it in subtree_control before creating the test cgroup. Makes sense. > Signed-off-by: Guopeng Zhang > --- > Tested with a cgroup namespace where memory is available in > cgroup.controllers but not enabled in cgroup.subtree_control: >=20 > before: test_hugetlb_memcg failed with "fail to set cgroup memory limit" > after: test_hugetlb_memcg passed and cgroup.subtree_control contained = memory >=20 > tools/testing/selftests/cgroup/test_hugetlb_memcg.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Acked-by: Michal Koutn=FD --4ioeyy53bhh73ifv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCahBlahsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+Aj5lgD+KS03JEmXK2JC8snPY5sv PAmo66NuwBsqgnP9kOfQ8ZcA/2IFpR2fC0yXtbS+OysEn2k3bmEuzcNLcjI0lbRg ndEG =yptN -----END PGP SIGNATURE----- --4ioeyy53bhh73ifv--