From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28462352028 for ; Fri, 22 May 2026 20:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779480277; cv=none; b=oysKgVaAL1HrwQTf7knq9XH4FFvgUdC1ZR+wEDimkMX2bvaDVbvmn14zGNEvDLVj9BFbHYQlwauks34qDXTgDChQlhlG5e7rZZvgjHAa0gLn+pnQy08l+ZyarMb1HJ652R1XxEXUYHgqXXIGIGWNfTo7X22xV9MRVua9gPtBqWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779480277; c=relaxed/simple; bh=eXAO725lIkPZbqs9rR5ieyD3MmzXoPrVoEQeXpDklk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ULIQK5/EnggMIXtvatJsYOmp5yq+4EP6yJzQXYP5Q8UPbrNvVkqrsdsf9RPvN+zSqmd+K/juYuBSsu207VXzk1ZLHq9CwpkRl6ocCviW2rzOBT6ZancvseFLwIxbdX7H/9FZ/05w8MytHfarxG75KBfHwBVyeg4Kjcz6NU4a1xU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GLvH8DRc; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GLvH8DRc" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43fe62837baso4617412f8f.3 for ; Fri, 22 May 2026 13:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779480275; x=1780085075; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PLW1g3HpZM2aJI8/CdJpus6sA4AJf8FdzJFCKu9+qJ8=; b=GLvH8DRcGUrpjnaWrCpK6okwSmdUAZ4ig+U5bsfWXcVCVkw9vSNZw7Ijvzj92Mkyxz Gu4sw5/nBFkNsFikhwc90NsO44+ImzDCqQ71swsOykdXLW2YVqcTx76EhvqjxiLmkg9a b27EKhSpB4bo6FSekdXVmCnemkmMeYbJUD+Uw7DTEl+sApg+TVL1Zr7bWQAdYInzImnC EHhUJ/o2BDXIJof+4eDNM1z9vIez0EFGW/m/WpJd7fllV+f9/KJaseeDP/WbcSBxhHqK M6UfdEGtqFp5mj+0uWIiK+XVUZ8dI4g5R47TK3XOxdLT2BJ3jgoofkQcrW5uyj2UeLgN 1gCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779480275; x=1780085075; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PLW1g3HpZM2aJI8/CdJpus6sA4AJf8FdzJFCKu9+qJ8=; b=fm2Nqbaqef91FZBdraDreMNybBxwwEa4j9htawDzR+NbGhc0XqhCktaS2s9T9PGFbB JokfKOwR/3CAHxjCj999ezhnTetcf0cTYNpu0M8BpMrisz81VRI0QloW4rVJrohM3YN9 MvDUdQwYaHonhpnK9aLUewVfqhuumdF1p8vw31wRThZhybGu2/U6hNoD7E9NcWnby61T qWeVs46j1ZWkhzMzCGWsY0Lp4/xwl4cUvMUNk22Hxyp6jfSPOz9CmIjbWT2AMY3YvfCb p7HqKtsdMGuoKiHWPbL79+UmQP+5Ol7Qcl+++VWn/G/7s5HfvY0usHAaOS7w4uVC2VUQ Q7QA== X-Forwarded-Encrypted: i=1; AFNElJ8/PwqI/dU3hAFMOf8nmS//Vw3hITqXmZX3oQVh8c76R0GYUoUzSyqIMMuKNRvKFTpNPgGA+MMXcoYR9BQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwjjbNSVk1m18Xlh42bD80bFknRWv4risTMuzyWlcCuEHnhWoJM 8rv2Amqtnbu+qvGU0uztwwBklU56UeoOvMAy+tMiU9JG2rV76WhvryrK X-Gm-Gg: Acq92OFPSPf9hmrCwQ2uscSbuNOvhx8A+KmYXzMuPv9Kk6BdFbJ8sWATTmo+CezBkoP laJZuqn1UAHSQRfvmXua4bneo0NnPUGNWeozKF42ucv0CPj0MYcONsNUtDhfttGAfiWySXzJNAd zAXUKlh4ZXubYrnpw3g4FPIDpngE+j5Ky8vGnBwJyJigCItlC5XPB1VMpt4bql3t02vMv7GJMhA gm+4moipbSn5T7GSVLnXcze0N/W0xvlD/VjTKPMnamtfvPFAGa8gVpI1ym5DhnG3uwMBIUvaCQs 3Xxnaw0AC7RhKS09oB1arSsEn/Tk637yHHSwCEKpkF3KlsleJ3qJOst4degD1EWGlWkQCddIOFl MNheW3lE+g3tReB5bQzG1Ls9DblBAQW73gq9dx4O7gSldOhrPqh3IS6jviV28gCr3D0tZS2MNOQ B0fRq6i8R7ACXv4jfp X-Received: by 2002:a05:6000:4a09:b0:43d:762e:76c6 with SMTP id ffacd0b85a97d-45eb38a7f6fmr7805984f8f.7.1779480274376; Fri, 22 May 2026 13:04:34 -0700 (PDT) Received: from curiosity ([80.211.22.60]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d4ca0dsm6667879f8f.18.2026.05.22.13.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 13:04:33 -0700 (PDT) Date: Fri, 22 May 2026 23:04:27 +0300 From: Sergey Matyukevich To: Anup Patel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Greg KH , Alexander Shishkin , Ian Rogers , Alexandre Ghiti , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Jiri Olsa , Adrian Hunter , Mayuresh Chitale , Anup Patel , Atish Patra , Andrew Jones , Sunil V L , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mayuresh Chitale Subject: Re: [PATCH v4 07/12] rvtrace: Add trace ramsink driver Message-ID: References: <20260429125135.1983498-1-anup.patel@oss.qualcomm.com> <20260429125135.1983498-8-anup.patel@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260429125135.1983498-8-anup.patel@oss.qualcomm.com> On Wed, Apr 29, 2026 at 06:21:30PM +0530, Anup Patel wrote: > From: Mayuresh Chitale > > Add initial implementation of RISC-V trace ramsink driver. The ramsink > is defined in the RISC-V Trace Control Interface specification. > > Co-developed-by: Anup Patel > Signed-off-by: Anup Patel > Signed-off-by: Mayuresh Chitale > --- > drivers/hwtracing/rvtrace/Kconfig | 9 + > drivers/hwtracing/rvtrace/Makefile | 1 + > drivers/hwtracing/rvtrace/rvtrace-ramsink.c | 338 ++++++++++++++++++++ > 3 files changed, 348 insertions(+) > create mode 100644 drivers/hwtracing/rvtrace/rvtrace-ramsink.c ... > +static int rvtrace_ramsink_probe(struct rvtrace_component *comp) > +{ > + int ret; > + > + ret = rvtrace_ramsink_setup(comp); > + if (ret) > + return dev_err_probe(&comp->dev, ret, "failed to setup ramsink.\n"); > + > + ret = rvtrace_enable_component(comp->pdata); Does it make sense to enable such components (ramsink and encoder) on probe ? IIUC they will be enabled/disabled later in start/stop operations when rvtrace graph is activated e.g. during perf tool work. It looks like reset (primary activation) should be sufficient, and it is already done by the core framework on probing. > + if (ret) > + return dev_err_probe(&comp->dev, ret, "failed to enable ramsink.\n"); > + > + return ret; > +} Regards, Sergey