From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012010.outbound.protection.outlook.com [52.101.43.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36B1337CD35 for ; Fri, 22 May 2026 20:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779483549; cv=fail; b=CJs69dILmSPh6SfrBDe/QpaGRaHlldySzTtn7IWojbxoc+3XdFINIWxTfCK+Fo8tHOs1uWEsS7EFLADIkBgVDB+jod3d7wlDyj30sSg/r1ab6NxSqfI0gkuUimoVyKq6zOkgNQ8LAp4T7EZ0c0yPBnUy8Fd8M6U2aMEQB89K3E4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779483549; c=relaxed/simple; bh=HoYJeEnGpN2qSNNJhpv2Ma0sF3IL+a7k4L7KoSoSlIE=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=X0RQVjMd8rf95QTRfZjU9O6G1cKnWCeHdQFxRA4LwqsbM3T6KoBnLWU+j/hrQaqAUPo+8O2Z+qgEjgIjOrDQs7ZCyhjsBWYUkOMw9RXkp9lQl657n1KwyC3UIYiAQcxejboUlYVY+LqtYnF52+u3rPwKS4RB6wao6wepn+jZpYQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=gLLlMuKv; arc=fail smtp.client-ip=52.101.43.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="gLLlMuKv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JYOIzMIEvgvbp1dzyewAICzgC3frCfl8Qpua6M7Lx49jRpFSF7E+Xwwz45OVQoGBvNzH8jWO+NJpCC3SGP65puhTNtqkRcmYlQDsPQ1xGMqRdpB4czf6FewhEf2ttNQBSkp4oXuk0ux6wI2SFRnTooc+OC9O8eq5KyljI3qpQWt13VmxDpZZ7069L4AyqYlwmbPIeSs5y29fF1iycIFyNXqrb0WrWhPJJ7LPdcYNPHluHrDJZSKiMI4av5lM1wmPj4uBnjSCFBVUdQfRr1bfeG/4LzWgdN2Giu2xTap09l61ILUqTqaHLwdcv1bztVbC7qnfZkF7HLLVMHV+hA1Z4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oUfAofULxob0P5PWcWPx9vmQk3IIkQNdGdrNsElgGHs=; b=TFyPa7ivzCF9l8zWDypcgBYz/qUJ2r99S3Gi25msMjIadk0zpbUIrVfGPit3+Na/gsjYUiK/oD+HM24ZjIMmgExSouz3tZnn2wIsWjSD3ku2b5oFf7xRc0vedodCfLb49mO/rEnhFUIoGFlyCeAoL3xebWDsAL1Ii05AnLfYKmMqQwlbHS0lymL3v+a83yr8aiM3EGISq1IGvNpWR1LRqakJ7vgbGqCxn3dRW6+/59qsXFjhBJaApNoA7FgSw4PMlxAerYMWO5Gs3TU1Gp9DVMTcsagPeDhUCHHjMHJdX9Z8M5AZhq1P3BomIVlsqnmfG3Hxyt7mpaJAQF6e5yQxtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oUfAofULxob0P5PWcWPx9vmQk3IIkQNdGdrNsElgGHs=; b=gLLlMuKvthHWOOdJAWDB8IJzHInqn2pyguIh9lYodr3XSLC2ZAUelPsPsjWjr8ID9PF+mG9UXCihuRVnqtbFJJmru8uCqcVhvDr2bkZA4RkQO2mFFkAfWiacpf3V3f/L2NG7iVgnB2jMymEy5tCeN/38Rf8v6ohVZAoJR6EAIuTKrxL+PQiAxb870OBOPXiIMGX/z2D/6G5rF/bvBZk+B09I5BA3rxkM7QR90qB74RT690eFx3QPWQ4fSdF9uQ5VOsFdRsGto5AtL9qm8rT6XtEa6Tysga1s/E6dFGLxevx96cyLgEiNWymba0ZlnV8Q7KcP6DFueFSlRXKypJoFaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4827.namprd12.prod.outlook.com (2603:10b6:5:1d6::14) by SJ5PPF1394451C7.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::98b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.21; Fri, 22 May 2026 20:59:03 +0000 Received: from DM6PR12MB4827.namprd12.prod.outlook.com ([fe80::6261:3040:864b:159c]) by DM6PR12MB4827.namprd12.prod.outlook.com ([fe80::6261:3040:864b:159c%4]) with mapi id 15.21.0048.016; Fri, 22 May 2026 20:59:03 +0000 Date: Fri, 22 May 2026 22:58:54 +0200 From: Andrea Righi To: Gabriele Monaco Cc: Juri Lelli , Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, jstultz@google.com, soolaugust@gmail.com, suzhidao@xiaomi.com Subject: Re: [PATCH] sched/deadline: Use revised wakeup rule only for running dl_server Message-ID: References: <20260522125833.264145-1-gmonaco@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260522125833.264145-1-gmonaco@redhat.com> X-ClientProxiedBy: MI1PEPF000008C7.ITAP293.PROD.OUTLOOK.COM (2603:10a6:298:1::429) To DM6PR12MB4827.namprd12.prod.outlook.com (2603:10b6:5:1d6::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4827:EE_|SJ5PPF1394451C7:EE_ X-MS-Office365-Filtering-Correlation-Id: 4549544c-9bd4-46a7-e235-08deb844f43d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|18002099003|56012099003|22082099003|11063799006; X-Microsoft-Antispam-Message-Info: 7UvpwCwCk5efrxbU9r80RnQciYeaCZgtmduoaQp5+lXBT/6ddwu5XNzxrhx2uPCcQSEpTojct1kanAEQiHluPFJRtAxoYXP7eXdG7aMMPJPGKmPw4VWQNI2EIZL9FMcehg1J62MUiAahGKxyT/ERwiHXFLCUhxVbR/p13Y3UkAWCADUB5r92KPITmRKeR+6x8yqgSMnUvhE61c5rPeNFAtFeZhfS6sONHdeFq74QHxyYTv5AP9gXqeH12JLc5YURcGLFm+llA3ktGcfEsijbrGFfYDMVfD6+4jwBo8hjigHPk3WvyaqD8aTC8j9dcwpO7+Hob3DNIApMNGidhi4ZB9jUW440rXX/55XTNhM3AX8sWGqZ5bf4SiK99mI8D85CftlglkcswK3yf7dDyR6CQYJES+qA/N0QvMtM+e4uB7Qt5fzB2t44otVd/BPqkEgyC1nJtDPm+4P1gLfs1Aqpc3rcK2cHfTk7bJY+3fGZivVNOcLSNDcwkAwP2vERtnhnJ1fF841ACKG1NC9dgEMVaqqh1TLwX5cMIzq98GKlOe4MozfGecZBs/Nkey1FyocFoSjxkzKUVTio2iifjkxtCWGrAtS5U/sYWdOpYg9YV9bJ1490B4OY1MjMipr3BDWcRlAqP8YEUdsjIazYWJ0YF5KHmSPIMUanAnRJ5GartJB+8ncXPL7fyMxSrMnQM09g X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4827.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(18002099003)(56012099003)(22082099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rfVlj8MlrOULo855L96ayq4cYxqzsqrJchby1qe1GbkldNE/RMWVd6V0z0Ov?= =?us-ascii?Q?zrc1koKJ0XgePv6LWpK8nG7nHMiVERR7wMV7yeiDBgEa8qEth+sp8zEL4pW3?= =?us-ascii?Q?GOhrQN2A6AUSPcKYDk+yv9mRlv8S2lCkBABbH3KebpOW+N/ZSTpYLLMxR24R?= =?us-ascii?Q?1lyqWrjsPsHPizhOsLRQUoYVAm0DVIB7QJ8rylpeN019+1aGKIJKkGzyVdzc?= =?us-ascii?Q?d6ab6lT3P89nXrTx1+4PVCTdYvBLWp+fBRo9Ah5NocSWzaEiRKC8T/hG33J0?= =?us-ascii?Q?6bfkCo4vrXpaTq1jzzLDZkH1d8U0N2RQmEfoxa7cu37xoOD7nfvL+fhYsnLW?= =?us-ascii?Q?arxzEirWs06NLFwOZgWsy2ZnZv4BDfejtFZGsY4/Ol0wEnddkGvtqImVAky6?= =?us-ascii?Q?pzUb+XLFl+VY5pWcq9QjoB+1RYmAlombHwrqhWEoOluvnYGVW9TdN6L43bWb?= =?us-ascii?Q?TVKI/K/oJPG3hK5bWhjIWgfhiAygzc9dis83OL+cJ+wTD5wIQeG5+O1qS47f?= =?us-ascii?Q?6UHHlSomzx9+W8XqIk+0tj74b2zx1cvfo0zbzctJRLcxjzK+O1yW+2d2nBkZ?= =?us-ascii?Q?1v7g0uV5PTQFxk7wPlZcagL/EnTKjzNEfrlS378Xshj+ronxNV2ckguQFRll?= =?us-ascii?Q?iCdGljJBinIaxulzb0Bbz6KUOanhaaxyDoYohVLukwb+Sucg6IPwqmWh2IzA?= =?us-ascii?Q?3htY/Tq+TMsNHhTiWGHN1j56MavRhGZC8VFzFVbMFC9VUNMT4uMkZv0/J++2?= =?us-ascii?Q?h3trG/6ouhror6x/FEpyMvSBg/AUvbodFggd8PthNLwMNvhpCpxpMCfm8Gdx?= =?us-ascii?Q?cGzfbI4cFvCQCHrxQ77SS02EvwiLK4WkZcwRv7neFn5WvxlFxyZ36681snFn?= =?us-ascii?Q?vcz8r0notsMhIQi8jZz2tJq8l7cHq5cuTrrmaougviMbi8DE50s49tLro+/J?= =?us-ascii?Q?GZO5NpUeZT6sfIN8xKFOZ7Z0xgV73V1UhgdNpBLFnjDH6rSZwXOz1tPkzeJX?= =?us-ascii?Q?hlrt36tV6xiZRXmzpchXfiI2JlwpWZi3ghz6/9Hl0zv2W7O1PQmNe9h3gwFp?= =?us-ascii?Q?/Hld+gfIx28T8jvqB4zarCLQcVnTaQB3Pk0pbndJAfWXyzeFWY6J61i49k9K?= =?us-ascii?Q?M73mnS1U8zD6IygP/ErnpVQnlRYpTPTOot9Y2UhIgIRZw3AklKiezfR5imCe?= =?us-ascii?Q?NDRGP8NWZte93KjiJkWh25EO54ZR4KM9rpfGtQgoUeQaPFeWIre472oBxt3p?= =?us-ascii?Q?z01A8pty6O6q9OVpQuyV9EAlPVNEm5FVzBDei9LPMWG0K60gQ2sPOjiitirB?= =?us-ascii?Q?TKNZtCjyrMODJYyzQ32LHrz1q5hoSpFaPJIIWsuKjm8/ieGWQWcMpND+zF0g?= =?us-ascii?Q?emdFR0LdY6fHQOfHWMd/H0XRsDwYZm7bAsRUlQ1vHYiWAt4jxYiI4QLzK1Gx?= =?us-ascii?Q?mCE5phT8TnJEWDZYDn50UdWHR4IUFPqWZ+QlJImYE6OEekCbbszZmZkAFuX4?= =?us-ascii?Q?RLIJeYYrUTab13PrgT/m1SvwB3bKtHRkoEh2jW62TEcZpZH8caf268T9gMfr?= =?us-ascii?Q?jFdl5mTQNOUdRW7kUeDsy5hiftr+fRkZ+xuuNu1CELxWC33ivPNg5cZHG9e/?= =?us-ascii?Q?6sLRwMR6jiGFjze3uMFFaJCNjdF0RFcIlK+ULfziJ1EH9ne46X7aHbEjhVXb?= =?us-ascii?Q?PTNjwvVSbKVipNYIHjY4Z26C+McbVPIJjdiRLldQajqUxT9n?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4549544c-9bd4-46a7-e235-08deb844f43d X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4827.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2026 20:59:03.2347 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qdqQ4wJ9cChgSlojV7BXb+vXMfl2i+Vt+9Ds5HS3L59z/QNxjIneb2Rn3YW//q8uf9uChmqpiOdM7brgHcUeQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF1394451C7 Hi Garbiele, On Fri, May 22, 2026 at 02:58:33PM +0200, Gabriele Monaco wrote: > Commit 14a857056466 ("sched/deadline: Use revised wakeup rule for > dl_server") applies the revised wakeup rule to any server, as a result > servers that are not running (dl_defer_running == 0) and start with a > deadline overflow get enqueued and can boost tasks as if they were > running, invalidating the defer rule and the documented state model. > > Apply the revised wakeup rule only for deferrable servers that are > marked as running. > > Fixes: 14a857056466 ("sched/deadline: Use revised wakeup rule for dl_server") > Signed-off-by: Gabriele Monaco > --- > > Tested with ksched_football on a 16 CPUs machine: no regression (1s for > check in and game over in 10s). > > Apparently the rt_stall sched_ext selftest does fail with tasks not > always getting above 4% (almost always above 3%). But that seems to be > the case also before this change on that machine. Yeah the rt_stall selftest can be a bit flaky sometimes, as long as you get >3% it's all good, maybe we should relax the min threshold a bit. In any case, I tested this and it looks good om my side. Tested-by: Andrea Righi Thanks, -Andrea > > --- > kernel/sched/deadline.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index 7db4c87df83b..e5a7701a8af7 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -1017,7 +1017,8 @@ static void update_dl_entity(struct sched_dl_entity *dl_se) > if (dl_time_before(dl_se->deadline, rq_clock(rq)) || > dl_entity_overflow(dl_se, rq_clock(rq))) { > > - if (unlikely((!dl_is_implicit(dl_se) || dl_se->dl_defer) && > + if (unlikely((!dl_is_implicit(dl_se) || > + (dl_se->dl_defer && dl_se->dl_defer_running)) && > !dl_time_before(dl_se->deadline, rq_clock(rq)) && > !is_dl_boosted(dl_se))) { > update_dl_revised_wakeup(dl_se, rq); > > base-commit: 8bc67e4db64aa72732c474b44ea8622062c903f0 > -- > 2.54.0 >