From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99B05381B1A for ; Sat, 23 May 2026 09:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779529854; cv=none; b=P6H5xSF8rOXHV5V97+Cl2rtiQAK6RxRF0aa05rGrH9zOcjEtJJR1Z9YoBJvU7DpNSOUvKPptbgxFqqH6UUiCSAqE2YCGSrhZ+qmNr0lM0UUI7Pzvrd3pciXIk4CJqmL7MrkbUhnekfTvfi6VfFHXhBGv1cUtqP5lbw53Oz7YTBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779529854; c=relaxed/simple; bh=op/oYI9cujE4qxkGg0xcbWSC937583m70UoKSDY64DE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BVnwC3f14/GTSfSf0msVa0gdAH1P8K7cWe7WRd/YDeEALsqo+VMvWnPKNnpywwTJJYWiJHD9DRKketcpmxv774tdJpBF5iNa+Ycn5t+RPN8g8D+UjZEKvtbDyBRzRACySuO3pzBr1z3ISQDVMh/ZrtDUCyqOoBEKx/a2XLyuXJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QoSkGpJW; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QoSkGpJW" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so84172405e9.0 for ; Sat, 23 May 2026 02:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779529851; x=1780134651; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+8oNBuIRpmD0KT2DdPdxp+0VGy8FUnSVWpa8pcQ3jfU=; b=QoSkGpJWJRCF1OnNPvYLkQSc+EMAz5KbaO3grHLE7wIs0/RyM+NkBskJ7LZMU57Y5k XlCGSecwPX+a+K+d4Tft68Pe/s2bN3mpefE0V7x6DlEwPrzxPughj/r2sildchvhHJv6 qIlsSn4Z0rVKis8rN1avgSWpZgwKCjMCVOVEcOhva7Bcf8EMDlqqv4jFO0VbMiBnqe57 BEubEm//GnFgCgTdG7pDB3iqIoKPoFz3xNetUiGnHUOqkTEJ0HqkGPTX8OGA2YtDibJE ODQ12bS/fn7gAUIkKwY2aPtZa39PPRWQIwUG7lvcjG9NiZ81nSEikPDgDbD4p2JP2u/8 sDLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779529851; x=1780134651; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+8oNBuIRpmD0KT2DdPdxp+0VGy8FUnSVWpa8pcQ3jfU=; b=UnAsdJvqL0p5NDBlMK3uxmrkd/Os3af+jzEsmye73AB96aDVagmszYOSFg2sriwpFR CiPymGEa5wWAXb1wpVcAXfuArvJafHgYC3/0UnZztMvcAEJkovp7sDOHrx14nEtuiKaQ hMKRzIvfCpfxV25hsIykfRtyQml2VIdYsO8MZ2iX0voNx41V68/+/HxVt6hqmtvnLbvi fNe8uGojYjLFk2TbBXYuZcJrF60SOTRHQuuw5EXv3xTA+x3Bumr98u0B5jNJqhB4cvpT voKR0ZknqmDt/uW5KLiBgvTyr+3F7tqAQLHre1D1ZsRQrxA3mWPikCtgtsM6ZS3n6RHx PzOQ== X-Forwarded-Encrypted: i=1; AFNElJ8nbDR67lh0ykdI928Hn60qA8WWnv5h8rQb5wEhSuTaPpDPUhNXBFI3Oiw1qWHQk6gOBf3ZXsgz7KDzcQE=@vger.kernel.org X-Gm-Message-State: AOJu0YyRuUakVnK55M+Kf11AIeiS3R/vG4DjiLydIziWVAVYfn1lUUyx S3EC9kPEdmodz+WAnV9mFs3b/M9cpzKaRrIAg4bGz+emL5a0I5pmhu4C X-Gm-Gg: Acq92OGbjQZr+BlOPMCBRpP90mPjJ1IgagdP2+8o1zGv0s4C2a0DElL3pOc7HBKQfKH n7RqEnHWtwzlK7ky6+RJ7HePo2WPH4lMztLNVJJT86R7i5UDeP0uFAM1WOgEL+5yG94C7aDusQ0 RQV5KbWeMgl/spbM7aeN4WE6aHbSp21b93A++PotMIS4ANe9RrFLEvjBlucHdo8BGDJawXjhtg+ tzQ1ecCQlHJZ4JBIjyRhMryZJsIWhKZ+ZIrPku8q6FY1HRTfJXvhnXV0gW2gGv0JvUlgRHje5nq aygtBW3KFeIH+7OJv8fiVWEsuXYKdZZkDd+fJbKSMJWpWIKWWB2YSUsF4cJJycoHwNmWxec9OkA C3omAqyS54IkYXlZUk04MNHoIFgUM684xM63kD0RiVQlo6Z3O/r/PsDx3TTS3c0WCXq4Amy1pve /KVU8sgyVCWk+L/qKgh1uVKwI= X-Received: by 2002:a05:600c:4fd0:b0:490:3dc7:9778 with SMTP id 5b1f17b1804b1-490426d3f0dmr102086255e9.23.1779529851055; Sat, 23 May 2026 02:50:51 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490428d69a6sm42539355e9.15.2026.05.23.02.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 02:50:50 -0700 (PDT) Date: Sat, 23 May 2026 12:50:47 +0300 From: Dan Carpenter To: Greg Kroah-Hartman Cc: "Alexander A. Klimov" , Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Elise Lennion , "moderated list:GREYBUS SUBSYSTEM" , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH] staging: greybus: audio: expect 0 from kstrtoint(), not 1 Message-ID: References: <20260520180401.539215-1-grandmaster@al2klimov.de> <20260520180401.539215-3-grandmaster@al2klimov.de> <2026052158-willing-dreadful-857b@gregkh> <9caaf426-1912-43e0-949f-fb7bb6bbd1cc@al2klimov.de> <2026052249-shrank-trophy-14ff@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026052249-shrank-trophy-14ff@gregkh> On Fri, May 22, 2026 at 07:07:10AM +0200, Greg Kroah-Hartman wrote: > > total: 1 errors, 0 warnings, 0 checks, 16 lines checked > > > > NOTE: For some of the reported defects, checkpatch may be able to > > mechanically convert to the typical style using --fix or --fix-inplace. > > What about trying --strict? > > Anyway, think about rewriting the check for "== 0" now, that is not > normal kernel style. The checkpatch rules is only for NULL. You're, of course, right that == 0 is bad style here but there are be times where it is idiomatic to check for == 0 or != 0. I only bring this up to promote my blog. https://staticthinking.wordpress.com/2024/02/20/when-to-use-0/ #SEO regards, dan carpenter