From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F96344046 for ; Sat, 23 May 2026 10:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779531795; cv=none; b=B1uoUz92oQsPfItxilQDygYrzF0FMwcaEUyLkSO4xxsmIr0pKREdJWnL/hZ+zunu8CO7AOAC3F763aafcO5Vw4/UOQPHxwNP27SXW4kLitEYqezWrSl0qxec4wO+UN7klvri7+vDp+udrAdSYMzxTG6yNaqWL9+ZDBMPjEEe+ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779531795; c=relaxed/simple; bh=Gd/SjD0Yc+0C5cLmQVDIyRohFZqt3MX20uLcciLoqsk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a65NL636sJO2yiLqAGeQEo21l8+a1cv16x4GVuygp5GhQbLLJsGcZlJY/YUu36P0L/1PWNsmWJTDczftZ1EtPO3YIvIqyXa2SjjtHso5c2wIQRY1uqzFO+GLRUm1f32w5WPsU7qSCphqBqD9ZMm3W3xPV0bySefu+WeTSiPaAZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fqBScCXj; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fqBScCXj" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-45297094718so6347403f8f.3 for ; Sat, 23 May 2026 03:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779531793; x=1780136593; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9OwKYYr3GBn268kHvXc2ShFhOmxklHzPpvQguPHVjME=; b=fqBScCXjQuh31Sihx+57GAYAxpq1gULsApgv85QrKK2PAdnhkTVpo1gPEfAb81L4Fj GD8kq5MtbFpaZS5jfYanCl/xvobsRX/IOMwJ/+E4JMjLkEYaz+/avevuGloqavY5k5kL ztj1dcrELsNQEe2oj19Bf1jISF/UTpkvNel/UXqrFp7MKvhGHb+f7Wd7PiOyWYykYtgB d3GryKFqcCziRXn/unlXo1avk1vvuBJoAQ354xpdG73gSBZvnBMsWDWs74j/4NXrWcVv ttfhZ4Uj21VPij9eKwkKTNg6EEMyRXWAzri6yUR8gkunTVj9LSGKJtMGTG2Tnc61I9oI QDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779531793; x=1780136593; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9OwKYYr3GBn268kHvXc2ShFhOmxklHzPpvQguPHVjME=; b=erYA7OocsVwMevFnlfXoRT8FBg7Kp7CaNxeE2pDk/y4NXPkBb9CrvAR59hJifWy+q5 FkYBE8oo9hU0b3BukT4BQa7fRkmIXAANvxWxBpOKZ9Y21sSewkV6mf72JBaOaxrhpkUD eaAyCxUm/268KMgfuWuAAu73d4w6GDf9QsVCtaAwBzi+lX3HCrUj4k8HOD+Zop0q+i24 QwQIVovVhHdztZosRCp+WRoblp84bABbm0SElk+R39mnJGBiU1rbyKZNHF5/n5TdcjAp QdL7T1KyozIk7lRqRLt3g2wXeDrSyzo1pq766agQjE6GsPEZ7ZidmwGj3hG1Er0wp8vg JFdw== X-Forwarded-Encrypted: i=1; AFNElJ/BgOfDgBNYK+GzIbf/NNS0A2j/SAtHiXmGDVD8FVbolDyH7HyeDGVk3dwjqzJtzUCdYCR8GsRPXinT43A=@vger.kernel.org X-Gm-Message-State: AOJu0YzJKazaiqoO/Fsn639mL7a7PYhnC/fEf2i/U+CVSpMYXHCTM7/d sU7eW0pZckVOpXKwbx72/yWO8BAHUQz5lnhnTmVjP4qLEd8omjknmm3a X-Gm-Gg: Acq92OFcq4r6U0nLgtYnYPYq6VlSoefYwq74lFNDzkg1gcNy9nEF0RGTOn331NC0U5m BM1x2soXRavSQaFEBbUSXmil2VGFVUElIBBYe3/5Usnio/bwvkEZVW3xroXxompiqZYNxhG5+ou 0g6TmW8AqTTI2/g4YnyCXkOkbY6dSk25zjwfkwsW5lUfzChsjRzMFQzmur8tfHBY7MjALVKSL6i 68dEw6LOKn9Fp3JKeJWUAeD3WFPlLt49U9fP5fJNMWCJcA/IyGPzivQbA4K5msx7xoa05N+0lXE E0Jf45M/rntuQxL3HInE9C9UiyORTxcvTLovdMNWnzSWy4R93YId171Tfas6xkhTh7XIC5OsgBQ bBav1byYxAfHjqbwgmC2vGXgYi2IOEpwUxi08xvaEbrMqVLEBRbBm5Beql/JPXgIfiN0WPoncJS 9u1dB0KpCMV1nmnKc9v06CIkM8fuPX9fZFGw== X-Received: by 2002:a05:6000:4917:b0:43d:dd:8ca4 with SMTP id ffacd0b85a97d-45eb36ab5c9mr11788096f8f.14.1779531792574; Sat, 23 May 2026 03:23:12 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6c9de2dsm10729678f8f.4.2026.05.23.03.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 03:23:12 -0700 (PDT) Date: Sat, 23 May 2026 13:23:09 +0300 From: Dan Carpenter To: Ashwin Gundarapu Cc: gregkh , linux-staging , linux-kernel Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary boolean comparisons in rtw_recv.c Message-ID: References: <19e53a283b8.4f2498e045168.7106069608127124839@zohomail.in> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19e53a283b8.4f2498e045168.7106069608127124839@zohomail.in> On Sat, May 23, 2026 at 12:30:20PM +0530, Ashwin Gundarapu wrote: > @@ -1841,8 +1841,7 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un > /* Duplicate entry is found!! Do not insert current entry. */ > /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */ > return false; > - else > - break; > + break; > > } This is a bug. You have to think about what checkpatch says instead of following it blindly. Also it's unrelated to the patch description. regards, dan carpenter