From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEEF125B0AA for ; Sat, 23 May 2026 10:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779532432; cv=none; b=DmBYVaH2LVDYl8tEv+y8StVtZv1M27z8NVsxRZXF2b0QtxCVtVMnTJzaw0LPiiP1Aq+g1E5J0PgqofcKjEL87iyFMVRtEv95ZQihSADwv7fAzRN9oOJFe06wEwAYBBZbi5vDaHZOoRsEi4GQiN5aMDqCc5mxxHYOfNiBcgd9yio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779532432; c=relaxed/simple; bh=VfqTrXbAjfjJW8HSZ+Rpm1GxcODjwd/5op7veBkP0Zk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YRj6JmOfEvXnJTDbX/bsrh/QJiRqL/jBOeYFSwreoIKvXG+yPTWhz5knQCeAJPMYAUkFNPPoqYbL1ya3DKxMXf97cmBOKvvkEoLw/Y8jN0zz4MWxAiqbDmbBywpU4P4ZUB9SZBi9Wiz7dl8WqV27yq/annkicoy0bNkxjz3TAiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gaxXmMiB; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gaxXmMiB" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4903f7a90d1so17364955e9.2 for ; Sat, 23 May 2026 03:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779532428; x=1780137228; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1xMDMv9bGUAtuBW4Pv+wf/h1qTPz3I22UMoRQ9O+Vjg=; b=gaxXmMiBR36iEsuxIIYOIHSBH9ixcgeb9gY8YdhwL0+A3UqYDhOyLS1zINT4ytedN+ YWwWVyBITrs+GZ678Em0XQ+5YlxlVSlyZtyYeIyQ8i+xBFR0oQrIZJVRBQGYkb9VcbZG iGezFs1riIYVGwULaM55GjYhwKIvn1PAYwltTV4k3Ph0g4Tpp8lHSFew8+aTegKT7P92 l7BM+rJFgBp9R4qqG2PufDRC2/zobuBEIoUnVIn8+G8wWqFgCRnk2PLdDkCo+FDd1EBd paqaM1+F+sDQCMxO/U1yjoFWPrkGrTc0C+L/P/lzQSf0M+lgiSKbQffKyE5yL107tqzB MgMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779532428; x=1780137228; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1xMDMv9bGUAtuBW4Pv+wf/h1qTPz3I22UMoRQ9O+Vjg=; b=JTohMV+Ei5542SwKInSi46QlOOTtRGWO3ncEk+4flPAuku/pXWvbXvq+d0xEtr1xKk OxWKVPyKr5wNovvCVCLX4cQ/LK89g5DEPBCP4OrPPUgvaHuRTAOTKKAUK/dBQ4I/Ba8z 3TWDA6Q3yDhqzxan856VIin8qXZXcW0oMTKhv9rfThyPJwUHY7Wmg7u/1k1UtVbccURZ rfdpibuVJibsw5cSoiPzCwa5iF+mJ52A+fvJlRYRXUF26mGjFtUa1d5dVPuUseBiToho PcORK4JnE34rz0MRLE61VhB+p1if4DQuET0I6aPSXkRQ1fl8iB0iTrW8icD2XDX8cUcd hyWg== X-Forwarded-Encrypted: i=1; AFNElJ+i0JfGcQEL/r/GVPEprtxDfqJjdS6IQCyoAGyyzyoCq+WfQh/Dj5qrjwKcJhI+qUVP4W5BRpBKbqJ6wuo=@vger.kernel.org X-Gm-Message-State: AOJu0YzlLR4PDfrIAQBFe3soD3pduuTksQHacdEyp3jQpMi0bHU1L1pD 3X9gKcxnLEu/xsSmQiWX7bi26TIz8wrDe7Wy2JLun5mPyG8g7stu5GCM X-Gm-Gg: Acq92OG+Mxo8q4U/og9GaZNUnM8bKFml8SyMmhIBiMPtYKsGg4C7zL42DxNpd22Qr1H Iei5DmVeJNw2SaoM0OjQTcXxmo0y8iDSV5Bui39qAoAvCSuy9AWFbeW2E82+TZaGdFOancf7ZsD MAbvADRlAU9CKbWmskoI8o6xd0H2Y/fBzvtVHxJkerLMPW6SYbqWls677aOAkpVoklqYW4d2VIl xQuch+1L0qw4Ox3bl1hr7Yh9IMxi1Z352+O1tAqaxU+E4hB8tzepOoNo06HBrXYH419yOg+W/7Q hJAY2JGxaLHFkG3xnSa/fsLxZis7btsSYmV7p90NElWzdZfSoClypLUUUJ0oebyWdxepj4yqc69 YG9N8+qWpV+UOiBJ9IseI4aA6OSyujLN4S8kcHN0AukM0oTLVX/Eq5yUtm32TisTQSxTWwsCsgM /u7oe1H8vk8fTmW6i5ELIktCQ= X-Received: by 2002:a05:600c:5298:b0:48f:e230:1d12 with SMTP id 5b1f17b1804b1-490428dd63emr112065035e9.31.1779532428123; Sat, 23 May 2026 03:33:48 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49045282201sm118985305e9.8.2026.05.23.03.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 03:33:47 -0700 (PDT) Date: Sat, 23 May 2026 13:33:44 +0300 From: Dan Carpenter To: "Alexander A. Klimov" Cc: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Elise Lennion , "moderated list:GREYBUS SUBSYSTEM" , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH v2] staging: greybus: audio: expect 0 from kstrtoint(), not 1 Message-ID: References: <20260522055344.38733-1-grandmaster@al2klimov.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260522055344.38733-1-grandmaster@al2klimov.de> On Fri, May 22, 2026 at 07:53:43AM +0200, Alexander A. Klimov wrote: > kstrtoint() returns "0 on success, -ERANGE on overflow > and -EINVAL on parsing error". In contrast, > manager_sysfs_remove_store() and manager_sysfs_dump_store() > checked for 1 which always failed the operation. I fixed this. > > Fixes: f9a21a3f4919 ("staging: greybus: audio_manager_sysfs: Replace sscanf with kstrto* to single variable conversion.") > Signed-off-by: Alexander A. Klimov > --- > v2: style (X,!X instead of X!=0,X==0) > > drivers/staging/greybus/audio_manager_sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c > index fcd518f9540c..581791d566e3 100644 > --- a/drivers/staging/greybus/audio_manager_sysfs.c > +++ b/drivers/staging/greybus/audio_manager_sysfs.c > @@ -44,7 +44,7 @@ static ssize_t manager_sysfs_remove_store(struct kobject *kobj, > > int num = kstrtoint(buf, 10, &id); > > - if (num != 1) > + if (num) > return -EINVAL; Really num is the wrong name. It should be ret. Also the declaration should be at the start of the function... :/ regards, dan carpenter