From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94523A962C for ; Mon, 25 May 2026 06:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779691740; cv=none; b=cnDdL+ktEJTcUFRPLaF9U7Q979xBraA8iAk3HjL9TK2Wdk6mtDjZ0blfVPhmQU/fscPIC40MLvMiTuPJQoc8buBehSr8spqKs88ba6xUknyNygNrjIgnEDkPLywulkH+LPKTA8ZEmLvkXijtcEVuasaMWfvq8SWWAHB5s125/EM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779691740; c=relaxed/simple; bh=HHq1QSUjs056PH7cjgywIQWfnmXGzYoIPUUqf5zLQDY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kxFKXzZiulrR/gFK6OJcdtEBxSVyHcHjfgRBycqF9O7xU1wfzrlkxTxm47EjuY7DdB0m/MXcyotKwEVoIakPw4vZQ9QKj1jGgECLMSM5NI/M7AJK1LprlDbKkGuuP07gc/qh1YapJweXLsAKNq0aKxksM7oMA5gLmHt2SpHJJZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bv9s4iD/; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bv9s4iD/" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43d75312379so7719682f8f.1 for ; Sun, 24 May 2026 23:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779691735; x=1780296535; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Sg9BVrSj6Dzn6qLL6Tv6JbsRCCZ5e73XFV6/+LT3Rzo=; b=Bv9s4iD/T334Im3+AtlTWc+2WdIkFX6SkUqy7u0fis8NjHXu5adZKZPTIaysdIYSaK 5ftoLmc4jeTJ/SD5s8fMx0f5Lm34KDMhwkfBPX7JbH0RfBni6qe2CyiTjlA9kDDvrQY5 jEOZddjGnV5M0Jqgq6gduWT3G5WnCXTKRBddssCl0gk6K3e449KZmWIlTlLu/G4mLKoc zoFT5Eqpy+Dl7F7PTRlO6GVTuyRQgiEHxCRUv7RQ1Who6fmi2SHlun/1sJ9CZBAgQk8G 3IUVCF0KpWzQrr2/rIJrkTxcFtXjVyWtBT1f+EFzgxdGw8N6c5JwzpeeQbHkRUefgnFw NW1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779691735; x=1780296535; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sg9BVrSj6Dzn6qLL6Tv6JbsRCCZ5e73XFV6/+LT3Rzo=; b=RQxl7HzYOplNZzyUkuFY0s9lHJnnEgs+hiqxuBwGXRHcfGEqakJ36fR4J5U/eubkA+ 5D9oYSLdb55Su2VBE+lnXOtD3PlXcyW/Cjr0zDRXsf3n9TfBHBucBBdayrgsm8DQASza TryLeFiEpyBmsMk1dOQnCKRA0oKXt+Yllb+ynG4/gHMe36sR4qTd+t/t0S1C5ipvBmMC lYGZ41z4leDB9ubEPmzrPU0EBWYpTWM1Ouw3x3j62OzqKwO1747a+hGemUXfgOKGbHpx GDxDZAHYg1TM1y3zbSSTpdR79rKLNhEdPJSaiGo9/+K4pmg4tXE6TEYLFl3x+7qDTplV RnQg== X-Forwarded-Encrypted: i=1; AFNElJ926uut6XY388ei5159+nMJRWcDscwfl/jAc+Ww0MZDVasaQRGUrwisMyn8FYIQ+yxvPtYAsJeHM00MLQg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzlu748qNc6hOwSCqhSLpp+sHB/0lMwnEaXuBEqh1FZvr2kfKtS 7lmwakiZyiWYkbuqWF4LkcKFFBr9zuG0jM5SpQ8JEG6ABQ5e9YjY/Iew X-Gm-Gg: Acq92OFL09ylay9A5wHvm2U6VVenfU4fR16PL7hRTk8ScuudiDeSl9QyMkdiD8/okvF RquPJ4vQZkPcz4i4yPBypq7C6kHT07IY0Y0fs4iJecwgtLNQ3/J6znBc5CAYZE/P5NXfUeaDVMC yUvAK/JjGj5SHdjhl0/RgTWDPPfVMLKUZGRNDz19fAikQqtMt4421KpS153J0m4qPy1IF/KrPx7 m8P4BZHUUTl+dvws8u5JpY+0TQJ85meO/E7pe7hhJERM4I/NyqOJhTvFlKkmYHK6KW15BNS/S+N 1MhZYYxx5WFy6JEQQLqmehRlHRvgg9JSJp63cxOFz4oQSpSI4ihQgw5/t3lB4e7C0h//FpQqgw3 YFdZTZePx7CcrOKPIqd+xdx25XSyDpMEPr38elC/MnlP3Bc2ox3cPs/+1r9e0GYVmPubaD0p/ZQ 7pbaK8x2eBjIcLN3I1eadp3fd6PWwCVmQqKQ== X-Received: by 2002:a05:6000:1a85:b0:45b:d872:592d with SMTP id ffacd0b85a97d-45eb3123c54mr19243503f8f.10.1779691734991; Sun, 24 May 2026 23:48:54 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6c9f6ffsm24971846f8f.1.2026.05.24.23.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 23:48:54 -0700 (PDT) Date: Mon, 25 May 2026 09:48:51 +0300 From: Dan Carpenter To: Igor Putko Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces and fix indentation in HalPhyRf.c Message-ID: References: <20260524175247.5229-1-igorpetindev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260524175247.5229-1-igorpetindev@gmail.com> On Sun, May 24, 2026 at 08:52:47PM +0300, Igor Putko wrote: > Fixed braces around single statement blocks and corrected indentation > to follow the Linux kernel coding style. You're going to need to split this into multiple patches. > @@ -230,14 +229,11 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter) > /* else if (pDM_Odm->RFCalibrateInfo.CCK_index < 0) */ > /* pDM_Odm->RFCalibrateInfo.CCK_index = 0; */ > } else { > - for (p = RF_PATH_A; p < c.RfPathCount; p++) > - pDM_Odm->RFCalibrateInfo.PowerIndexOffset[p] = 0; > + for (p = RF_PATH_A; p < c.RfPathCount; p++) > + pDM_Odm->RFCalibrateInfo.PowerIndexOffset[p] = 0; > } > > /* Print Swing base & current */ > - for (p = RF_PATH_A; p < c.RfPathCount; p++) { > - } > - The comment makes no sense now. > if ( > (pDM_Odm->RFCalibrateInfo.PowerIndexOffset[RF_PATH_A] != 0 || > pDM_Odm->RFCalibrateInfo.PowerIndexOffset[RF_PATH_B] != 0) && regards, dan carpenter