From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0021277C81 for ; Mon, 25 May 2026 17:10:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779729019; cv=none; b=dgWdmaDJGGGg59AoQYQYRSVB7kVg7S+85cMg6XTx9GrdpDpIpuA78tCpCkD4H0GYe6XQcbFzpAomxyRvpKltgWRorUKXSNlw64i2f4SZEOMHSLH7NF0HmesDY4HjBrx+kk4WDQPSNT+h32j4/iyNhHsC0EYa4R1Ic8sqtT0Knes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779729019; c=relaxed/simple; bh=JnPOJPZfRdwSAliep22mo5kntmjxFbCP7TGhEvqfAfs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fvAD98oMPHFoKlI23NsRVt3uRKdOp+zhc2yIQEDjYs6kX2JlhXPITc9aQeytD0HE6AhsMbi9qZ9HdUws68EzHO+NCHB3dgZ/Mp4GKxd7b/nfKssbDr0JVHKnkVqZ8j84TISpphb1FGmSXwCCb6KLlRYbPi3rjFdgeljtRzyOLHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GiP9hJTq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GiP9hJTq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7976B1F0155D; Mon, 25 May 2026 17:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779729015; bh=DZaQ+QowX0C8gRVWN1yv5DhtG5U/Mg2xarM9pU/7iWk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GiP9hJTqjMH2adM0ONX5oIwwpXnd6BF9MvgXhQBNMAl7X3kWDwmw7Iv4kMmggikRq nBqNPSvSUbp/u1YDnraMMzc2Sh/Osc6eLDC7h64gYmz4kaKH8XJE94fh8f49381r4d Q9vZ1zpMEq+Yd7ouvXHGlcDwaPkoV2UNygDW0KvJlEyVzeugFcnImi0qdHpzm8aIFN 1y4FJMxWw2SATyOvoT8cyZECWGQ3kD2+Ni2EhmlAXPXtDxb/iVRRKnKXGA83g9QKzz +NeD+E09qdCKYj2LiW6gvpZVcrQWEW/Ow77g1UcLED7dHYmEbkAwg3DtTbpvtvX5Ys TeKiRmjRDug+w== Date: Mon, 25 May 2026 19:10:05 +0200 From: "Oscar Salvador (SUSE)" To: Muchun Song Cc: Andrew Morton , David Hildenbrand , Muchun Song , Oscar Salvador , Michael Ellerman , Madhavan Srinivasan , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Nicholas Piggin , Christophe Leroy , Ackerley Tng , Frank van der Linden , aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/69] mm/mm_init: Remove set_pageblock_order() call from sparse_init() Message-ID: References: <20260513130542.35604-1-songmuchun@bytedance.com> <20260513130542.35604-11-songmuchun@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513130542.35604-11-songmuchun@bytedance.com> On Wed, May 13, 2026 at 09:04:38PM +0800, Muchun Song wrote: > free_area_init() already sets pageblock_order before sparse_init() runs > for CONFIG_HUGETLB_PAGE_SIZE_VARIABLE, so sparse_init() does not need to > call set_pageblock_order() again. > > With that call removed, set_pageblock_order() is only used in mm/mm_init.c. > Make it static. > > Reviewed-by: Mike Rapoport (Microsoft) > Signed-off-by: Muchun Song Reviewed-by: Oscar Salvador (SUSE) -- Oscar Salvador SUSE Labs