From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B5A13EA972 for ; Tue, 26 May 2026 12:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779796812; cv=none; b=WPBwI3U4JA3OKHDMj9cGW1xMa+EGiOnDkXO+vaCxJqpX2SER0PonGauvHZqyAsU8Vd+cAptQWoaMw+8S4O1QieiYmDaElymrZo2KA75XZ9VQS/Oe2GzFZdYZrLbjHqqdDFw+VMQHxuMGgel5vFbe8MQ8qKLdN4NLq8J5thXbqdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779796812; c=relaxed/simple; bh=hTZYyqvqtGqppwXg4HP3xZpz+TZopttkYVxm+x/q8Jw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g7Vj3tufJ9/Bq9NVE90s0O095PuHnk26gs9KwG54NyjYTuqXawYboUIFJa0AJKTfn83/aJ0WyFkSvo7n4b2ykfO1cUyE+uc3pYNgqIbCuMwH2RdPdtSIniKVycbWYHguB6NYaAzVG2KjV3PtqJcFd6jxU9bN/0xicWDVcw6rDCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pHwwspWc; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pHwwspWc" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-bd8f6ef4ba6so1564962166b.3 for ; Tue, 26 May 2026 05:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779796805; x=1780401605; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CoKLuje7HUGv4pGCvIBQiUOeF+gz3p4jM4FxO+bIdX0=; b=pHwwspWcu5HViVH9PrTg3VZGKAXTnNGteSs54531z1yqAvoQ9iBT7CEw4t9D0baKUH byMt2zeqQnIntjhhwu20JIzFZbDq9LEAweNjSM/QJ+ooJMiyVZM+4a1VFYcCW3lUrfkm e+pPq1JQ46/j0lw0YAKPCxdvoLZFK2ixC8DBCGhSSXq5YXwYfElqzUSc/uNEZQpzVYeQ wpTxmiHgcLyVfyrHBh4ID7utw8G10oFWuFzl3TYMXdPnb8nSgtmebQ+/E1R9DXQ+hpO8 JiaYJ2R/MmMxrJlu5caCZgP1L7gh2ei9wZmnkuPZZMArcD2gYwFM+3qbAj6//UKppe7/ Askg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779796805; x=1780401605; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CoKLuje7HUGv4pGCvIBQiUOeF+gz3p4jM4FxO+bIdX0=; b=Z8NFqnQG5mj03BpiLXGwuP9F9qQolvaYxo9XI9k7YxwMKlZrPa+ey1PjXtEVtRfUm3 P0ALrCCZOuNj2TimY8NqgwmLgJ/eJt9aI+BU2ZXpwOI0oSHUNx40JRI+0PIBgD4Q6pxI Exp42nrr+EyUpiPnbCX0Ippua+oOoTAkwSTFuuw62kZqZp0yjlxSaaEVW2XKW/19CxYq s70y+GUL8CDC8EMQXr8LjKtHnia7Wiv7tQPcW2X1KRbMIdVfx2NTiSmWnKJ+g6H5HPtB +AQ8hxDt593UkxOWiBJ/oDIQ2ygsBon2wVJO6nH2vJCoUNxGsdCPYzyOWGe/FXhOLwKx ES3A== X-Forwarded-Encrypted: i=1; AFNElJ8gcT9A0RX8CUZf4yspwxiFIBpyfMEix6zXJE1c9Nd8EFm2BBjJ+TYntH7gwCD1KVXTAChwn7nXBdSvHGk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7lX5t01X22NNJce/tZ6M2FdV0RWtBzyYzVNuRezB73Eou5ptU Xi8x/yG/mxnBJYWzOEozr8BDme/NfNgiINv72V2k9N1zJkpBDD94Gpc+2nQ0G9cuKqk= X-Gm-Gg: Acq92OFydjSEjNcPOaFatLURsPktLFKrfF9RhHg1cEgtMyn1cLFILRQKZ6qZ2UEpaLU X0edySMTNw0X9kF08mXwcCaaUcKfq9EHlWBewjc1aD3iPmvfyDqfQYCyepIK0WucKyY5cXN6aT5 tpBhp/JawLvs4sq5MBaW1EATyt7U52Egufg+5IfMkIxVOhUnpKnOTVODONO48A7K5/53cCClhQF E9pZMY7aBP1ZwkJalKZx8G72QeSzu7Q4rXI17afRHK7Gd9MUEd6w1+G64J6bHqGfKQ3HSQlDGV7 wsAkyjclISjonH0DY/C1bepMMIh8fm5Xcd4I2RAq5CNjzFCvdpbw+3LTNVVgPBKe0WbpM9yuMku NVhVaIpnx30tl67QuAp8p3xOr1j0aCge2gZcN1596Hg1ZnO///EsCGwtb4vrj41hoCe1VSwE27M wilGDavY9eJsP94j4fAdC3azUetC72 X-Received: by 2002:a17:907:a80c:b0:bd5:ec9:e063 with SMTP id a640c23a62f3a-bdd267cae6cmr1071905766b.49.1779796804514; Tue, 26 May 2026 05:00:04 -0700 (PDT) Received: from linaro.org ([77.64.147.108]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc61de4c4sm497740166b.42.2026.05.26.05.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 05:00:04 -0700 (PDT) Date: Tue, 26 May 2026 13:59:59 +0200 From: Stephan Gerhold To: Maulik Shah Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Linus Walleij , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad Subject: Re: [PATCH v2 0/8] x1e80100: Enable PDC wake GPIOs and deepest idle state Message-ID: References: <20260526-hamoa_pdc-v2-0-f6857af1ce91@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526-hamoa_pdc-v2-0-f6857af1ce91@oss.qualcomm.com> On Tue, May 26, 2026 at 04:24:36PM +0530, Maulik Shah wrote: > There are two modes PDC irqchip can work in > - pass through mode > - secondary controller mode > > Secondary mode is supported depending on SoC using PDC HW Version v3.0 > or higher. > > +------------------------------------------------------------------------+ > | SoC | SM8350, SM8450 | SM8550, Hamoa | SM8650, SM8750 | > |----------------------------------------------------------- ------------| > | Version | v2.7 | v3.0 | v3.2 | > |------------------------------------------------------------------------| > | Pass through | Yes | Yes | Yes | > |------------------------------------------------------------------------| > | Secondary | No | Yes | Yes | > +------------------------------------------------------------------------+ > > All PDC irqchip supports pass through mode in which both Direct SPIs and > GPIO IRQs (as SPIs) are sent to GIC without latching at PDC, PDC only does > inversion when needed for falling edge to rising edge or level low to level > high, as the GIC do not support falling edge/level low interrupts. > > Newer PDCs (v3.0 onwards) also support additional secondary controller mode > where PDC latches GPIO IRQs and sends to GIC as level type IRQ. Direct SPIs > still works same as pass through mode without latching at PDC even in > secondary controller mode. > > All the SoCs defaulted to pass through mode with the exception of some x1e. > > x1e PDC may be set to secondary controller mode for builds on CRD boards > whereas it may be set to pass through mode for IoT-EVK boards. The mode > configuration is done in firmware and initially shipped windows firmware > did not have SCM interface to read or modify the PDC configuration. > Later only write access is opened up for non secure world. > > Using the write access available add changes to modify the PDC mode to > pass through mode via SCM write. When the write fails (on older firmware) > assume to work in secondary mode. > > As the deepest idle state as the PDC can now wake up SoC from GPIOs and > revert commit 602cb14e310a ("pinctrl: qcom: x1e80100: Bypass PDC wakeup > parent for now"). > > The series has been tested on x1e80100 CRD with both old and new firmware > and also on kaanapali. > Tested how? I recommend testing with the tlmm-test module Bjorn added, in all supported configurations, to make sure you don't introduce regressions for one of them. It would be also good to provide the test results here in the cover letter. Thanks, Stephan