From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 674E63F65EE for ; Tue, 26 May 2026 13:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779802162; cv=none; b=C88+p96q8sYBrG3ATr4Zlh9grMBa3Tm1nkoQOsZrLxCbk/8z34Yt9geFKFPukfUQo/apF3KmSfxmSy85q0eUcSKaPm4A8F/Anhp7e5L5WiiFjv6WdaTW34Q+mgB3In3224h6HtTLLL/k6O17Ni1CGQsHghHJsbEAtfExhK4/hOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779802162; c=relaxed/simple; bh=a3Ad0XJlIHX5RtWby+b2O9m9DTbL8t/LUh+au+p0U/Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oCDL2LBexWGYyhIsB/rVqW5xbTp/bC3rOCTywAxCCpCXfxB83BQmb4Ept0YYYsGMFPKbAMAK8U2fTmF6VWmlc8Kj7f4FrX7sQ2p/njzNBZ5wEQUlthvFOuy97cFmEuCgZmejpnDPE+Zg4JBLeMibHo31do9d1KsJ3TkEsi0nXCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b=WOIuSAhE; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b="WOIuSAhE" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4903974854dso44152035e9.3 for ; Tue, 26 May 2026 06:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1779802160; x=1780406960; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a3Ad0XJlIHX5RtWby+b2O9m9DTbL8t/LUh+au+p0U/Y=; b=WOIuSAhE4PNSk4YeCGpjoG5cohDtKnOYsTg3d26snRl9e48Ve6Lx1LmKvTC6QmpyTy AfeCBPLEbgc9IXnn+7/7ZkFGRa9+RRxL2gsryVia+yZfpfhbkpGBAKg1FASv7wsybBGW VCRfaKDZkhidZ+S0PTDHtZGl3Jf/NTMf4vJ1JRBjezZwEz78fF6G43KRUg73/ZR94drT dw5Vail5Yn2wW5jv+2Bw1MuFd2cbC9rSTapt7SMV0UsIHb/CBioKed6C09EOouSNx2cO 0a807z48sx8K5OTp10PFZ+BZjW+JUBTz3c9U3V1TjHob/cgfR0SR0OUcAngutwNpyrqz zLhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779802160; x=1780406960; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a3Ad0XJlIHX5RtWby+b2O9m9DTbL8t/LUh+au+p0U/Y=; b=YZE1BNm21pJg22Ty7bCAWpPyPIjMS9LekLohstTsBMN+D6WeZaMUeCjdS+0Ddm0ddo +TYnVfVtQD05/uXS4erBJLPzj6vLn1V8cpaXrvlO5rCoShW4/3ileDlV72sgH3bzxzT5 PQGOWdgbOH0FvXYYsrzTfOYS8Gm7XqSllbGrnNpKy6POriVhaRbPfgsrXWqUeKnERbz1 Awck4ZaHaHfP2TnmJB+Ijn++2tSiVh6Zj/3mR52hRpX5LLtb9j5qfaADzfIXmC7XEhbj MV4xtQiV9AXg2XZ0bfED5t1frvVfLMEcb2Z+zeQRGcDYRp/nHE1BkdJ3cnSU6O7DtYgT SS+w== X-Forwarded-Encrypted: i=1; AFNElJ9aCkZb9emezILnOVTSuFtd+8d+da//0SNBqr/zwVMujY51+zMGqExC/0wzC/NZH9oYcLrWvKdK0GL8R7c=@vger.kernel.org X-Gm-Message-State: AOJu0YysLO87qLASk16AVMnwyBZ9UGVltTQoTi+Qq9E7BnyYq5nOMsOV t8YKmIv+MK+TT6fJb9eywdXJjSTGAJI6uBsWrCib0VeP7hPhGDYRkmDbWDa5m1SxhQg= X-Gm-Gg: Acq92OH7Cf9+yHyrqmJvR2JO376lnDQqEMXauNEKs7MB8PMnZ4nUxu65ChCykjQOt4k NQcUDKR+0RAR8eR9RRDeFsS6H6xUB4h1iAbzCskYVNwW9GhS0/eUVdwNHAly5SOrCkKtHki+M+j Agn6cdqgu8kJDH7EhLtwWi6VlP5QwZCAKi+xZGsbXzuEhNn/qWEIo1uzEhu6FNpEsgf7vNc6NHH yqn1rJJ0JFSQbfxU8+5Gye275ZaHG4lcj169hq7v80zsvxA/2s78JKBT68YRUL9gOdr2/uddy5O ebQnuyaaKz0bKFRemVoI9MaNnhEFuyf6LjTh+xuktJ07YO+HFyOSabhfWqMj4TKCAW2pQnxDNtd I8bUZPsfcW+FBkxDKEsCPIMc7d0t+a5Me/b0fpgWPgFBCgyZcVAaNIo+Z8gzrws47G7ukFpmP7H Xtd8f33L6XxjKGyGdjxy7+g5ZvLxY5Y5Iw X-Received: by 2002:a05:600c:a106:b0:48e:635a:18d2 with SMTP id 5b1f17b1804b1-490424a0d41mr204824095e9.2.1779802159514; Tue, 26 May 2026 06:29:19 -0700 (PDT) Received: from localhost ([140.209.217.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490428d698fsm108777035e9.19.2026.05.26.06.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 06:29:19 -0700 (PDT) Date: Tue, 26 May 2026 15:29:15 +0200 From: Jiri Pirko To: Ivan Vecera Cc: netdev@vger.kernel.org, Vadim Fedorenko , Arkadiusz Kubalewski , Prathosh Satish , Jakub Kicinski , Petr Oros , linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/3] dpll: export __dpll_device_change_ntf() for use under dpll_lock Message-ID: References: <20260526074525.1451008-1-ivecera@redhat.com> <20260526074525.1451008-2-ivecera@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526074525.1451008-2-ivecera@redhat.com> Tue, May 26, 2026 at 09:45:23AM +0200, ivecera@redhat.com wrote: >Export __dpll_device_change_ntf() so that drivers can send device >change notifications from within device callbacks, which are already >called under dpll_lock. Using dpll_device_change_ntf() in that >context would deadlock. > >Add lockdep_assert_held() to catch misuse without the lock held. > >Signed-off-by: Ivan Vecera Reviewed-by: Jiri Pirko