From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8A23A7F40 for ; Tue, 26 May 2026 13:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779803227; cv=none; b=NDMVdekfJOy9ptERmdwy83/95nW5Hxijc1FWsO2Rsa+c7HT4nf08xgjXx5dB10AOAdx1mNvZgvn1G9SzzIM1HOqeCByZk/RZqOecDkOJiml681WEj3nAhdzhyyZEbLnqO2TKM7pYs5jXE1S2I5GMSHhYiEv7BxeIAEEGEGztGAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779803227; c=relaxed/simple; bh=BT2lrWCRDCHBnnIy+FR4xJPlcLNpkxmZkr2pahuNRJc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EkjqehSNOWGgZuhCB6B44tFDKEKgPFbZcMblBH37JXtcuxKm+26VUeDRBdpkP7BCjMBdwB/Rg04My6m5GDIiZW1DB8JA4az3wYl1BFFj0KsiOZE4gbylhUkMHkxzR+IYLSWHwSbEf8O1ZlRbiy4sMW5YG0M3T3Yj5SyWwVzcFhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PFh9vQp0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PFh9vQp0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2BBB1F000E9; Tue, 26 May 2026 13:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779803226; bh=ZF0Xuto6uiUSOPIHK+KkXFZeKq6Z9bOcLYd9Gbj9YVc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=PFh9vQp0/XvryC3QbV8OO3Ik7ZnQX+3xovWrbvJmIF6bJ2/enMqb1rwBraHHMUryN vsnZtnAc9ws2/Psww6OBYv4a6rAL6gFWDpwmdycviBpcjZ5jN96QAiIiIKAOKtQoF3 EfgjWZMH2gTwQgg5XSPy0pI/TF3lrtRMJeMJlc6wFQ+Sclk6CONgMdqU2mXqXvY5Nk HTr76jXuRgEvQP5i++cLXJd6aFIuXkbMpPMow0rYFFxqM9FhomsxNA0SA7Mdtyx27r C+sDcM06OBCc7ZwsRe+wfSn5E+FCoY88d97lKy+dcsjth5adFUP7OQu1GnRzrmFJ6y uuZrY/kqggsJg== Date: Tue, 26 May 2026 07:47:04 -0600 From: Keith Busch To: Mike Bommarito Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: log when APST skips a state due to latency cap Message-ID: References: <20260523114552.101452-1-michael.bommarito@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260523114552.101452-1-michael.bommarito@gmail.com> On Sat, May 23, 2026 at 07:45:52AM -0400, Mike Bommarito wrote: > Add a dev_info_once() at the skip site that names the state, prints > the actual exit_lat versus the current cap, and points the user at > the module parameter to raise it. Using _once keeps the line to a > single instance per controller; users that want to see every probe > event can still enable dev_dbg. The "_once" is not actually once for each controller; it's just once. Some people have found other similar debug prints to be confusing when they have multiple controllers since it looks like the seemingly problematic controller is not consistent across reboots.