From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FE63405C57 for ; Tue, 26 May 2026 17:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779815767; cv=none; b=C0JIANvjV7hgkgMjHgjZQgJrXGuXXjQ7cUB+qsFsPLZaWbZ39Ac3HDjFGwhSGj63EMrq4/pxLIigERNyhxpMENmzYxMSy7mG2CB/D8aNSkTGeln1mc0ofywavr5zStKM+t77uqP1nkYi7UMF813LltxmY87Ot+/RktPXEyhz6N8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779815767; c=relaxed/simple; bh=RBEHuNsVmU6+ThSKJuEYBB7vzlMO2qvs/8iC6YpvH8o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XxyP9RbekRpGTUOTkImP1pSDe16VgmjDBZBIBYEg+HlbGODZgHI217bEmlzkcp+/BjxcxNCnbe7JLZz5vSHegT0Wdc3I7iaEaYxUTOVLMOlwIeJv/Zx/HIt+KsiOYYWMj2orfoubMwLZr0kMi+H/xZydWJpeKjcvlimS30LduS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ONGIgK4z; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bpaYQsmP; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ONGIgK4z"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bpaYQsmP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779815765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kbKjzg9bSmm9vRJLbDtl4q72jw2NHj5tbX6e2y5JU5I=; b=ONGIgK4zRvc6iaYspKCUuBZ3HSnLvfpJ7irNohDN8vxZvxX9Du82ZWSnI9QfcCG9XKOJgP /DnJtwTkpD7IGIqMhXeNRpYj3b9kti4/KQWtS2NWjqnmzP0Xh1O6MRorRg2Zq8bWZ+plbD RgJqCKS+VY8iI4KJXR29pg1Mn3q87JU= Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-PM5hnQs2M7CejnuIf-AQng-1; Tue, 26 May 2026 13:16:03 -0400 X-MC-Unique: PM5hnQs2M7CejnuIf-AQng-1 X-Mimecast-MFC-AGG-ID: PM5hnQs2M7CejnuIf-AQng_1779815762 Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-439d6202259so18444403fac.1 for ; Tue, 26 May 2026 10:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779815762; x=1780420562; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kbKjzg9bSmm9vRJLbDtl4q72jw2NHj5tbX6e2y5JU5I=; b=bpaYQsmPZTYrJW3bFx4sy/T/D38qfWgs4jn1R8qAW7TgAzkxmjc1BDb1RY27TOyAyk mV+7pchi83hGye2NCxdUPs9lNAGBn/Fgm3x72cLN2pJ4diRbndkJkDKHcBScqH65LxaO DVP5TH25sh98xa+UrTiQijeyP2kLKtrkgkOpFeJyHFA1NbbHtqBImDpwOFYr+uz8+RKE fmInWGriAmL/xeEK73LJN9thPNqGJHbofsiJtt0ovDddjmmwPBz/NXyA/NSdXSdtjYis sAa078XcvE9QRbPCWJYHz3eYxLB/evcK6e9dEQdBWxfaPnBlPYhu1G8jedy4CF7E1wo8 Zb/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779815762; x=1780420562; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kbKjzg9bSmm9vRJLbDtl4q72jw2NHj5tbX6e2y5JU5I=; b=Kb2PfrVURY0QzPXal/ONZk4uTIO2zHODF5VdJX3cXKgV6HrxFPnkmC+KLsSIxSjy1u GltUZ3IMsFdR8cDx8zP/NUnFIXv8YBYjlAajStSWY5LoyXuQxZU+vhlZXOsQkHJGECxI lkovt2iXGbi3U0E4g9LFzDMFHH809h2RLGoQ5UfrCCwvIhSc7461St+rCG2lTBfWcOpT AjBWJgKkGXnqzoep2vgnY/KgyJa3jJ0Tg51BAFCBN2iaFaQxIGZq8fNjNMSYTIQKu0Zz UIfSD61iG3uL1iq+Dg29ZV0tH+gmKz0gEahD8mfZCOJuZDGC2dMWndN43fgvgiA6y4U9 fXcw== X-Forwarded-Encrypted: i=1; AFNElJ9rUdLUMycckwd0IIkRKoDZGZ7JWtVmUN7WXuSzVn8GSXsbveRLiaw88f1F2IC5D614cXeL9W30fRt3Xis=@vger.kernel.org X-Gm-Message-State: AOJu0YxQJsmljWv0JtjUFtIOvcF1Y4TS7Dzo60X/VHEg3BUjaltupz7E Ic29KFFr9ff/JSm0GeaQ2glQ9yL/hjJwOUaksmfUtPhd5Qt9/fqche1925xxf9s+A+FNGY20stK gQAQcjt6uQp7huCoO2ISM08FCTP+WIcWTQHRRjG4SU/h3xoZN1w6waGbN+jIL6Ive1A== X-Gm-Gg: Acq92OGzf+MT6y9o4LtZzaBM8n1qRgObXR3ynEGQhYCDDHV7rHnyoOsrYgRj7jzmKxe hOMKUzmW87vCGyYh7XuOqtL4iZvm38wodeZKyA/4p6IuW6YLXYBnx6YSFd3CdqLMOci+t71TlQ/ iE1lBl9sv04lVeZF7wEq1QUzLNd6UwWy8LvtvspFK9VgRB+g68HXUJZ0ZJ2hKV2Odw4yZQ2H8bL Q99TP6uJOYjMoONSfRaeoW8fsYD499+6AQMHyjoh61ZQ92eEVcDHlr8efxHfxhOvi6yDOJz2er3 d9LoDbiEI+VaCjeFKUPt81rKY/o/ymPCWBLOtzCnWWPpNBz9Aoa3ZFX0K8+eiZ5146MfwA5Zyr7 kGgRfiV6ilV5w8QH/neaVDs/t8tCWhXNvGh6daoM7Po0eVexy72mpsRKkB7OTdtPGE4M= X-Received: by 2002:a05:6820:4b14:b0:69d:d9c5:9308 with SMTP id 006d021491bc7-69dd9c5938emr1142393eaf.16.1779815762447; Tue, 26 May 2026 10:16:02 -0700 (PDT) X-Received: by 2002:a05:6820:4b14:b0:69d:d9c5:9308 with SMTP id 006d021491bc7-69dd9c5938emr1142352eaf.16.1779815761931; Tue, 26 May 2026 10:16:01 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cc812e2018sm148514636d6.28.2026.05.26.10.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 10:16:00 -0700 (PDT) Date: Tue, 26 May 2026 13:15:59 -0400 From: Brian Masney To: Akari Tsuyukusa Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, wenst@chromium.org, laura.nao@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] clk: mediatek: mt8196: Select REGMAP_MMIO for vlpckgen Message-ID: References: <20260522133023.355404-1-akkun11.open@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260522133023.355404-1-akkun11.open@gmail.com> User-Agent: Mutt/2.3.1 (2026-03-20) On Fri, May 22, 2026 at 10:30:23PM +0900, Akari Tsuyukusa wrote: > The MediaTek MT8196 vlpckgen clock driver uses > __devm_regmap_init_mmio_clk() by devm_regmap_init_mmio(), > which is defined in drivers/base/regmap/regmap-mmio.c. > However, the driver's Kconfig entry does not select REGMAP_MMIO. > This causes a linker error when REGMAP_MMIO is not enabled. > > Fix this by selecting REGMAP_MMIO in the Kconfig entry. > > Fixes: 2f8b3ae6f0cb ("clk: mediatek: Add MT8196 vlpckgen clock support") > Cc: stable@vger.kernel.org > Signed-off-by: Akari Tsuyukusa Reviewed-by: Brian Masney