From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F067A402B8D for ; Tue, 26 May 2026 17:36:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779816987; cv=none; b=sYduSacKYfwtprhtqNVBRM6FqduZtSFkfcKXN3xuND1gmpEVmJhr0g7D10qJs3zczVcGdOSDK+FzYYdq4ybqtYqX7C1WFqXhoF+ijhg29qqcpp1RodIbHVS+EemuFJU7C8KcAjlBhB9ajY2YFLqFoAgKN/n5X+62dPcvYqzV+MY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779816987; c=relaxed/simple; bh=itptXuNe4ygUJvTHoay1T9eFRWRgrelgdM2TdraIkac=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i9JDpLQvxs06pNwj+1Pltnzj9x0z+hC0/FFu0qbJQVQCK/CBKPvytbA2lHg72iXg5sYLpksvQxbf89LWHagezGaWMPF0mKKpFtP6b59Nvr9k8oIAJ3lgS/cVa4cWp+b+DozOYtTlWlvMTEoGDrYsd0vtM04LZqN/THU1bLYqgOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E52GbOQe; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E52GbOQe" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-1363e78746eso6224658c88.1 for ; Tue, 26 May 2026 10:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779816985; x=1780421785; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y6BSuOR6NYcvyJ2FNhs6DvFNJ6pd+/sZduNctzVkyME=; b=E52GbOQevGEBxOQPl1qxQB0dUsn97zS5LR9l+3oZBlol4j1ufFoX8qVQMWTVPTpSTi Wxvthh2TON2z7OYKaP7g8y8xSB3tH+LjSS0e/chjZ5e71JxKpNA/+h/oborbyd/IMy5P 32zDvu+5Ulf+giwNWsUceGWHmKfz0/cwdp7LFOA9kGIfyfXSwj+UFWWcfhuPpfwjUojx rTzweKTQzHpQngjSflXX16ZHFWKaG4MTldw5zlHALSa/ekPldrIXlOWoOw2i0fjyD6cq IlLoDvRxSRoEOxAzzPQCW78Wp3yvqovumqpMWEv7tPdHTdBsEvBH15mhjNGyyiNh2EUH 7oYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779816985; x=1780421785; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y6BSuOR6NYcvyJ2FNhs6DvFNJ6pd+/sZduNctzVkyME=; b=j8rhzDuZwOjjJ8G7Mt9sS9/Hib4MLVTZIUOSudQH9hajdfRgaqU2lxJffUguHmZQTm uhOwTVvhd1aGjXVsSykjYRiIFpF7uSM+rLGQzTGeFHrW/eXMIrmhuiYhtRGZjgMDVHcs r10Y0NgvevkTBx7TUXSwe3kmruGKqBdZGByjAbIMYxoirdsysKGMuUvg7VNkRSSQs0YM hQ2TTq/8vEP8DxYUHUvtzAskHIc5ZQBWfEgJXdkMP2UkCQaUn9tW04TT1PhpW9gAIXGN NB3Fqs+mzR9t4XfAWC9zAjR9gtDm9H+/pCNqWKKg6QLorQpW5pqm2pyp3gI+w1Cb8NNa 882w== X-Forwarded-Encrypted: i=1; AFNElJ/iwv7gbIuWUUXotBnfKNxWtvr8pdexbpMBfkaAj6SoV/4BrPYyx4BPbKE5+PzJaZ+CQUBgSYCPvMQMRwk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8W13xiMIiVSBlSVxnsAnv3v+d4JhKn2Sc89ri3EGfYeXkZddT rIUIav4XmZMrV6j6+/G/aEI6I+ahEr4C5/mL+Rt+4heW4gV8JWhqaNse X-Gm-Gg: Acq92OHnhvjaoguzedFopOjfiVAHWKuIWmQdCtlpOd8Cno7+59DCEwvvWQEsCi/tyDh qn8ANvp4PBDfli27pT9QBny5sraZa48JyxjqfE//EKChcVaNNE6WIzvL3Ypgn1Fff+U4lsnY/lt ynaE28TL6gggqnwmUll0K34Ul/oGssfBz9SNJ1WHhwoVQOveS6GyB70d0epDKvt19u7DhqoVM8b j2YMqUwssAGMk9GT8MfxeuWqtOZOlfPU5D1IIfcOvRqNd0EUgxk0DWSY8vQAU9FjyeHfnXhk7Ic E+5PU9COWLIeggno0ABxKTZI7IMy1W4rj1mWa06+mjKMrhtglKEtuNCDQd2GQe2rIZUTK2dEG3+ xzmzSxCnyp/mPQ+NmQ6VGh1r/f6NdqMuocoHdNSXNY+cdJxb8/AI6Te7X8Rl3+weWDtDAopkOeQ F42Yt7j6WZNSh005fVaYGCc6eLSFPpQZVygmIq/r4XPMPof1pyoj1Ve2o47oawa2lR X-Received: by 2002:a05:7022:f206:b0:136:e639:9c14 with SMTP id a92af1059eb24-136e6399e60mr2835502c88.30.1779816984904; Tue, 26 May 2026 10:36:24 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:912f:eb49:d713:7401]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-136b3706ad6sm6655781c88.13.2026.05.26.10.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 10:36:24 -0700 (PDT) Date: Tue, 26 May 2026 10:36:08 -0700 From: Dmitry Torokhov To: Myeonghun Pak , Hans Verkuil Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ijae Kim Subject: Re: [PATCH] Input: rmi4 - release F54 queue on video registration failure Message-ID: References: <20260524182351.27658-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260524182351.27658-1-mhun512@gmail.com> On Mon, May 25, 2026 at 03:23:45AM +0900, Myeonghun Pak wrote: > rmi_f54_probe() initializes the videobuf2 queue before registering the > video device. If video_register_device() fails, probe only unregisters > the V4L2 device and leaves the initialized queue unwound by neither > remove nor file release paths. > > Release the queue before continuing through the existing probe error > path. > > This issue was identified during our ongoing static-analysis research while > reviewing kernel code. > > Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 diagnostics") > Cc: stable@vger.kernel.org > Co-developed-by: Ijae Kim > Signed-off-by: Ijae Kim > Signed-off-by: Myeonghun Pak > --- > drivers/input/rmi4/rmi_f54.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c > index 61909e1a39..fca7b9fec5 100644 > --- a/drivers/input/rmi4/rmi_f54.c > +++ b/drivers/input/rmi4/rmi_f54.c > @@ -722,6 +722,7 @@ static int rmi_f54_probe(struct rmi_function *fn) > ret = video_register_device(&f54->vdev, VFL_TYPE_TOUCH, -1); > if (ret) { > dev_err(&fn->dev, "Unable to register video subdevice."); > + vb2_queue_release(&f54->queue); > goto remove_v4l2; > } > Hans, could you please Ack or Nak it? It is unclear to me if this cleanup is mandatory and whether it is also needed in rmi_f54_remove(). Thanks. -- Dmitry