From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF1993CA493 for ; Tue, 26 May 2026 22:39:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779835153; cv=none; b=m9LE136W7zM3pDJJkfkz3RfTznvYYeAKmez+5JLb9H6WxfwoIkXnqEEvlK36f8owC/NffXrwIczeSDGBbE1kPHo3UoMgQdDzjZmMHwDKgrzpYVnTHMig1BNRGqRmgOf303+zI96tKv7C/KQ3cuCTihT4I0IXNKTYxEXQLSVRZF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779835153; c=relaxed/simple; bh=dQ6K9GZz1ihE8mqFaYgclXUtiyeYTS0M6BDxAmiVaTg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DjvctKnEAyTMkE7afxu9yEt2Lil1KUti3uxtXNnTLUFfdw19SWTQSWSNw5Olhn+yltzdBy6f6imikNRmyFco222HDX7HYZcfQ10sluWHGSIizDsQxLQbqBYNpf90JPOH3MSlaitLY9lBP+pbsAJcbVsRHO0dc+2xEASTIXiCtAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QymfRC09; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZxDxywdq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QymfRC09"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZxDxywdq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779835150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nTo+rj9jPpTZ6MzOUwsfpt4ByYvJX/zAd699vG59KFk=; b=QymfRC09fyNtljC8q81gDEvDrTdrze5nywKb3UWxe3yobclQB0lIk4zZM9gCjiCLtMjZP/ 7x8bdZiUYSQ3BZKcqlV1nIQm7Vuu5fPKtjyIZ9kWMsdsOBjY8jtVV1Fi/bywW7Ab5P7MEz GHngGUCtEd3KB+5G6TRWRcoB3UpeLEU= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-zQzSHzKhP6GsCpTLSWGHDg-1; Tue, 26 May 2026 18:39:09 -0400 X-MC-Unique: zQzSHzKhP6GsCpTLSWGHDg-1 X-Mimecast-MFC-AGG-ID: zQzSHzKhP6GsCpTLSWGHDg_1779835148 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-914b56ea791so686972685a.2 for ; Tue, 26 May 2026 15:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779835148; x=1780439948; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=nTo+rj9jPpTZ6MzOUwsfpt4ByYvJX/zAd699vG59KFk=; b=ZxDxywdq3hIB06j0Dw3OmpwLb25CtDkc4slKZ4nkBV9PFurMybudHafUnRLCWbbrpE ETDuCQZfUQ81aMmYXUJv9oWcrWS83dAdZSqQLsiLMZwOH2DIshYqU51d7DWgVp/rOU1n dDu0Y2GDfP1Vc6LxhZekE6fSst9TK4xv0twcHAZ/A/UvoICquTcEzq2d5qfuUoVQv0TL VaK/yxN0XM0hZxQ0zt7lhHYrMF15JFJLPZtBTMhhLILAlZRfBLhrH8IBbaj6e2vjGNEl lcRrFs6l2boKoDTEwWXU3dw/gEE/e9VRwxaMsCB1g95yRAKj9S4mdnEqWvIqe1a0l8EL 29xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779835148; x=1780439948; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nTo+rj9jPpTZ6MzOUwsfpt4ByYvJX/zAd699vG59KFk=; b=JDyq3IQjnQSLmVQQg6UOyQBT5xO16lMq1Y07xOOQV3CQhliUSujXoGkTHJuwKVdBRt birbSJMOv2GkeE0oRuuHPD+7M5U+spoEv7HiEWkNuIMB+nthFR6rKnhA5FOp7YTi7h/J 0+4u8kRtL9js7cN7Vac1zQ7oLo6anZkJYtQXIvjkA3bF3jA5Q0qRogZUf2DRXzb9stoF V/q15kEFD8RVHiWdII/fxVWCThy/zcsGvp398FeBmkpFmgoWjjXqNuUpIazvjKzLmUMG 6COgtU0qwd91vQaQxPXlVQNAnXgH63vY7s+QV3T+zqcCBdhe3b4y8urJ9pqeXwssxtP+ LGPg== X-Forwarded-Encrypted: i=1; AFNElJ/WSAX/K9mGWFWy44k1kxBkFCIzRVsy7jrGx/qyfk3H9wH9W4V39UQPlWD7Yrq2IeMzEiSh6jedRNCy7Lg=@vger.kernel.org X-Gm-Message-State: AOJu0YwIVOLEhasZPKGYAZeFb4TupKYdgqs3iAv6JQ2duVvNiQVAVR2c qmerPEKseUWU5fB4Ud60nWwpua1vPvFNN0cK2S9bcitFtEswHBhmkw6u+rOAs3+A6Kohh9x4YX/ 7RCPj6Caf5dxNR5K+BHgCrzM9ifjs7TL1pMJUWa5wDxZnZCjVQoY49WpjW2EvuljkfA== X-Gm-Gg: Acq92OHFGJz5b6+r4cdUhXYwy1owuTFhVNxB000Fj1/VnJEpDEkIUG5IHpuJiajUFcB 5eaX3rUQZyZH5B1Npka5/JlQVgJPkaeTVAeh6bpRTm7qzD85Q7lDQVsYgovjj1AGn8SoNq/oMX4 PfwxTxQrSAQpfuxbe1Zab7VJ5gOiBOW7N+ULEkJrIaDkKac0u7deKTcGN+u6wiBypODdz4M+bIH /V2kbDiwyNFZeh57ERPbmR05cU1XBRUK0tvRsONqp/paXaplWzi8pHeqSE77eyC4FrvOw1MpWQx SoyWHzDai9pVf9L74GSt4NA7vi3Xd7UC0s1iWlZUIpZEyCPLxONTChtY3D1O0C2WF83XDfpUp8x g7q3nE1YamDpea3nDx4GYOGarPUSHwSM7YJA+J1cJQPjSUC8czLT45hJ65iKx8hVCjSw= X-Received: by 2002:a05:620a:690f:b0:914:cad9:fa2b with SMTP id af79cd13be357-914cad9fac8mr1968269485a.55.1779835148472; Tue, 26 May 2026 15:39:08 -0700 (PDT) X-Received: by 2002:a05:620a:690f:b0:914:cad9:fa2b with SMTP id af79cd13be357-914cad9fac8mr1968266585a.55.1779835148050; Tue, 26 May 2026 15:39:08 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-914f8713144sm314985185a.21.2026.05.26.15.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 15:39:07 -0700 (PDT) Date: Tue, 26 May 2026 18:39:04 -0400 From: Brian Masney To: "Alexander A. Klimov" Cc: Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Jonas Jensen , Mike Turquette , "moderated list:ARM/MOXA ART SOC" , "open list:COMMON CLK FRAMEWORK" , open list Subject: Re: [PATCH] clk: moxart: remove unused variables, fix refcount leak Message-ID: References: <20260526204227.23181-1-grandmaster@al2klimov.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526204227.23181-1-grandmaster@al2klimov.de> User-Agent: Mutt/2.3.1 (2026-03-20) On Tue, May 26, 2026 at 10:42:26PM +0200, Alexander A. Klimov wrote: > Not only these error checks are redundand, > those of_clk_get() return values weren't cleaned up via clk_put(). > > Fixes: c7bb4fc16ead ("clk: add MOXA ART SoCs clock driver") > Signed-off-by: Alexander A. Klimov Reviewed-by: Brian Masney For the future: Include the version number (v2) on the subject, and include a changelog below the --- with what changed since the last version. You may want to consider using b4 since it'll help set this up for you. Plus it's a much improved contribution experience. https://b4.docs.kernel.org/en/latest/contributor/overview.html Brian