From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85763390998 for ; Wed, 27 May 2026 07:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779866518; cv=none; b=MWuLRip7+J6gycLx+2k38BFmXuFkXhp8C++278Qo0s2blDt2C3Gu6T3I9nGY4VXltjCFPlSaf0aQ8YtenOFRqGSkuJFFQlgc9xs0EFitrXByZfx/6hUM3DEegkdOCsLb7Ny6nvtZpiQNr/jKeID+K/2XUlpkG6HDI50UAdClA34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779866518; c=relaxed/simple; bh=a8s7JtOphjdlMjvBprTXjUUvcfayNfid6SMNJ6WsphY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B8ZH1c+7vPco5Cg1XUGgxairCc/QQrpVlyoy2qnd8Y09gMskftW5X3U3IhMG4k2SswgpT77r4moN47+Ay7IdLD3olEWshMwPiH/FogB3ZUtYE52CfQDAQGG5//f5nfRwLraGJeuy0XfZPlJ/nPRSeev2WqQDg6xHQmvn5r7rbkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kiGDWlL0; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kiGDWlL0" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-83d31ac4017so5712781b3a.3 for ; Wed, 27 May 2026 00:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1779866517; x=1780471317; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SbeQ0cOV/xX8qRCoZ0tY0TlvEmEpG2Jpa9wLZjTTDgQ=; b=kiGDWlL0Mw806Fe952FxMerCCBA69LXrFLx5lZqxVieDf7NuLGuSZ3EOzf74UHPFas NbObQ/BhaPN+PEi6JykiCRWLa08Ahve75Nwx8bHc6Hc1J9mhOn6NBAWLzMB/uUyGK2aM Si+hMj9tvtNkbVxiNpXFGgIlEnb5v5VUzHXv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779866517; x=1780471317; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SbeQ0cOV/xX8qRCoZ0tY0TlvEmEpG2Jpa9wLZjTTDgQ=; b=ipUjDwnmY910Q9v38GjsXImgVhfBHlTXktAdCjx9wgPgfCrzH4KmaMkUm2lJF6KJW7 NQu39wkFxl7IPDQx91PbiOlkmVs3RE16TUPk4biVNe3Bz9saBTQTEhfkt+eLeAQW/btX e7LDXMcORVThgGYQ0MxwD++wixbZEQbTdwl5ckWS5+GEdijZx9kNar2iTuG9l+YGNS+H fvRTKau/bASw5DGmSH6vDzt/TNM0O/ZGYdg5sw1ym/sTkaE985FWA1Zxk2HOvmMNnX7Y vPHPvZAO5wdh4HAwvNwIlP00YomUY6zIF4CuLiBEjtxT39jgbqKGmPPvGg1IOc2act+r HURg== X-Forwarded-Encrypted: i=1; AFNElJ8Sb142A/4gDYm7EkIb7CtZCzs4mgaaanM+4O9muG6onPzhRQlHUGV7x2Y2xGLuvpbf962WmZ83ZtkAPQk=@vger.kernel.org X-Gm-Message-State: AOJu0YzbKfZiq62luso+RwaX0ETRaGMOHTm4eygkwQ9+DBRI7mhhdRe8 HsOTNT+xQKqq/Xw6GezzwTmR5qpelvEg5RO3NIku3PicftiP7YEEQS9KCuhrLopivA== X-Gm-Gg: Acq92OETchpB9rK+TBpYCXT3JThD/j7N9VoejXMNriKIgWmPvfNp3OP+xnzdjCujw/g LHLhvPI9IwvmsyIWelQ3HorHdecsCQB2Kul631J4rI/xcgdKj94hvkuDxd4QIlhjx+1Tk/oWo/E CdDLJbHEZBwbVGgmUFv2j6W6imtB8Y10p7tozPeO+v655tJB/n8CljN1eXJDXd6bYI5ZkBqaTPt Uigv4Gqk92rA1NqubqzbVJ96jrNkk+zzJSA+XYZwx35HQvcSYbz4q33vxXfNOED5plwGAttnSYZ 7w/FkgTOnqSxNKpdy4CQ5bw1XJ6qjTUO1+KikOG9qU4nWlMP4LKKOOltoJc+AcgeXjTmQSRGGkd CI2Y9LApwGPlZ12THcrL1XyN89dP8VU/Xwwy2wzhZWj7w1GM5kmjnmQMuJqowKwMX0uoNU/p/HB a4x9H5uJ3N7zDnatD2LOJ29HPmFlR/+kREMmBSbG3uhFHM7TdFeZhNKPgcYnC/X2c= X-Received: by 2002:a05:6a00:a383:b0:82f:21ee:270e with SMTP id d2e1a72fcca58-8415f6d0bb4mr21703648b3a.42.1779866517012; Wed, 27 May 2026 00:21:57 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:140f:40ed:a6bd:f680]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d70bf92asm1369996b3a.31.2026.05.27.00.21.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 00:21:56 -0700 (PDT) Date: Wed, 27 May 2026 16:21:53 +0900 From: Sergey Senozhatsky To: Cunlong Li Cc: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Andrew Morton , Christoph Hellwig , linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 0/2] zram: fix UAF in zram_bvec_write_partial() and drop dead bio plumbing Message-ID: References: <20260527-zram-v2-0-2fb84b054b5c@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260527-zram-v2-0-2fb84b054b5c@gmail.com> On (26/05/27 12:49), Cunlong Li wrote: > Patch 1 fixes a use-after-free in zram_bvec_write_partial() that > happens on PAGE_SIZE > 4K configurations when a partial write hits a > ZRAM_WB slot. > > Patch 2 is a follow-up cleanup that drops the now-unused bio parameter > from zram_bvec_write_partial() and zram_bvec_write(), no functional > change. Did you test it? Looks reasonable (unless I'm missing something): Reviewed-by: Sergey Senozhatsky